Change to disabled cursor when hovering disabled checkbox #13669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luacmartins
changed the title
melvin-bot
bot
requested review from
grgia and
rushatgabhane
and removed request for
a team
|
@rushatgabhane @grgia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I think for web resize(medium/small) and mobile web we need to apply the change to other place diff --git a/src/components/CheckboxWithTooltip/CheckboxWithTooltipForMobileWebAndNative.js b/src/components/CheckboxWithTooltip/
CheckboxWithTooltipForMobileWebAndNative.js
index ac58d030e..43d3c0626 100644
--- a/src/components/CheckboxWithTooltip/CheckboxWithTooltipForMobileWebAndNative.js
+++ b/src/components/CheckboxWithTooltip/CheckboxWithTooltipForMobileWebAndNative.js
@@ -38,6 +38,7 @@ class CheckboxWithTooltipForMobileWebAndNative extends React.Component {
<Checkbox
isChecked={this.props.isChecked}
onPress={this.showGrowlOrTriggerOnPress}
+ disabled={this.props.disabled}
/>
</View>
);
diff --git a/src/components/CheckboxWithTooltip/index.js b/src/components/CheckboxWithTooltip/index.js
index 83756feb0..ced15a589 100644
--- a/src/components/CheckboxWithTooltip/index.js
+++ b/src/components/CheckboxWithTooltip/index.js
@@ -15,6 +15,7 @@ const CheckboxWithTooltip = (props) => {
onPress={props.onPress}
text={props.text}
toggleTooltip={props.toggleTooltip}
+ disabled={props.disabled}
/>
);
}
@@ -22,7 +23,7 @@ const CheckboxWithTooltip = (props) => {
<Checkbox
isChecked={props.isChecked}
onPress={props.onPress}
- disabled={props.toggleTooltip}
+ disabled={props.disabled}
/>
); |
|
@Pujan92 good point on resize! Thanks! |
rushatgabhane
suggested changes
Dec 19, 2022
|
Updated! |
grgia
approved these changes
Dec 19, 2022
|
Added resizing steps |
|
@grgia @luacmartins sorry that I won't be able to review this PR anytime soon. Please reassign / @grgia could complete the checklist |
|
@grgia would you mind filling the checklist? I think this PR is simple enough that we don't need more reviewers. |
|
No problem! |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2022-12-20.at.10.03.34.AM.movScreen.Recording.2022-12-20.at.10.02.31.AM.movMobile Web - Chrome
Mobile Web - Safari
DesktopScreen.Recording.2022-12-20.at.10.05.06.AM.moviOS
Android
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To DurationThere are no entries Meaningless Changes To DurationShow entries
Show details
|
20 tasks
2 tasks
|
I am commenting on PR, as issue #13627 is locked, I raised the same issue 2 months back here https://expensify.slack.com/archives/C01GTK53T8Q/p1668096360414929 |
|
🚀 Deployed to production by @chiragsalian in version: 1.2.43-1 🚀
|
|
@luacmartins can I ask for the reporting bonus for this now? |
|
|
Left a comment in the issue! Sorry we missed that! |
Thankyou 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Changes the cursor to the disabled state when the Workspace member can't be selected
Fixed Issues
$ #13627
Tests
On Web only:
Offline tests
N/A
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
chrome.mov
Mobile Web - Safari
safari.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov