[NoQA] Fix QR code for web

[staszekscp]

Details

Fix for wrong URL passed to generate QR code for web job in testBuild workflow.
The PR is related to this issue: #13558

Fixed Issues

The PR is related to this issue: #13558

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[melvin-bot]

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A since it only affects GH actions

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
TTI	832.571 ms → 841.755 ms (+9.184 ms, +1.1%)
runJsBundle	196.688 ms → 202.438 ms (+5.750 ms, +2.9%)
regularAppStart	0.016 ms → 0.015 ms (-0.001 ms, -8.2%)
nativeLaunch	10.613 ms → 10.000 ms (-0.613 ms, -5.8%)

Show details

Name	Duration
TTI	Baseline Mean: 832.571 ms Stdev: 35.050 ms (4.2%) Runs: 772.1167510002851 775.7474220003933 787.4210790004581 789.3567949999124 791.6494359998032 796.4681289996952 797.1208840003237 799.7815439999104 804.245528999716 813.9884190000594 816.273288000375 821.6995230000466 824.2428350001574 825.0076559996232 827.4489620001987 827.7467539999634 828.635219999589 835.1980520002544 843.1221519997343 843.8560300003737 850.9005559999496 853.697166999802 860.3373670000583 861.4124950002879 864.982932000421 866.2920310003683 875.6920280000195 877.1027859998867 878.4334060000256 885.0157239995897 914.7050630003214 Current Mean: 841.755 ms Stdev: 42.653 ms (5.1%) Runs: 779.6345990002155 784.9165940005332 785.0076950006187 793.3705759998411 795.6912159994245 803.6347320005298 803.894701000303 804.4254390001297 808.8607180006802 809.0127750001848 812.439022000879 815.1133200004697 821.5401729997247 823.657811999321 835.9176480006427 839.5931340008974 844.1077250000089 845.2715429998934 846.8570479992777 848.1354879997671 857.2685570009053 868.0208550002426 869.1128940004855 869.9757289998233 880.3237590007484 885.2896580006927 886.7464290000498 894.6674019992352 920.961642999202 924.809407999739 936.1353169996291
runJsBundle	Baseline Mean: 196.688 ms Stdev: 22.675 ms (11.5%) Runs: 161 164 169 171 173 174 174 177 178 180 183 188 189 190 193 193 196 197 197 197 197 205 211 213 215 215 218 218 230 235 243 250 Current Mean: 202.438 ms Stdev: 25.313 ms (12.5%) Runs: 161 167 172 173 174 174 176 176 177 182 188 190 194 197 200 201 202 204 205 208 208 215 220 222 223 225 231 232 235 238 253 255
regularAppStart	Baseline Mean: 0.016 ms Stdev: 0.001 ms (6.6%) Runs: 0.014689000323414803 0.014812000095844269 0.0148930000141263 0.014933999627828598 0.015014000236988068 0.015054999850690365 0.015258999541401863 0.015339999459683895 0.01574699953198433 0.01590999960899353 0.015949999913573265 0.016032000072300434 0.016032000072300434 0.016153999604284763 0.0163569999858737 0.016642000526189804 0.016681999899446964 0.016887000761926174 0.01696799974888563 0.017090000212192535 0.017130999825894833 0.017171000130474567 0.017416000366210938 0.01749700028449297 0.01749700028449297 0.017659999430179596 0.017741000279784203 0.018188999965786934 0.018391999416053295 Current Mean: 0.015 ms Stdev: 0.001 ms (6.3%) Runs: 0.013224000111222267 0.01326499879360199 0.013794001191854477 0.013915998861193657 0.014242000877857208 0.014281999319791794 0.014485999941825867 0.014567000791430473 0.014688998460769653 0.014689000323414803 0.014729999005794525 0.01477000117301941 0.014892000705003738 0.014893000945448875 0.014972999691963196 0.014973999932408333 0.01505499891936779 0.01505500078201294 0.015137000009417534 0.015137000009417534 0.015137000009417534 0.015177000313997269 0.015584001317620277 0.015625 0.015706000849604607 0.0157880000770092 0.016235999763011932 0.016600999981164932 0.017171001061797142 0.017333999276161194
nativeLaunch	Baseline Mean: 10.613 ms Stdev: 1.772 ms (16.7%) Runs: 8 8 8 9 9 9 9 9 9 10 10 10 10 10 10 10 11 11 11 11 11 11 11 11 12 12 13 13 14 14 15 Current Mean: 10.000 ms Stdev: 1.934 ms (19.3%) Runs: 7 8 8 8 8 8 9 9 9 9 9 9 9 9 9 9 9 10 10 10 10 11 11 11 12 12 12 12 14 14 15

[OSBotify]

🚀 Deployed to staging by @AndrewGable in version: 1.2.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @yuwenmemon in version: 1.2.42-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅