[Internal QA] Update location usage key #2

[luacmartins]

Details

Asks for permission to always use the user's location.

cc @yuwenmemon

Fixed Issues

$ #13731

Tests

1. Make sure the App builds

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Make sure we no longer get the email from Apple complaining about the missing string.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[melvin-bot]

@Santhosh-Sellavel @thienlnam One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[yuwenmemon]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
TTI	818.539 ms → 845.230 ms (+26.692 ms, +3.3%)
runJsBundle	193.188 ms → 197.625 ms (+4.438 ms, +2.3%)
nativeLaunch	9.310 ms → 9.867 ms (+0.556 ms, +6.0%)
regularAppStart	0.014 ms → 0.015 ms (+0.001 ms, +4.3%)

Show details

Name	Duration
TTI	Baseline Mean: 818.539 ms Stdev: 43.048 ms (5.3%) Runs: 748.1899709999561 751.2735040001571 760.356782999821 770.3945620004088 777.0942519996315 779.5740660000592 789.0130890002474 792.5548959998414 795.2016920000315 797.4826009999961 799.0435779998079 804.1872079996392 804.8983929995447 814.6578320004046 816.4633320001885 816.8350459998474 818.7092880001292 819.3476480003446 821.340765000321 822.5774919996038 831.9882209999487 832.3640559995547 835.6164840003476 837.1514459997416 857.2811909997836 859.9012930002064 874.0244789998978 882.8524810001254 905.4013679996133 940.3851929996163 Current Mean: 845.230 ms Stdev: 25.617 ms (3.0%) Runs: 793.7639119997621 794.5394759997725 802.4746719999239 803.5792089998722 821.409010999836 822.612130000256 823.5545889995992 826.6242420002818 830.0420460002497 833.7435010001063 834.1606999998912 836.3666220000014 837.5330790001899 840.6938800001517 843.5545469997451 846.8712459998205 856.3193939998746 857.3103609997779 859.3627070002258 859.5010369997472 859.6879759998992 862.1486130002886 862.9024040000513 863.3175799995661 865.9723330000415 866.5449879998341 867.9174640001729 874.5471900003031 877.3328860001639 881.4208899997175 896.3326500002295
runJsBundle	Baseline Mean: 193.188 ms Stdev: 25.488 ms (13.2%) Runs: 158 158 159 162 169 169 174 175 176 177 177 178 178 179 185 187 188 194 196 199 200 203 205 207 210 213 219 219 225 235 252 256 Current Mean: 197.625 ms Stdev: 18.592 ms (9.4%) Runs: 168 168 174 175 175 178 178 181 185 185 186 189 190 194 194 197 198 199 200 201 204 207 209 211 212 217 217 217 217 221 236 241
nativeLaunch	Baseline Mean: 9.310 ms Stdev: 1.465 ms (15.7%) Runs: 7 8 8 8 8 8 8 8 8 9 9 9 9 9 9 9 9 9 9 9 10 10 10 10 11 11 12 13 13 Current Mean: 9.867 ms Stdev: 1.543 ms (15.6%) Runs: 8 8 8 8 8 8 8 9 9 9 9 9 9 9 10 10 10 10 10 11 11 11 11 11 11 11 11 12 13 14
regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (7.5%) Runs: 0.01245100051164627 0.012531999498605728 0.013020999729633331 0.013061000034213066 0.013062000274658203 0.013468999415636063 0.013712000101804733 0.01375299971550703 0.01375299971550703 0.01375299971550703 0.013753999955952168 0.013875000178813934 0.013875999487936497 0.013915999792516232 0.013916000723838806 0.013956000097095966 0.014038000255823135 0.014119000174105167 0.014444999396800995 0.01448499970138073 0.014485999941825867 0.014810999855399132 0.014810999855399132 0.0148930000141263 0.015096000395715237 0.015177999623119831 0.015463000163435936 0.015463000163435936 0.016032000072300434 0.016195000149309635 0.016358000226318836 0.016885999590158463 Current Mean: 0.015 ms Stdev: 0.001 ms (6.2%) Runs: 0.012695999816060066 0.013833999633789062 0.014118999242782593 0.014119000174105167 0.014159999787807465 0.014159999787807465 0.014200999401509762 0.014281999319791794 0.014403999783098698 0.014405000023543835 0.014485000632703304 0.014607999473810196 0.01460800040513277 0.0147299999371171 0.0147299999371171 0.014771000482141972 0.014932999387383461 0.014932999387383461 0.014932999387383461 0.014973999932408333 0.015014000236988068 0.015137000009417534 0.015137000009417534 0.015339999459683895 0.015461999922990799 0.015747000463306904 0.01582799945026636 0.015868999995291233 0.016032000072300434 0.016887000761926174 0.01696799974888563 0.017008000053465366

[OSBotify]

🚀 Deployed to staging by @yuwenmemon in version: 1.2.43-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @chiragsalian in version: 1.2.43-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅