-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for two factor codes #13870
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c7b818b
add two factor validation
arosiclair 9c10419
added unit tests for two factor validation
arosiclair 1d4fe66
test entire two factor string for base64
arosiclair 35cf1cf
use two factor code validation
arosiclair fbb1d14
Merge branch 'main' into arosiclair-two-factor-validation
arosiclair ef1693b
rename to CODE_2FA
arosiclair d014d03
simplify regex validation
arosiclair cf2f2b9
simplify password and twofactor validation
arosiclair 2c9ec97
de-nest and further simplify validation
arosiclair 0580cf8
remove object destructuring
arosiclair 0bb5d15
restrict 2FA codes to 6 digits
arosiclair 1ad0dc6
remove outdated comment
arosiclair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
const ValidationUtils = require('../../src/libs/ValidationUtils'); | ||
|
||
describe('ValidationUtils', () => { | ||
describe('isValidTwoFactorCode', () => { | ||
test('numeric two factor code', () => { | ||
expect(ValidationUtils.isValidTwoFactorCode('123456')).toBe(true); | ||
}); | ||
|
||
test('alphanumeric two factor code', () => { | ||
expect(ValidationUtils.isValidTwoFactorCode('abc123')).toBe(true); | ||
}); | ||
|
||
test('special characters two factor code', () => { | ||
expect(ValidationUtils.isValidTwoFactorCode('!@#$%^')).toBe(false); | ||
}); | ||
|
||
test('partial special characters two factor code', () => { | ||
expect(ValidationUtils.isValidTwoFactorCode('abc!@#')).toBe(false); | ||
}); | ||
}); | ||
}); | ||
arosiclair marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.