save checkbox value to draft and button text updation #13965

Pujan92 · 2023-01-03T22:31:04Z

Details

Enable the saving draft option for the checkbox in the first step of the Connect bank account flow.
Update the button text to Continue for the first step of the Manual Bank Account Setup flow.

Fixed Issues

$ #13616
PROPOSAL: #13616 (comment)

Tests

Select any workspace
Select connect bank account option
Click on the checkbox on the first step and go back
Again go to bank account option and observe the checkbox which needs to be checked
Verify the button text to Continue on the first step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Select any workspace
Select connect bank account option
Click on the checkbox on the first step and go back
Again go to bank account option and observe the checkbox which needs to be checked
Verify the button text to Continue on the first step

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-01-04.at.3.41.35.AM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktp.mov

iOS

Uploading ioos.mp4…

Android

anddd.webm

melvin-bot · 2023-01-03T22:31:10Z

@francoisl @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane

@Pujan92 Can you please add Tests, Offline tests and QA steps?

Pujan92 · 2023-01-04T14:21:42Z

@Pujan92 Can you please add Tests, Offline tests and QA steps?

Sorry, forgot to write it. Just updated.

sobitneupane · 2023-01-04T17:12:17Z

Screenshots/Videos

Web

Screen.Recording.2023-01-04.at.22.23.58.mov

Desktop

Screen.Recording.2023-01-04.at.22.13.54.mov

iOS

Screen.Recording.2023-01-04.at.22.31.24.mov

Android

Screen.Recording.2023-01-04.at.22.39.40.mov

sobitneupane

I believe we also want to update "Save & continue" to "Continue" in following places as well:

App/src/pages/ReimbursementAccount/BankAccountPlaidStep.js

Line 82 in 034a6f0

submitButtonText={this.props.translate('common.saveAndContinue')}

App/src/pages/ReimbursementAccount/ReimbursementAccountForm.js

Line 63 in 034a6f0

    
           buttonText={this.props.buttonText || this.props.translate('common.saveAndContinue')}

But I am not sure if we want to change "Save & continue" button to "Continue" at all. Raised here.

cc: @francoisl

Pujan92 · 2023-01-04T20:50:42Z

But I am not sure if we want to change "Save & continue" button to "Continue" at all. Raised here.

Thanks @sobitneupane for raising this and it seems "Save & Continue" need not be changed to "Continue".

francoisl · 2023-01-04T23:14:04Z

Thanks for the quick PR! Looks good to me, but holding on approving for a second - asked a clarification question in Slack about the Continue button for the first step of the manual flow.

sobitneupane · 2023-01-05T19:20:13Z

From the discussion in slack, I think we will like to update BankAccountManualStep only.

App/src/pages/ReimbursementAccount/BankAccountManualStep.js

Line 90 in 034a6f0

submitButtonText={this.props.translate('common.saveAndContinue')}

cc: @francoisl

Pujan92 · 2023-01-05T20:19:20Z

Based on the slack discussion applied the button change only for the first step of the Connect Manually flow and updated the same in the PR description.

francoisl · 2023-01-05T21:03:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-01-05.at.12.55.28.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-01-05.at.1.02.20.PM.mov

Mobile Web - Safari

Screen.Recording.2023-01-05.at.1.00.37.PM.mov

Desktop

Screen.Recording.2023-01-05.at.1.03.01.PM.mov

iOS

Screen.Recording.2023-01-05.at.12.58.24.PM.mov

Android

Screen.Recording.2023-01-05.at.1.01.27.PM.mov

OSBotify · 2023-01-05T21:16:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-01-06T20:27:04Z

🚀 Deployed to staging by @francoisl in version: 1.2.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-01-09T18:05:50Z

🚀 Deployed to production by @Julesssss in version: 1.2.50-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

save checkbox value to draft and button text updation

0e4808c

Pujan92 requested a review from a team as a code owner January 3, 2023 22:31

melvin-bot bot requested review from francoisl and sobitneupane and removed request for a team January 3, 2023 22:31

sobitneupane reviewed Jan 4, 2023

View reviewed changes

revert Continue with Save&Continue

801feea

updated button text to Continue for first step of manual bank setup

72a04ca

francoisl approved these changes Jan 5, 2023

View reviewed changes

francoisl merged commit 72b69c6 into Expensify:main Jan 5, 2023

OSBotify mentioned this pull request Jan 6, 2023

Deploy Checklist: New Expensify 2023-01-06 #14067

Closed

36 tasks

arielgreen mentioned this pull request Jan 19, 2023

[HOLD for payment 2023-01-16] [$2000] Workspace - Checkmark is not marked after Connect Bank Account modal reopened #13616

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

save checkbox value to draft and button text updation #13965

save checkbox value to draft and button text updation #13965

Pujan92 commented Jan 3, 2023 •

edited

Loading

melvin-bot bot commented Jan 3, 2023

sobitneupane left a comment •

edited

Loading

Pujan92 commented Jan 4, 2023

sobitneupane commented Jan 4, 2023

sobitneupane left a comment

Pujan92 commented Jan 4, 2023

francoisl commented Jan 4, 2023 •

edited

Loading

sobitneupane commented Jan 5, 2023

Pujan92 commented Jan 5, 2023

francoisl commented Jan 5, 2023 •

edited

Loading

OSBotify commented Jan 5, 2023

OSBotify commented Jan 6, 2023

OSBotify commented Jan 9, 2023

save checkbox value to draft and button text updation #13965

save checkbox value to draft and button text updation #13965

Conversation

Pujan92 commented Jan 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 3, 2023

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Pujan92 commented Jan 4, 2023

sobitneupane commented Jan 4, 2023

Screenshots/Videos

sobitneupane left a comment

Choose a reason for hiding this comment

Pujan92 commented Jan 4, 2023

francoisl commented Jan 4, 2023 • edited Loading

sobitneupane commented Jan 5, 2023

Pujan92 commented Jan 5, 2023

francoisl commented Jan 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jan 5, 2023

OSBotify commented Jan 6, 2023

OSBotify commented Jan 9, 2023

Pujan92 commented Jan 3, 2023 •

edited

Loading

sobitneupane left a comment •

edited

Loading

francoisl commented Jan 4, 2023 •

edited

Loading

francoisl commented Jan 5, 2023 •

edited

Loading