Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #14150

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Update CONTRIBUTING.md #14150

merged 1 commit into from
Jan 9, 2023

Conversation

michaelhaxhiu
Copy link
Contributor

Coming from this slack discussion. I made a small update to the instructions on how to propose a job (e.g. discover a bug).

Details

Removed the part about "including a solution proposal" in slack reports, when a bug is posted.

@michaelhaxhiu
Update CONTRIBUTING.md
be60b0d 
small update to the instructions
@michaelhaxhiu michaelhaxhiu requested a review from a team as a code owner January 9, 2023 18:48
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team January 9, 2023 18:49
@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2023

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marcochavezf
Copy link
Contributor

Merging since it's only a text change to the contributing guidelines.

@marcochavezf marcochavezf merged commit b558b75 into main Jan 9, 2023
@marcochavezf marcochavezf deleted the updating-job-proposal-guidance branch January 9, 2023 23:02
@melvin-bot melvin-bot bot added the Emergency label Jan 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2023

@marcochavezf looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@marcochavezf
Copy link
Contributor

Removed the Emergency label since it's only a text change to a .md file.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 9, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Duration
App start TTI 702.798 ms → 718.581 ms (+15.783 ms, +2.2%)
App start nativeLaunch 9.571 ms → 20.233 ms (+10.662 ms, +111.4%) 🔴
App start runJsBundle 191.500 ms → 197.323 ms (+5.823 ms, +3.0%)
Open Search Page TTI 611.421 ms → 613.839 ms (+2.419 ms, ±0.0%)
App start regularAppStart 0.015 ms → 0.022 ms (+0.007 ms, +43.4%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 702.798 ms
Stdev: 35.251 ms (5.0%)
Runs: 623.5081730000675 655.1484989998862 655.8366139996797 665.4423869997263 669.9578630002216 674.36275499966 675.5317569999024 676.1686880001798 676.6335349995643 677.4867709996179 685.5920099997893 686.5773910004646 693.487959000282 696.7562220003456 710.4055709997192 713.1289069997147 713.1312640001997 713.9410460004583 716.7793300002813 718.6035789996386 719.8427569996566 720.7749309996143 721.0203390000388 723.6719720000401 724.8763159997761 726.8840659996495 728.0220950003713 752.6350210001692 773.4048279998824 794.3337070001289

Current
Mean: 718.581 ms
Stdev: 28.759 ms (4.0%)
Runs: 665.6559060001746 671.3593330001459 677.9792590001598 682.1706480002031 683.5581430001184 685.6010050000623 691.3790980000049 693.1596309999004 695.4506500000134 700.6689759995788 704.3358309995383 705.9122400004417 708.1122639998794 712.8155439998955 713.7669409997761 718.6047310000286 723.5603229999542 725.2939619999379 725.5224710004404 725.964723999612 729.7716319998726 731.9548389995471 734.0955640003085 734.5473499996588 741.1541120000184 743.1730639999732 752.7666090000421 756.6365550002083 760.4659070000052 760.6055100001395 766.9263530001044 771.6321649998426
App start nativeLaunch Baseline
Mean: 9.571 ms
Stdev: 1.147 ms (12.0%)
Runs: 8 8 8 8 8 9 9 9 9 9 9 9 9 9 9 10 10 10 10 10 10 10 11 11 11 11 12 12

Current
Mean: 20.233 ms
Stdev: 1.564 ms (7.7%)
Runs: 18 18 18 18 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 21 21 21 22 22 22 22 23 23 24
App start runJsBundle Baseline
Mean: 191.500 ms
Stdev: 22.208 ms (11.6%)
Runs: 158 163 171 172 173 173 173 174 175 175 176 181 181 182 184 190 192 192 192 196 199 199 202 208 208 211 221 235 241 248

Current
Mean: 197.323 ms
Stdev: 12.948 ms (6.6%)
Runs: 172 176 177 179 179 184 185 186 189 192 193 194 196 198 200 201 201 202 202 202 203 203 205 206 207 208 209 209 210 222 227
Open Search Page TTI Baseline
Mean: 611.421 ms
Stdev: 22.698 ms (3.7%)
Runs: 578.4539800006896 582.5924070002511 583.4779869997874 588.0079760001972 590.9739990001544 591.0654710000381 595.2129720002413 595.640503000468 595.8535159993917 596.5012209992856 597.3959149997681 598.1828610002995 598.8700359994546 600.1074219997972 602.261758999899 606.6614589998499 608.1854650005698 608.3516029994935 612.0316580003127 612.9433189993724 613.7655439991504 615.5635170005262 617.6778570003808 627.1207689996809 629.8017170000821 630.7740479996428 636.9770919997245 637.6019700001925 642.1011560000479 643.4412840008736 643.8837079992518 683.9775400003418

Current
Mean: 613.839 ms
Stdev: 18.793 ms (3.1%)
Runs: 580.0609129993245 589.8209640001878 590.8006189996377 594.4972329996526 597.9774579992518 599.0425220001489 600.7697350000963 600.9572350000963 602.7716879993677 603.2651780005544 603.3247070005164 603.5898439995944 604.5937090003863 606.0437019998208 606.4517419999465 606.6032309997827 607.8596600005403 609.5179040003568 613.0265300003812 613.556925999932 613.8584799999371 617.9484059996903 622.0961509998888 625.8053800007328 627.5610760003328 627.7985429996625 634.43981899973 636.0111499996856 646.0801189998165 647.5321859996766 647.9490560004488 661.2500820001587
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.002 ms (10.2%)
Runs: 0.012817000038921833 0.013102000579237938 0.013183999806642532 0.01322499942034483 0.013346999883651733 0.013427999801933765 0.013712000101804733 0.013753000646829605 0.013794000260531902 0.013915999792516232 0.013916000723838806 0.014322999864816666 0.01432300079613924 0.014364000409841537 0.014810999855399132 0.014811000786721706 0.015015000477433205 0.015056000091135502 0.015096000395715237 0.015259000472724438 0.015461999922990799 0.015461999922990799 0.015544000081717968 0.0157880000770092 0.01587000023573637 0.016600999981164932 0.016764000058174133 0.017090000212192535 0.01713000051677227 0.017577999271452427 0.017862999811768532 0.0188400000333786

Current
Mean: 0.022 ms
Stdev: 0.002 ms (7.1%)
Runs: 0.019164999946951866 0.01945000048726797 0.019491000100970268 0.01985699962824583 0.020142000168561935 0.020181999541819096 0.020223000086843967 0.020304000005126 0.02034500055015087 0.020426000468432903 0.0204670000821352 0.021239999681711197 0.021403000690042973 0.02144400030374527 0.021606000140309334 0.0217289999127388 0.021809999831020832 0.02193199936300516 0.021932000294327736 0.02197200059890747 0.021972999908030033 0.022053999826312065 0.022053999826312065 0.022134999744594097 0.0224609998986125 0.022501999512314796 0.023884999565780163 0.024210000410676003 0.024821000173687935 0.025553000159561634

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Jan 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify OSBotify mentioned this pull request Jan 10, 2023
Closed
15 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcochavezf in version: 1.2.52-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.2.52-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcochavezf marcochavezf marcochavezf approved these changes

Assignees
No one assigned
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelhaxhiu @marcochavezf @OSBotify