Fix label fonts #14217

luacmartins · 2023-01-10T23:45:40Z

Details

Fixed Issues

$ #14208

Tests

Navigate to the following pages and confirm that the labels style (font, text color and size) looks the same as the image below:

Notifications and Test Preferences in Settings > Preferences
Email, Preferred pronouns and Local time in Chat header > user details
All currencies in + > Request money > Currency symbol
Recents and Contacts in + > Request money > Enter amount > Select participants
To in + > Request money > Enter amount > Select participants > Confirm page
Who paid? and Who was there? in + > Split bill > Enter amount > Select participants > Confirm page

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-01-12T20:50:20Z

@rushatgabhane @yuwenmemon One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

yuwenmemon · 2023-01-12T21:02:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

yuwenmemon

LGTM!

yuwenmemon · 2023-01-12T21:55:51Z

Will leave to @shawnborton for final sign off (feel free to check my screenies in my comment)

shawnborton · 2023-01-13T09:32:28Z

This is so great! A couple more places we can tackle while we're at it:

Label above payment methods:

Transfer balance page:

For the profile page, I know we said we'd skip fixing this until we go back to Account Settings doc but if it's easy, why not fix the "Email address" label which should be smaller when there is an email address present:

luacmartins · 2023-01-13T16:53:44Z

Updated. Here are the new screenshots:

Payment methods

Transfer balance page

Profile page all states

luacmartins · 2023-01-13T16:58:17Z

src/styles/styles.js

-    pushToPageEmptyItemLabel: {
-        color: themeColors.textSupporting,
-        fontSize: variables.fontSizeNormal,
-        maxWidth: 240,


Keeping this maxWidth causes this bug, so I'm removing it here too!

luacmartins · 2023-01-13T18:24:43Z

Chatted 1:1 with Shawn and the input value text color should be white to match the other inputs. Updated to reflect that!

Validate phone state

No phone state

Validate email state

No email state

shawnborton · 2023-01-13T18:32:53Z

Looks great, thanks Carlos!

melvin-bot · 2023-01-13T20:03:17Z

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

yuwenmemon · 2023-01-13T20:04:03Z

False positive, tests were passing.

OSBotify · 2023-01-13T20:07:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-01-16T21:51:24Z

🚀 Deployed to staging by @yuwenmemon in version: 1.2.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-01-18T17:29:14Z

🚀 Deployed to production by @AndrewGable in version: 1.2.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mollfpr · 2023-02-10T14:33:45Z

Heyy, coming from where this issue #14743 where this PR causing the regression—addressed by @fedirjh and here the explanation. Thank you!

luacmartins added 2 commits January 10, 2023 16:13

fix details page

c810e08

fix preferences page

aa46f0d

luacmartins self-assigned this Jan 10, 2023

luacmartins added 4 commits January 10, 2023 16:51

update OptionsSelector

18e581e

Merge branch 'main' into cmartins-fixLabelStyles

cc9327f

rm formLabel style

0e0a840

fix split page caps

006b324

luacmartins marked this pull request as ready for review January 12, 2023 20:49

luacmartins requested a review from a team as a code owner January 12, 2023 20:49

luacmartins requested a review from shawnborton January 12, 2023 20:49

melvin-bot bot requested review from rushatgabhane and yuwenmemon and removed request for a team January 12, 2023 20:50

luacmartins mentioned this pull request Jan 12, 2023

[HOLD for regression tests 2023-01-25] Font style inconsistency in some areas of the app #14208

Closed

6 tasks

yuwenmemon previously approved these changes Jan 12, 2023

View reviewed changes

fix wallet page labels

0479c58

luacmartins dismissed yuwenmemon’s stale review via 0479c58 January 13, 2023 15:55

luacmartins added 2 commits January 13, 2023 09:44

fix email label

c7f6c17

use muted color in all states

c7a6d3f

luacmartins commented Jan 13, 2023

View reviewed changes

change label color

f909045

yuwenmemon approved these changes Jan 13, 2023

View reviewed changes

yuwenmemon merged commit 4a3ed07 into main Jan 13, 2023

yuwenmemon deleted the cmartins-fixLabelStyles branch January 13, 2023 20:03

melvin-bot bot added the Emergency label Jan 13, 2023

yuwenmemon removed the Emergency label Jan 13, 2023

OSBotify mentioned this pull request Jan 16, 2023

Deploy Checklist: New Expensify 2023-01-16 #14333

Closed

22 tasks

This was referenced Feb 2, 2023

[HOLD for payment 2023-02-10] [$1000] Bottom margin missing in Payment methods #14743

Closed

[Fix] Add missing bottom margin style to Payment Page #14746

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix label fonts #14217

Fix label fonts #14217

luacmartins commented Jan 10, 2023 •

edited

Loading

melvin-bot bot commented Jan 12, 2023

yuwenmemon commented Jan 12, 2023 •

edited

Loading

yuwenmemon left a comment

yuwenmemon commented Jan 12, 2023

shawnborton commented Jan 13, 2023

luacmartins commented Jan 13, 2023 •

edited

Loading

luacmartins Jan 13, 2023 •

edited

Loading

luacmartins commented Jan 13, 2023 •

edited

Loading

shawnborton commented Jan 13, 2023

melvin-bot bot commented Jan 13, 2023

yuwenmemon commented Jan 13, 2023

OSBotify commented Jan 13, 2023

OSBotify commented Jan 16, 2023

OSBotify commented Jan 18, 2023

mollfpr commented Feb 10, 2023

Fix label fonts #14217

Fix label fonts #14217

Conversation

luacmartins commented Jan 10, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 12, 2023

yuwenmemon commented Jan 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

yuwenmemon left a comment

Choose a reason for hiding this comment

yuwenmemon commented Jan 12, 2023

shawnborton commented Jan 13, 2023

luacmartins commented Jan 13, 2023 • edited Loading

luacmartins Jan 13, 2023 • edited Loading

Choose a reason for hiding this comment

luacmartins commented Jan 13, 2023 • edited Loading

shawnborton commented Jan 13, 2023

melvin-bot bot commented Jan 13, 2023

yuwenmemon commented Jan 13, 2023

OSBotify commented Jan 13, 2023

OSBotify commented Jan 16, 2023

OSBotify commented Jan 18, 2023

mollfpr commented Feb 10, 2023

luacmartins commented Jan 10, 2023 •

edited

Loading

yuwenmemon commented Jan 12, 2023 •

edited

Loading

luacmartins commented Jan 13, 2023 •

edited

Loading

luacmartins Jan 13, 2023 •

edited

Loading

luacmartins commented Jan 13, 2023 •

edited

Loading