Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add closed report action optimistically when workspace is closed #14343

Merged
merged 8 commits into from
Jan 24, 2023
Merged

Add closed report action optimistically when workspace is closed #14343

merged 8 commits into from
Jan 24, 2023

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Jan 16, 2023 •
edited
Loading

Details

When we delete a workspace, we need to add a closed report action to all its related chat rooms. Hence in this PR we are adding a helper method to create the closed report action (taken from what we are getting from backend right now).

There is one more change, where I am adding default empty object value when we are trying to get the last report action in a chat. I have discovered a bug in main as well where the chat reports right after being deleted got to state with no report actions locally and the lastReportAction has been undefined as a result, causing 404 page if you tried to navigate to that chat before it loaded the reportActions correctly. This simple change should make sure we do not get error if the actions are not loaded yet.

Fixed Issues

$ #14293

Tests

  1. Create a new workspace
  2. Verify the #admins, #announce and Workspace chat has been created
  3. Navigate to Settings > Workspaces > Your workspace > Click the three dots in top right corner > Delete Workspace
  4. Confirm you want to delete the workspace
  5. Verify the three chats mentioned above are showing as (archived) and they are closed with message: This workspace chat is no longer active because %workspaceName% is no longer an active workspace.

Error message in dev:
0. Here in dev, overwrite the $policyID with some invalid value so error is thrown when we attempt to delete Workspace. for example $policyID = '1234123123123123123123123123';

  1. Follow the steps above
  2. When you attempt to delete the workspace, it shows RBR on the Workspace page:

image

  1. Verify the associated chat rooms are not closed and you can send a message there
  2. Clear the RBR on he workspace
  3. You can still send messages in the workspace chats just fine
  • Verify that no errors appear in the JS console

Offline tests

  1. Create a new workspace
  2. Verify all the three chats had been created correctly
  3. Go Offline
  4. Delete the workspace
  5. Verify all the chats are showing as (archived)
  6. Verify all the chats are closed and the message says This workspace chat is no longer active because %workspaceName% is no longer an active workspace.
  7. Go online
  8. Verify everything has synced correctly and no errors are shown

QA Steps

  1. Create a new workspace
  2. Verify the #admins, #announce and Workspace chat has been created
  3. Navigate to Settings > Workspaces > Your workspace > Click the three dots in top right corner > Delete Workspace
  4. Confirm you want to delete the workspace
  5. Verify the three chats mentioned above are showing as (archived) and they are closed with message: This workspace chat is no longer active because %workspaceName% is no longer an active workspace.
  6. Create a new workspace
  7. Go offline
  8. Follow the steps to delete this workspace
  9. Verify the chat reports are archived and the closed report action is showing with This workspace chat is no longer active because %workspaceName% is no longer an active workspace. message.
  10. Go online
  11. Confirm no errors are shown
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
deleteWorkspaceWeb.mp4
Mobile Web - Chrome
deleteWorkspacemWebChrome.mp4
Mobile Web - Safari
deleteWorkspacemWebSafari.mp4
Desktop
deleteWorkspaceiOS.mp4
Android
deleteWorkspaceAndroid.mp4

@mountiny mountiny self-assigned this Jan 16, 2023
@mountiny mountiny marked this pull request as ready for review January 20, 2023 22:55
@mountiny mountiny requested a review from a team as a code owner January 20, 2023 22:55
@melvin-bot melvin-bot bot requested review from nkuoch and rushatgabhane and removed request for a team January 20, 2023 22:56
@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2023

@rushatgabhane @nkuoch One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny
mountiny commented Jan 20, 2023
View reviewed changes
src/pages/home/report/ReportActionsList.js
@@ -175,7 +175,7 @@ class ReportActionsList extends React.Component {
// Make sure the oldest report action loaded is not the first. This is so we do not show the
// skeleton view above the created action in a newly generated optimistic chat or one with not
// that many comments.
const lastReportAction = _.last(this.props.sortedReportActions);
const lastReportAction = _.last(this.props.sortedReportActions) || {};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fixing a different bug I discovered when working on this PR. When the workspace has been deleted, navigating to the archived chats threw error, because the this.props.sortedReportActions was an empty string resulting in lastReportAction being undefined. Hence next line threw error.

@nkuoch
Copy link
Contributor

nkuoch commented Jan 24, 2023 •
edited by mountiny
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
offlineworkspace.mp4
Mobile Web - Chrome
Mobile Web - Safari
Desktop
2023-01-24_13-53-00.mp4
iOS
Android

@nkuoch
Copy link
Contributor

nkuoch commented Jan 24, 2023

I can currently only test on web and desktop. Can someone else do the rest of the testing?

@mountiny
Copy link
Contributor Author

Thank you @nkuoch 🙇

@rushatgabhane Will you be able to finish testing on iOS and Android platforms, please?

rushatgabhane

This comment was marked as off-topic.

Sign in to view

@mountiny
Copy link
Contributor Author

@rushatgabhane Can you please fill in the checklist from @nkuoch? Otherwise the action wont work

@rushatgabhane
Copy link
Member

@mountiny I can't edit @nkuoch's comment if that's what you mean😅

@rushatgabhane
Copy link
Member

How about, I attach rest of the screenshots in a new comment? And you can check of the remaining items

@rushatgabhane
Copy link
Member

rushatgabhane commented Jan 24, 2023 •
edited
Loading

### Android

Online

WhatsApp.Video.2023-01-24.at.23.47.02.mp4

Offline

WhatsApp.Video.2023-01-24.at.23.50.13.mp4
iOS

Online

Screen.Recording.2023-01-24.at.11.56.38.PM.mov

Offline

Screen.Recording.2023-01-24.at.11.58.24.PM.mov
### mWeb - iOS
Screen.Recording.2023-01-25.at.12.01.48.AM.mov
### mWeb - Android
Screen.Recording.2023-01-25.at.12.00.25.AM.mov

@mountiny
Copy link
Contributor Author

@rushatgabhane Always forget about that 😓

Thank you very much!

@mountiny mountiny merged commit 4ddb47e into main Jan 24, 2023
@mountiny mountiny deleted the vit-updateArchiveMessageForAdmin branch January 24, 2023 18:47
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Duration
App start TTI 706.857 ms → 732.044 ms (+25.187 ms, +3.6%)
App start runJsBundle 199.125 ms → 199.903 ms (+0.778 ms, ±0.0%)
App start regularAppStart 0.022 ms → 0.017 ms (-0.005 ms, -24.1%) 🟢
App start nativeLaunch 19.938 ms → 19.533 ms (-0.404 ms, -2.0%)
Open Search Page TTI 616.677 ms → 613.551 ms (-3.126 ms, -0.5%)
Show details
Name Duration
App start TTI Baseline
Mean: 706.857 ms
Stdev: 29.667 ms (4.2%)
Runs: 661.3351559999865 672.1089679999277 672.9121779999696 674.3501750000287 677.2287679999135 680.2303939999547 680.4876580000855 680.6545659999829 682.0476180000696 683.981279999949 684.2394220000133 685.7277589999139 686.9676139999647 687.8577870000154 688.2588210001122 689.9795919999015 700.7943899999373 707.3207749999128 715.3228889999446 723.8094389999751 725.1998519999906 726.8677900000475 729.6418719999492 732.7957979999483 734.4307399999816 734.8640600000508 735.9501839999575 736.1054229999427 737.5689809999894 757.9904680000618 761.1768189999275 771.2140639999416

Current
Mean: 732.044 ms
Stdev: 30.288 ms (4.1%)
Runs: 683.8290599999018 686.9729710000101 693.6425149999559 697.7228019998875 701.0379200000316 704.25192900002 704.8054820001125 707.4961830000393 707.57296400005 711.747555000009 715.1800170000643 716.5767429999541 716.900038999971 717.4175549999345 719.0848419999238 723.4810740000103 727.4997060000896 731.0384810001124 737.0786929999013 743.9840339999646 744.931123000104 746.5953349999618 748.2993189999834 752.5677489999216 754.1104019999038 756.2205419999082 759.6209980000276 766.7971139999572 769.7962170001119 786.8043410000391 788.8742720000446 803.4777559998911
App start runJsBundle Baseline
Mean: 199.125 ms
Stdev: 23.645 ms (11.9%)
Runs: 159 174 176 176 179 179 180 181 182 183 184 185 186 190 191 192 193 194 195 196 205 206 213 214 215 221 221 225 229 230 248 270

Current
Mean: 199.903 ms
Stdev: 17.730 ms (8.9%)
Runs: 173 174 180 181 182 183 183 183 187 189 190 192 193 193 194 197 198 198 200 201 203 211 212 214 221 222 222 223 225 230 243
App start regularAppStart Baseline
Mean: 0.022 ms
Stdev: 0.002 ms (8.1%)
Runs: 0.018839000025764108 0.019286999944597483 0.01961200009100139 0.019694000016897917 0.020060000009834766 0.020264000166207552 0.020304000005126 0.02050799992866814 0.020549000008031726 0.02059000008739531 0.020671000005677342 0.020751999923959374 0.02083300007507205 0.02115899999625981 0.021280999993905425 0.021320999832823873 0.021769999992102385 0.021850999910384417 0.022053999826312065 0.02225799998268485 0.022299000062048435 0.022745999973267317 0.022745999973267317 0.022867999970912933 0.023111999966204166 0.0233559999614954 0.0233559999614954 0.023803999880328774 0.02498399978503585 0.025350000010803342 0.026203999994322658

Current
Mean: 0.017 ms
Stdev: 0.001 ms (3.6%)
Runs: 0.015300000086426735 0.01566500007174909 0.01570700015872717 0.015868999995291233 0.016032000072300434 0.016112999990582466 0.01619499991647899 0.016234999988228083 0.016234999988228083 0.016234999988228083 0.016316999914124608 0.0163569999858737 0.016357999993488193 0.01639799983240664 0.01652099983766675 0.01656099990941584 0.016600999981164932 0.016641999827697873 0.01664300006814301 0.01684599998407066 0.0168869998306036 0.016887000063434243 0.016887000063434243 0.017497000051662326 0.0176189998164773 0.017659000121057034 0.017660000128671527
App start nativeLaunch Baseline
Mean: 19.938 ms
Stdev: 2.106 ms (10.6%)
Runs: 17 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 19 20 20 20 20 21 21 21 22 22 22 23 24 24 26

Current
Mean: 19.533 ms
Stdev: 1.522 ms (7.8%)
Runs: 17 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 20 20 20 20 20 21 21 21 21 21 22 23 23
Open Search Page TTI Baseline
Mean: 616.677 ms
Stdev: 24.814 ms (4.0%)
Runs: 579.9540610001422 586.9970699998084 587.7502030001488 589.8536789999343 592.1612150000874 593.0602620001882 593.8187259999104 594.1586099998094 596.2501219999976 598.3650309999939 601.6474210000597 603.1023760000244 603.1890460001305 604.1031899999361 605.6895759999752 607.9678960000165 608.0513919999357 614.3545330001507 615.8492839999963 616.9638269999996 625.397299000062 625.7066659999546 628.3723150000442 632.6324879999738 632.8143719998188 634.5625 637.6507980001625 640.628703000024 643.9676510000136 645.974650000222 654.4875080001075 675.5900889998302 679.2836919999681

Current
Mean: 613.551 ms
Stdev: 16.690 ms (2.7%)
Runs: 583.8271079999395 589.7777909999713 590.7499180000741 591.3868810001295 592.1068520001136 597.6712650000118 597.9582930000033 598.0005700001493 599.7041829999071 603.1007079998963 603.5096839999314 606.2673339999747 606.5712079999503 610.1245120000094 610.551635999931 612.1541350001935 612.4491779999807 614.8750819999259 615.4947510000784 615.6540940001141 615.776123000076 618.6516529999208 620.8561609999742 623.0775560000911 625.7557789999992 626.3997400000226 626.8202309999615 630.9422200000845 635.4010420001578 637.7390950000845 637.7484140000306 646.9555659999605 649.1335050000343

@OSBotify OSBotify mentioned this pull request Jan 25, 2023
Closed
19 tasks
JediWattson added a commit to JediWattson/App that referenced this pull request Jan 25, 2023
@JediWattson
Squashed commit of the following:
8b858dd 
commit b355edc
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 24 22:03:59 2023 -0500

    Squashed commit of the following:

    commit 811dd58
    Merge: 6f70a7d f133eb4
    Author: Chris Kosuke Tseng <ctseng@expensify.com>
    Date:   Tue Jan 24 15:19:32 2023 -0800

        Merge pull request Expensify#14507 from s77rt/hoverable-onblur

        Fixed regression on Hoverable blur event

    commit 6f70a7d
    Merge: 4ddb47e 3392ff1
    Author: Aldo Canepa Garay <87341702+aldo-expensify@users.noreply.github.com>
    Date:   Tue Jan 24 13:56:15 2023 -0800

        Merge pull request Expensify#14409 from margelo/fix/scroll-to-picker-regression

        Fix: Scroll to picker regression

    commit 4ddb47e
    Merge: c2ff5f8 93199c4
    Author: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    Date:   Tue Jan 24 18:47:32 2023 +0000

        Merge pull request Expensify#14343 from Expensify/vit-updateArchiveMessageForAdmin

        Add closed report action optimistically when workspace is closed

    commit c2ff5f8
    Merge: 25b47da 73d23d8
    Author: Ionatan Wiznia <ionatan@expensify.com>
    Date:   Tue Jan 24 19:41:45 2023 +0100

        Merge pull request Expensify#14440 from Expensify/ionatan_fixcurrencysearch

        Fix currency search

    commit 25b47da
    Merge: 614da95 378dffc
    Author: Jack Nam <30609178+thienlnam@users.noreply.github.com>
    Date:   Tue Jan 24 10:35:53 2023 -0800

        Merge pull request Expensify#14483 from abdulrahuman5196/add-payment-delay

    commit 614da95
    Merge: 4d86f17 559df8b
    Author: Yuwen Memon <yuwen@expensify.com>
    Date:   Tue Jan 24 10:21:33 2023 -0800

        Merge pull request Expensify#14400 from Ollyws/issue-14355

        Fix for: App crashes when splitting a bill offline

    commit 4d86f17
    Merge: a10949d bb3a7d1
    Author: Cristi Paval <cristi@expensify.com>
    Date:   Tue Jan 24 18:33:28 2023 +0200

        Merge pull request Expensify#14255 from Expensify/dangrous-embiggenavatars

        Make avatars in chat welcome messages always big

    commit 73d23d8
    Author: Ionatan Wiznia <ionatan@expensify.com>
    Date:   Tue Jan 24 16:21:32 2023 +0100

        Update src/pages/iou/IOUCurrencySelection.js

        Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

    commit a10949d
    Merge: 49ded4f b545c93
    Author: Andre Fonseca <afonseca@expensify.com>
    Date:   Tue Jan 24 12:21:49 2023 +0000

        Merge pull request Expensify#14347 from Expensify/cmartins-fixMembersPage

        Fix Invite member checkbox selection behavior

    commit 49ded4f
    Merge: 553916c 373335f
    Author: OSBotify <76178356+OSBotify@users.noreply.github.com>
    Date:   Tue Jan 24 05:53:50 2023 -0500

        Merge pull request Expensify#14509 from Expensify/version-BUILD-1E53A036-DC71-4A10-A537-7FE462383690

        Update version to 1.2.58-4 on main

    commit 373335f
    Author: OSBotify <infra+osbotify@expensify.com>
    Date:   Tue Jan 24 10:53:22 2023 +0000

        Update version to 1.2.58-4

    commit 553916c
    Merge: ae66a7f 82b52f1
    Author: Maria D'Costa <maria@expensify.com>
    Date:   Tue Jan 24 14:48:06 2023 +0400

        Merge pull request Expensify#14508 from Expensify/nat-missingimport

        Fix missing import preventing opening Plaid modal

    commit 82b52f1
    Author: Nathalie Kuoch <nkuoch@expensify.com>
    Date:   Tue Jan 24 10:58:00 2023 +0100

        Fix missing import preventing opening Plaid modal

    commit 3392ff1
    Merge: 63ff50a ae66a7f
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Tue Jan 24 10:25:22 2023 +0100

        Merge branch 'main' into fix/scroll-to-picker-regression

    commit 63ff50a
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Tue Jan 24 10:23:52 2023 +0100

        fix: passed invalid ref to measureLayout

    commit c37e279
    Author: Christoph Pader <christoph.pader@outlook.com>
    Date:   Tue Jan 24 10:12:20 2023 +0100

        Update src/components/Form.js

        Co-authored-by: Sahil <thesahindia@gmail.com>

    commit f133eb4
    Author: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
    Date:   Tue Jan 24 09:42:06 2023 +0100

        Fixed regression on Hoverable blur event

    commit 6370512
    Author: Ionatan Wiznia <ionatan@expensify.com>
    Date:   Mon Jan 23 18:03:35 2023 -0300

        Use helper method

    commit 378dffc
    Author: Abdul Rahuman <abdulrahuman5196@gmail.com>
    Date:   Tue Jan 24 02:15:46 2023 +0530

        Adding UI filter to exclude delete pending items to be sent to FlatList when online

        Reference: Expensify#14262

    commit bf7f0da
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Mon Jan 23 14:47:03 2023 +0100

        update comment

    commit a0e9574
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Mon Jan 23 14:46:28 2023 +0100

        fix: add scrollContextEnabled to missing screens

    commit 8c479d2
    Author: Christoph Pader <christoph.pader@outlook.com>
    Date:   Mon Jan 23 14:38:12 2023 +0100

        Update contributingGuides/FORMS.md

        Co-authored-by: Carlos Martins <luacmartins@gmail.com>

    commit b08dc2b
    Author: Christoph Pader <christoph.pader@outlook.com>
    Date:   Mon Jan 23 14:38:01 2023 +0100

        Update src/components/Form.js

        Co-authored-by: Carlos Martins <luacmartins@gmail.com>

    commit 7d59c4b
    Author: Christoph Pader <christoph.pader@outlook.com>
    Date:   Mon Jan 23 14:37:45 2023 +0100

        Update src/components/Form.js

        Co-authored-by: Carlos Martins <luacmartins@gmail.com>

    commit 165af16
    Merge: 27f5fea fd5e781
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Mon Jan 23 14:33:37 2023 +0100

        Merge branch 'main' into fix/scroll-to-picker-regression

    commit 93199c4
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 22:59:15 2023 +0000

        Update JSDoc of the build closed report action method

    commit 3574093
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 22:57:50 2023 +0000

        Fix style

    commit f1ff02d
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 22:57:18 2023 +0000

        Fix the import

    commit a0bc604
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 22:50:24 2023 +0000

        Default to empty object in case report actions are missing

    commit bb3a7d1
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 20 16:52:06 2023 -0500

        update overlay

    commit 54f1706
    Merge: 742e4e7 17edc82
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 20:13:10 2023 +0000

        Merge branch 'main' into vit-updateArchiveMessageForAdmin

    commit 90dcb3f
    Author: Ionatan Wiznia <ionatan@expensify.com>
    Date:   Fri Jan 20 14:06:01 2023 -0300

        Fix currency search

    commit 27f5fea
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 11:11:28 2023 +0100

        fix: add picker scroll functionality to (currently) unused screens

    commit 8cba034
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 11:07:34 2023 +0100

        fix: add picker scroll functionality to AdditionalDetailsStep

    commit b7ff191
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 10:57:46 2023 +0100

        add picker scroll functionality to CompanyStep

    commit 3505fd9
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 10:25:24 2023 +0100

        doc: add docs on how to handle pickers in forms

    commit 8edc865
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 10:06:48 2023 +0100

        fix: add explanation for two Form props

    commit 8172dce
    Merge: 7ba22bd 5aabd37
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 10:03:09 2023 +0100

        Merge branch 'main' into fix/scroll-to-picker-regression

    commit 7ba22bd
    Merge: 65d5e9c b197f26
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 16:48:27 2023 +0100

        Merge branch 'main' into fix/scroll-to-picker-regression

    commit 65d5e9c
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 13:02:18 2023 +0100

        fix: usage of new ref in Form

    commit fe8d4cd
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 13:00:34 2023 +0100

        fix: remove random string in Form

    commit 1cbeaa7
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 12:59:42 2023 +0100

        Use scrollContext and overflow on AddDebitCardPage

    commit 384eedb
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 12:58:51 2023 +0100

        fix: use scrollToOverflowEnabled prop from passed down props

    commit 71a415a
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 12:58:23 2023 +0100

        feat: Introduce scrollContextEnabled and scrollToOverflowEnabled props on Form component

    commit c4e8ea8
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 12:02:07 2023 +0100

        fix: add missing forwardRef to ScrollViewWithContext

    commit 559df8b
    Author: Oliver Wilks <ollywilks@googlemail.com>
    Date:   Wed Jan 18 21:36:36 2023 +0000

        Changed getIOUReportActions filter order

    commit b545c93
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 17:00:26 2023 -0700

        validate if preferred locale changes

    commit e9f4cd3
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:54:01 2023 -0700

        fix toggleAllusers logic

    commit 6ec1826
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:38:05 2023 -0700

        fix logic for select all

    commit b85e275
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:28:16 2023 -0700

        keep select all checked if admin is selected

    commit 96afdf0
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:21:52 2023 -0700

        display error message

    commit 6d0ef22
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:07:02 2023 -0700

        add early return for delete modal

    commit 52dd36f
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:00:07 2023 -0700

        early return if errors are not empty

    commit 8cd37db
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 15:58:16 2023 -0700

        revert changes to select all checkbox

    commit 2237a6b
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 15:35:06 2023 -0700

        rm setWorkspaceMemberErrors

    commit a3a7337
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 15:32:40 2023 -0700

        fix setWorkspaceMemberErrors

    commit 689a4bc
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 15:05:57 2023 -0700

        create setWorkspaceMemberErrors

    commit d31d4be
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:47:26 2023 -0700

        rm comment and create validate

    commit b6d28d3
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:45:21 2023 -0700

        rm filter in submit function

    commit e2a9256
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:42:50 2023 -0700

        fix select all logic

    commit 5be2153
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:38:52 2023 -0700

        clean up removableMembers

    commit dcf6a1d
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:31:30 2023 -0700

        clean up CheckboxWithTooltip

    commit 509be3f
    Merge: be59dc3 3636f1f
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 11:32:16 2023 -0700

        Merge branch 'main' into cmartins-fixMembersPage

    commit be59dc3
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Mon Jan 16 17:23:03 2023 -0700

        rm showTooltipForLogin state

    commit d177feb
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Mon Jan 16 17:20:14 2023 -0700

        rm willTooltipShowForLogin

    commit 0f7f685
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Mon Jan 16 17:15:53 2023 -0700

        rm canBeRemoved var

    commit 742e4e7
    Author: Vit Horacek <vit@expensify.com>
    Date:   Tue Jan 17 00:36:09 2023 +0100

        Clean up

    commit a84aab4
    Author: Vit Horacek <vit@expensify.com>
    Date:   Tue Jan 17 00:33:54 2023 +0100

        Add a comment

    commit 55cbf0f
    Author: Vit Horacek <vit@expensify.com>
    Date:   Mon Jan 16 22:23:54 2023 +0100

        Build method to create closed optimistic actions

    commit 868fff6
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 17:36:47 2023 -0500

        remove another shouldShowLargeAvatars

    commit 19c9602
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 17:33:58 2023 -0500

        remove unused variable

    commit e1e86b3
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 17:32:01 2023 -0500

        center number on mobile

    commit 8407368
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 17:05:58 2023 -0500

        center number

    commit 4aee6b7
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 16:43:33 2023 -0500

        remove shouldShowLargeAvatars

    commit 679476f
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 16:36:20 2023 -0500

        remove console logs and add constant

    commit 0167179
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Thu Jan 12 17:39:39 2023 -0500

        initial updates for new shared size avatars

commit 8992e46
Merge: 7a10eff ae66a7f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 23 17:55:31 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 7a10eff
Merge: c2fb8f8 e43bab5
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 22 20:22:03 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit c2fb8f8
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Jan 19 18:29:28 2023 -0500

    fixed some minor issues

commit 246073a
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Jan 19 18:10:34 2023 -0500

    Update src/components/AttachmentCarousel/CarouselActions/index.native.js

    Co-authored-by: Santhoshkumar Sellavel <85645967+Santhosh-Sellavel@users.noreply.github.com>

commit a8daa2b
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 17 23:31:40 2023 -0500

    minor fixes

commit 9efe361
Merge: 5684e41 e62a79f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 17 23:27:36 2023 -0500

    Merge branch 'main' into arrow-feature-signed

commit 5684e41
Merge: c97a7dc 8662d3d
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 14:46:23 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit c97a7dc
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 14:45:07 2023 -0500

    minor updates for comments

commit 50143fb
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 14:37:49 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit aef4993
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 14:37:14 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit cb4ed59
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 00:04:40 2023 -0500

    removed line

commit 1ce9be6
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 15 23:59:55 2023 -0500

    added comments, fixed linting

commit e7ad0d3
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 15 23:40:27 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Santhoshkumar Sellavel <85645967+Santhosh-Sellavel@users.noreply.github.com>

commit 31e389b
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 15 23:39:54 2023 -0500

    Update src/components/AttachmentCarousel/CarouselActions/index.native.js

    Co-authored-by: Santhoshkumar Sellavel <85645967+Santhosh-Sellavel@users.noreply.github.com>

commit 77eb354
Merge: d286d16 7ca2979
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Jan 14 21:52:11 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit d286d16
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Jan 14 21:48:18 2023 -0500

    fixed issue with highlight

commit 27c4f08
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Jan 14 21:29:34 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit f1e31af
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Jan 14 21:27:01 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 1c3c3f7
Merge: bc8fc1a 5a09253
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 10 22:23:23 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit bc8fc1a
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 10 22:22:21 2023 -0500

    fixed up some code per comments, added debounce to image size

commit 17fe0fc
Merge: 2f73a45 a53b274
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 8 14:43:06 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 2f73a45
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 8 13:49:02 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 2199eae
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 8 13:44:22 2023 -0500

    Update src/components/AttachmentCarousel/CarouselActions/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 65b694a
Merge: ba8c0e9 64b9717
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Jan 4 21:45:08 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit ba8c0e9
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Jan 4 21:44:49 2023 -0500

    changed prop type

commit d9d1889
Merge: d2d4e76 5af5d30
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 3 20:58:04 2023 -0500

    Merge branch 'main' into arrow-feature-signed

commit d2d4e76
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 29 19:28:27 2022 -0500

    used replace for config env

commit c0f4c12
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 29 19:07:14 2022 -0500

    Revert "added replace for ngrok url"

    This reverts commit 7b7a5a0.

commit 2180ca4
Merge: 3738f1f 0bde3f8
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 29 19:05:58 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 3738f1f
Merge: 7b7a5a0 276f177
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 26 19:38:09 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 7b7a5a0
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 26 15:28:37 2022 -0500

    added replace for ngrok url

commit 95069f2
Merge: c257f2c 89e3eef
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 21 18:46:21 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit c257f2c
Merge: bfa027d 5265b5b
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 20 22:41:33 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit bfa027d
Merge: 3465da8 9a52f02
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 19 18:32:54 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 3465da8
Merge: aab283f 3620bf2
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 15 18:32:12 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit aab283f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 15 18:30:06 2022 -0500

    updating var names to explain their use better

commit 3965cff
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 14 18:26:41 2022 -0500

    set dimension undefined to trigger spinner when fetching dimensions

commit 9948fca
Merge: 428aaab 1a03ee3
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 14 17:01:52 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 428aaab
Merge: 704753a 11cf564
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 13 19:05:45 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 704753a
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:41:44 2022 -0500

    Update src/components/PDFView/pdfViewPropTypes.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit e042066
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:41:24 2022 -0500

    Update src/components/ImageView/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit f148909
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:40:08 2022 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 47ed2db
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:39:08 2022 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 938adda
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:37:14 2022 -0500

    Update src/components/ImageView/index.native.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit e46566d
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Dec 11 18:00:15 2022 -0500

    updating attachment download url

commit f1dfd4c
Merge: 2e56ef8 10dd188
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Dec 11 16:54:35 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit 2e56ef8
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 7 22:28:11 2022 -0500

    fixed sliding, set buttons to circles

commit 4dd29c6
Merge: a895d00 5501ff5
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 7 20:27:44 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit a895d00
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 19:32:14 2022 -0500

    cleaned up some of the code in reduce

commit cdd60bc
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 19:25:35 2022 -0500

    added comment to reducer

commit c6e5b53
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 19:15:55 2022 -0500

    added comment, use full url

commit 2226040
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 17:25:55 2022 -0500

    moved auth token method into render to prevent undefined page

commit 337dbf2
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 16:27:20 2022 -0500

    fixed keyboard inputs

commit 8d05018
Merge: 70c9ac3 5869c66
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 16:12:33 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 70c9ac3
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Dec 4 18:49:03 2022 -0500

    fixed error with sorting values, fixing styles

commit 480e550
Merge: f738465 01e7a70
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Dec 4 18:16:56 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit f738465
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Nov 19 18:36:53 2022 -0500

    cleaned up report actions, fixed issue with pagination

commit 7abd76e
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Nov 19 17:29:49 2022 -0500

    updating comment, added required to props

commit 3dd0e19
Merge: a873db7 cd83501
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Nov 19 16:53:21 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit a873db7
Merge: 6f02e04 e09d228
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 14 08:04:46 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 6f02e04
Merge: 5f49543 0de35b9
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 14 08:03:31 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit 5f49543
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 7 23:19:02 2022 -0500

    removed console, removed string replace

commit 2911b43
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 7 22:13:24 2022 -0500

    adding functionality to load more attachments as needed

commit a083df2
Merge: a7200ba 91acada
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 7 20:49:00 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit a7200ba
Merge: 05e8623 63ccac8
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Nov 2 20:36:50 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 05e8623
Merge: fad847f 03d7e8f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Oct 26 18:52:43 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit fad847f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Oct 26 18:38:42 2022 -0400

    moved and renamed some files

commit 7a7ae20
Merge: f6e6b43 70efb00
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Oct 22 23:15:00 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit f6e6b43
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Oct 22 23:14:10 2022 -0400

    removed fix for something that was fixed elsewhere

commit 962c589
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Fri Oct 21 17:44:12 2022 -0400

    fixes for comments

commit 8bbf5a7
Merge: 6b9accf b2acb8f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Fri Oct 21 10:47:07 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 6b9accf
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Oct 20 20:57:08 2022 -0400

    fixed up some mobile issues from the move

commit 799cf6c
Merge: 0cd79cc fbf0334
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Oct 19 20:09:57 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 0cd79cc
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Oct 18 21:26:07 2022 -0400

    reverted back the swipeableview, move events with web-based carousel

commit 5b303d0
Merge: 4c76f2e 555a679
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Oct 18 20:09:35 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 4c76f2e
Merge: 16531eb b299503
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Sep 29 21:32:03 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 16531eb
Merge: e327533 b75faf0
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Sep 25 09:02:49 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit e327533
Merge: f1e3411 09ff150
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Sep 21 18:31:08 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit f1e3411
Merge: 468cba3 0302ce7
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Sep 19 07:53:10 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 468cba3
Merge: 594ff07 ca08fb0
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Sep 13 09:55:56 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 594ff07
Merge: 59e461c f95b761
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Sep 7 18:43:07 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 59e461c
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Sep 5 14:05:04 2022 -0400

    set up attachment download to work

commit 19d648a
Merge: 240e1e3 11761be
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Sep 5 11:44:04 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 240e1e3
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Aug 30 19:22:53 2022 -0400

    use shap instead of object for linting

commit 9a9620e
Merge: 8aaf7fe 41ec9bd
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Aug 30 18:52:33 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 8aaf7fe
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Aug 13 19:41:04 2022 -0400

    cleaned up code, fixed some arrow showing issues

commit 91a5a05
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Aug 13 16:52:18 2022 -0400

    adding a native press event for pdfs

commit 191d8d7
Merge: 0366275 a06358c
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jul 31 13:34:12 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 0366275
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jul 31 13:10:11 2022 -0400

    fixed up some issues with pdf

commit 199a8b1
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jul 26 23:22:45 2022 -0400

    Set up animation to swipe

commit 69d6a97
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jul 19 23:23:36 2022 -0400

    added resize for cycling images

commit 70d5d29
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jul 19 23:13:37 2022 -0400

    adding some logic to update the size of image when cycled

commit e2e9633
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jul 19 22:19:01 2022 -0400

    finished with swiping to change images

commit ad64a2f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jul 18 21:22:03 2022 -0400

    moved everything into carousel

commit b741616
Author: Robert <JediWattson@users.noreply.github.com>
Date:   Sun Jul 17 19:45:51 2022 -0400

    setting up show arrows with ios

commit 656d0da
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sat Jul 2 13:27:56 2022 -0400

    linting fixes

commit e38f4a8
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sat Jul 2 13:19:10 2022 -0400

    set up event handlers and styling to show arrow on mouse over

commit ecd2675
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 26 17:48:36 2022 -0400

    added arrow key handler, cleaned up function and helper text

commit 5886c90
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Mon Jun 6 16:11:30 2022 -0400

    reverting changes to image updates

commit 225fbd3
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 13:38:08 2022 -0400

    removed unused state pieces

commit bf7e03e
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 13:35:38 2022 -0400

    removed styles

commit b52ee9c
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 13:25:03 2022 -0400

    cleaned up styling of buttons

commit 2e6ae8d
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 12:46:19 2022 -0400

    wrong value passed

commit 33a8e35
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 12:18:56 2022 -0400

    removed dry code

commit 0e0cdf1
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 12:14:36 2022 -0400

    use button for app default styles, added disable

commit c216164
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Wed Jun 1 15:27:47 2022 -0400

    adding carousel to attachment modal
JediWattson added a commit to JediWattson/App that referenced this pull request Jan 25, 2023
@JediWattson
Squashed commit of the following:
b355edc 
commit 811dd58
Merge: 6f70a7d f133eb4
Author: Chris Kosuke Tseng <ctseng@expensify.com>
Date:   Tue Jan 24 15:19:32 2023 -0800

    Merge pull request Expensify#14507 from s77rt/hoverable-onblur

    Fixed regression on Hoverable blur event

commit 6f70a7d
Merge: 4ddb47e 3392ff1
Author: Aldo Canepa Garay <87341702+aldo-expensify@users.noreply.github.com>
Date:   Tue Jan 24 13:56:15 2023 -0800

    Merge pull request Expensify#14409 from margelo/fix/scroll-to-picker-regression

    Fix: Scroll to picker regression

commit 4ddb47e
Merge: c2ff5f8 93199c4
Author: Vit Horacek <36083550+mountiny@users.noreply.github.com>
Date:   Tue Jan 24 18:47:32 2023 +0000

    Merge pull request Expensify#14343 from Expensify/vit-updateArchiveMessageForAdmin

    Add closed report action optimistically when workspace is closed

commit c2ff5f8
Merge: 25b47da 73d23d8
Author: Ionatan Wiznia <ionatan@expensify.com>
Date:   Tue Jan 24 19:41:45 2023 +0100

    Merge pull request Expensify#14440 from Expensify/ionatan_fixcurrencysearch

    Fix currency search

commit 25b47da
Merge: 614da95 378dffc
Author: Jack Nam <30609178+thienlnam@users.noreply.github.com>
Date:   Tue Jan 24 10:35:53 2023 -0800

    Merge pull request Expensify#14483 from abdulrahuman5196/add-payment-delay

commit 614da95
Merge: 4d86f17 559df8b
Author: Yuwen Memon <yuwen@expensify.com>
Date:   Tue Jan 24 10:21:33 2023 -0800

    Merge pull request Expensify#14400 from Ollyws/issue-14355

    Fix for: App crashes when splitting a bill offline

commit 4d86f17
Merge: a10949d bb3a7d1
Author: Cristi Paval <cristi@expensify.com>
Date:   Tue Jan 24 18:33:28 2023 +0200

    Merge pull request Expensify#14255 from Expensify/dangrous-embiggenavatars

    Make avatars in chat welcome messages always big

commit 73d23d8
Author: Ionatan Wiznia <ionatan@expensify.com>
Date:   Tue Jan 24 16:21:32 2023 +0100

    Update src/pages/iou/IOUCurrencySelection.js

    Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

commit a10949d
Merge: 49ded4f b545c93
Author: Andre Fonseca <afonseca@expensify.com>
Date:   Tue Jan 24 12:21:49 2023 +0000

    Merge pull request Expensify#14347 from Expensify/cmartins-fixMembersPage

    Fix Invite member checkbox selection behavior

commit 49ded4f
Merge: 553916c 373335f
Author: OSBotify <76178356+OSBotify@users.noreply.github.com>
Date:   Tue Jan 24 05:53:50 2023 -0500

    Merge pull request Expensify#14509 from Expensify/version-BUILD-1E53A036-DC71-4A10-A537-7FE462383690

    Update version to 1.2.58-4 on main

commit 373335f
Author: OSBotify <infra+osbotify@expensify.com>
Date:   Tue Jan 24 10:53:22 2023 +0000

    Update version to 1.2.58-4

commit 553916c
Merge: ae66a7f 82b52f1
Author: Maria D'Costa <maria@expensify.com>
Date:   Tue Jan 24 14:48:06 2023 +0400

    Merge pull request Expensify#14508 from Expensify/nat-missingimport

    Fix missing import preventing opening Plaid modal

commit 82b52f1
Author: Nathalie Kuoch <nkuoch@expensify.com>
Date:   Tue Jan 24 10:58:00 2023 +0100

    Fix missing import preventing opening Plaid modal

commit 3392ff1
Merge: 63ff50a ae66a7f
Author: Christoph Pader <christoph@margelo.io>
Date:   Tue Jan 24 10:25:22 2023 +0100

    Merge branch 'main' into fix/scroll-to-picker-regression

commit 63ff50a
Author: Christoph Pader <christoph@margelo.io>
Date:   Tue Jan 24 10:23:52 2023 +0100

    fix: passed invalid ref to measureLayout

commit c37e279
Author: Christoph Pader <christoph.pader@outlook.com>
Date:   Tue Jan 24 10:12:20 2023 +0100

    Update src/components/Form.js

    Co-authored-by: Sahil <thesahindia@gmail.com>

commit f133eb4
Author: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
Date:   Tue Jan 24 09:42:06 2023 +0100

    Fixed regression on Hoverable blur event

commit 6370512
Author: Ionatan Wiznia <ionatan@expensify.com>
Date:   Mon Jan 23 18:03:35 2023 -0300

    Use helper method

commit 378dffc
Author: Abdul Rahuman <abdulrahuman5196@gmail.com>
Date:   Tue Jan 24 02:15:46 2023 +0530

    Adding UI filter to exclude delete pending items to be sent to FlatList when online

    Reference: Expensify#14262

commit bf7f0da
Author: Christoph Pader <christoph@margelo.io>
Date:   Mon Jan 23 14:47:03 2023 +0100

    update comment

commit a0e9574
Author: Christoph Pader <christoph@margelo.io>
Date:   Mon Jan 23 14:46:28 2023 +0100

    fix: add scrollContextEnabled to missing screens

commit 8c479d2
Author: Christoph Pader <christoph.pader@outlook.com>
Date:   Mon Jan 23 14:38:12 2023 +0100

    Update contributingGuides/FORMS.md

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit b08dc2b
Author: Christoph Pader <christoph.pader@outlook.com>
Date:   Mon Jan 23 14:38:01 2023 +0100

    Update src/components/Form.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 7d59c4b
Author: Christoph Pader <christoph.pader@outlook.com>
Date:   Mon Jan 23 14:37:45 2023 +0100

    Update src/components/Form.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 165af16
Merge: 27f5fea fd5e781
Author: Christoph Pader <christoph@margelo.io>
Date:   Mon Jan 23 14:33:37 2023 +0100

    Merge branch 'main' into fix/scroll-to-picker-regression

commit 93199c4
Author: Vit Horacek <vit@expensify.com>
Date:   Fri Jan 20 22:59:15 2023 +0000

    Update JSDoc of the build closed report action method

commit 3574093
Author: Vit Horacek <vit@expensify.com>
Date:   Fri Jan 20 22:57:50 2023 +0000

    Fix style

commit f1ff02d
Author: Vit Horacek <vit@expensify.com>
Date:   Fri Jan 20 22:57:18 2023 +0000

    Fix the import

commit a0bc604
Author: Vit Horacek <vit@expensify.com>
Date:   Fri Jan 20 22:50:24 2023 +0000

    Default to empty object in case report actions are missing

commit bb3a7d1
Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
Date:   Fri Jan 20 16:52:06 2023 -0500

    update overlay

commit 54f1706
Merge: 742e4e7 17edc82
Author: Vit Horacek <vit@expensify.com>
Date:   Fri Jan 20 20:13:10 2023 +0000

    Merge branch 'main' into vit-updateArchiveMessageForAdmin

commit 90dcb3f
Author: Ionatan Wiznia <ionatan@expensify.com>
Date:   Fri Jan 20 14:06:01 2023 -0300

    Fix currency search

commit 27f5fea
Author: Christoph Pader <christoph@margelo.io>
Date:   Fri Jan 20 11:11:28 2023 +0100

    fix: add picker scroll functionality to (currently) unused screens

commit 8cba034
Author: Christoph Pader <christoph@margelo.io>
Date:   Fri Jan 20 11:07:34 2023 +0100

    fix: add picker scroll functionality to AdditionalDetailsStep

commit b7ff191
Author: Christoph Pader <christoph@margelo.io>
Date:   Fri Jan 20 10:57:46 2023 +0100

    add picker scroll functionality to CompanyStep

commit 3505fd9
Author: Christoph Pader <christoph@margelo.io>
Date:   Fri Jan 20 10:25:24 2023 +0100

    doc: add docs on how to handle pickers in forms

commit 8edc865
Author: Christoph Pader <christoph@margelo.io>
Date:   Fri Jan 20 10:06:48 2023 +0100

    fix: add explanation for two Form props

commit 8172dce
Merge: 7ba22bd 5aabd37
Author: Christoph Pader <christoph@margelo.io>
Date:   Fri Jan 20 10:03:09 2023 +0100

    Merge branch 'main' into fix/scroll-to-picker-regression

commit 7ba22bd
Merge: 65d5e9c b197f26
Author: Christoph Pader <christoph@margelo.io>
Date:   Thu Jan 19 16:48:27 2023 +0100

    Merge branch 'main' into fix/scroll-to-picker-regression

commit 65d5e9c
Author: Christoph Pader <christoph@margelo.io>
Date:   Thu Jan 19 13:02:18 2023 +0100

    fix: usage of new ref in Form

commit fe8d4cd
Author: Christoph Pader <christoph@margelo.io>
Date:   Thu Jan 19 13:00:34 2023 +0100

    fix: remove random string in Form

commit 1cbeaa7
Author: Christoph Pader <christoph@margelo.io>
Date:   Thu Jan 19 12:59:42 2023 +0100

    Use scrollContext and overflow on AddDebitCardPage

commit 384eedb
Author: Christoph Pader <christoph@margelo.io>
Date:   Thu Jan 19 12:58:51 2023 +0100

    fix: use scrollToOverflowEnabled prop from passed down props

commit 71a415a
Author: Christoph Pader <christoph@margelo.io>
Date:   Thu Jan 19 12:58:23 2023 +0100

    feat: Introduce scrollContextEnabled and scrollToOverflowEnabled props on Form component

commit c4e8ea8
Author: Christoph Pader <christoph@margelo.io>
Date:   Thu Jan 19 12:02:07 2023 +0100

    fix: add missing forwardRef to ScrollViewWithContext

commit 559df8b
Author: Oliver Wilks <ollywilks@googlemail.com>
Date:   Wed Jan 18 21:36:36 2023 +0000

    Changed getIOUReportActions filter order

commit b545c93
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 17:00:26 2023 -0700

    validate if preferred locale changes

commit e9f4cd3
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 16:54:01 2023 -0700

    fix toggleAllusers logic

commit 6ec1826
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 16:38:05 2023 -0700

    fix logic for select all

commit b85e275
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 16:28:16 2023 -0700

    keep select all checked if admin is selected

commit 96afdf0
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 16:21:52 2023 -0700

    display error message

commit 6d0ef22
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 16:07:02 2023 -0700

    add early return for delete modal

commit 52dd36f
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 16:00:07 2023 -0700

    early return if errors are not empty

commit 8cd37db
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 15:58:16 2023 -0700

    revert changes to select all checkbox

commit 2237a6b
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 15:35:06 2023 -0700

    rm setWorkspaceMemberErrors

commit a3a7337
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 15:32:40 2023 -0700

    fix setWorkspaceMemberErrors

commit 689a4bc
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 15:05:57 2023 -0700

    create setWorkspaceMemberErrors

commit d31d4be
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 14:47:26 2023 -0700

    rm comment and create validate

commit b6d28d3
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 14:45:21 2023 -0700

    rm filter in submit function

commit e2a9256
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 14:42:50 2023 -0700

    fix select all logic

commit 5be2153
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 14:38:52 2023 -0700

    clean up removableMembers

commit dcf6a1d
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 14:31:30 2023 -0700

    clean up CheckboxWithTooltip

commit 509be3f
Merge: be59dc3 3636f1f
Author: Carlos Martins <cmartins@expensify.com>
Date:   Tue Jan 17 11:32:16 2023 -0700

    Merge branch 'main' into cmartins-fixMembersPage

commit be59dc3
Author: Carlos Martins <cmartins@expensify.com>
Date:   Mon Jan 16 17:23:03 2023 -0700

    rm showTooltipForLogin state

commit d177feb
Author: Carlos Martins <cmartins@expensify.com>
Date:   Mon Jan 16 17:20:14 2023 -0700

    rm willTooltipShowForLogin

commit 0f7f685
Author: Carlos Martins <cmartins@expensify.com>
Date:   Mon Jan 16 17:15:53 2023 -0700

    rm canBeRemoved var

commit 742e4e7
Author: Vit Horacek <vit@expensify.com>
Date:   Tue Jan 17 00:36:09 2023 +0100

    Clean up

commit a84aab4
Author: Vit Horacek <vit@expensify.com>
Date:   Tue Jan 17 00:33:54 2023 +0100

    Add a comment

commit 55cbf0f
Author: Vit Horacek <vit@expensify.com>
Date:   Mon Jan 16 22:23:54 2023 +0100

    Build method to create closed optimistic actions

commit 868fff6
Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
Date:   Fri Jan 13 17:36:47 2023 -0500

    remove another shouldShowLargeAvatars

commit 19c9602
Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
Date:   Fri Jan 13 17:33:58 2023 -0500

    remove unused variable

commit e1e86b3
Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
Date:   Fri Jan 13 17:32:01 2023 -0500

    center number on mobile

commit 8407368
Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
Date:   Fri Jan 13 17:05:58 2023 -0500

    center number

commit 4aee6b7
Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
Date:   Fri Jan 13 16:43:33 2023 -0500

    remove shouldShowLargeAvatars

commit 679476f
Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
Date:   Fri Jan 13 16:36:20 2023 -0500

    remove console logs and add constant

commit 0167179
Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
Date:   Thu Jan 12 17:39:39 2023 -0500

    initial updates for new shared size avatars
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.59-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

JediWattson added a commit to JediWattson/App that referenced this pull request Jan 26, 2023
@JediWattson
Squashed commit of the following:
edd1455 
commit e54c4b8
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Jan 25 21:31:13 2023 -0500

    fixing lint errors

commit 445c9f7
Merge: b355edc a9f1892
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 24 22:16:06 2023 -0500

    Merge remote-tracking branch 'upstream/main' into arrow-feature-signed

commit b355edc
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 24 22:03:59 2023 -0500

    Squashed commit of the following:

    commit 811dd58
    Merge: 6f70a7d f133eb4
    Author: Chris Kosuke Tseng <ctseng@expensify.com>
    Date:   Tue Jan 24 15:19:32 2023 -0800

        Merge pull request Expensify#14507 from s77rt/hoverable-onblur

        Fixed regression on Hoverable blur event

    commit 6f70a7d
    Merge: 4ddb47e 3392ff1
    Author: Aldo Canepa Garay <87341702+aldo-expensify@users.noreply.github.com>
    Date:   Tue Jan 24 13:56:15 2023 -0800

        Merge pull request Expensify#14409 from margelo/fix/scroll-to-picker-regression

        Fix: Scroll to picker regression

    commit 4ddb47e
    Merge: c2ff5f8 93199c4
    Author: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    Date:   Tue Jan 24 18:47:32 2023 +0000

        Merge pull request Expensify#14343 from Expensify/vit-updateArchiveMessageForAdmin

        Add closed report action optimistically when workspace is closed

    commit c2ff5f8
    Merge: 25b47da 73d23d8
    Author: Ionatan Wiznia <ionatan@expensify.com>
    Date:   Tue Jan 24 19:41:45 2023 +0100

        Merge pull request Expensify#14440 from Expensify/ionatan_fixcurrencysearch

        Fix currency search

    commit 25b47da
    Merge: 614da95 378dffc
    Author: Jack Nam <30609178+thienlnam@users.noreply.github.com>
    Date:   Tue Jan 24 10:35:53 2023 -0800

        Merge pull request Expensify#14483 from abdulrahuman5196/add-payment-delay

    commit 614da95
    Merge: 4d86f17 559df8b
    Author: Yuwen Memon <yuwen@expensify.com>
    Date:   Tue Jan 24 10:21:33 2023 -0800

        Merge pull request Expensify#14400 from Ollyws/issue-14355

        Fix for: App crashes when splitting a bill offline

    commit 4d86f17
    Merge: a10949d bb3a7d1
    Author: Cristi Paval <cristi@expensify.com>
    Date:   Tue Jan 24 18:33:28 2023 +0200

        Merge pull request Expensify#14255 from Expensify/dangrous-embiggenavatars

        Make avatars in chat welcome messages always big

    commit 73d23d8
    Author: Ionatan Wiznia <ionatan@expensify.com>
    Date:   Tue Jan 24 16:21:32 2023 +0100

        Update src/pages/iou/IOUCurrencySelection.js

        Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

    commit a10949d
    Merge: 49ded4f b545c93
    Author: Andre Fonseca <afonseca@expensify.com>
    Date:   Tue Jan 24 12:21:49 2023 +0000

        Merge pull request Expensify#14347 from Expensify/cmartins-fixMembersPage

        Fix Invite member checkbox selection behavior

    commit 49ded4f
    Merge: 553916c 373335f
    Author: OSBotify <76178356+OSBotify@users.noreply.github.com>
    Date:   Tue Jan 24 05:53:50 2023 -0500

        Merge pull request Expensify#14509 from Expensify/version-BUILD-1E53A036-DC71-4A10-A537-7FE462383690

        Update version to 1.2.58-4 on main

    commit 373335f
    Author: OSBotify <infra+osbotify@expensify.com>
    Date:   Tue Jan 24 10:53:22 2023 +0000

        Update version to 1.2.58-4

    commit 553916c
    Merge: ae66a7f 82b52f1
    Author: Maria D'Costa <maria@expensify.com>
    Date:   Tue Jan 24 14:48:06 2023 +0400

        Merge pull request Expensify#14508 from Expensify/nat-missingimport

        Fix missing import preventing opening Plaid modal

    commit 82b52f1
    Author: Nathalie Kuoch <nkuoch@expensify.com>
    Date:   Tue Jan 24 10:58:00 2023 +0100

        Fix missing import preventing opening Plaid modal

    commit 3392ff1
    Merge: 63ff50a ae66a7f
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Tue Jan 24 10:25:22 2023 +0100

        Merge branch 'main' into fix/scroll-to-picker-regression

    commit 63ff50a
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Tue Jan 24 10:23:52 2023 +0100

        fix: passed invalid ref to measureLayout

    commit c37e279
    Author: Christoph Pader <christoph.pader@outlook.com>
    Date:   Tue Jan 24 10:12:20 2023 +0100

        Update src/components/Form.js

        Co-authored-by: Sahil <thesahindia@gmail.com>

    commit f133eb4
    Author: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
    Date:   Tue Jan 24 09:42:06 2023 +0100

        Fixed regression on Hoverable blur event

    commit 6370512
    Author: Ionatan Wiznia <ionatan@expensify.com>
    Date:   Mon Jan 23 18:03:35 2023 -0300

        Use helper method

    commit 378dffc
    Author: Abdul Rahuman <abdulrahuman5196@gmail.com>
    Date:   Tue Jan 24 02:15:46 2023 +0530

        Adding UI filter to exclude delete pending items to be sent to FlatList when online

        Reference: Expensify#14262

    commit bf7f0da
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Mon Jan 23 14:47:03 2023 +0100

        update comment

    commit a0e9574
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Mon Jan 23 14:46:28 2023 +0100

        fix: add scrollContextEnabled to missing screens

    commit 8c479d2
    Author: Christoph Pader <christoph.pader@outlook.com>
    Date:   Mon Jan 23 14:38:12 2023 +0100

        Update contributingGuides/FORMS.md

        Co-authored-by: Carlos Martins <luacmartins@gmail.com>

    commit b08dc2b
    Author: Christoph Pader <christoph.pader@outlook.com>
    Date:   Mon Jan 23 14:38:01 2023 +0100

        Update src/components/Form.js

        Co-authored-by: Carlos Martins <luacmartins@gmail.com>

    commit 7d59c4b
    Author: Christoph Pader <christoph.pader@outlook.com>
    Date:   Mon Jan 23 14:37:45 2023 +0100

        Update src/components/Form.js

        Co-authored-by: Carlos Martins <luacmartins@gmail.com>

    commit 165af16
    Merge: 27f5fea fd5e781
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Mon Jan 23 14:33:37 2023 +0100

        Merge branch 'main' into fix/scroll-to-picker-regression

    commit 93199c4
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 22:59:15 2023 +0000

        Update JSDoc of the build closed report action method

    commit 3574093
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 22:57:50 2023 +0000

        Fix style

    commit f1ff02d
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 22:57:18 2023 +0000

        Fix the import

    commit a0bc604
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 22:50:24 2023 +0000

        Default to empty object in case report actions are missing

    commit bb3a7d1
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 20 16:52:06 2023 -0500

        update overlay

    commit 54f1706
    Merge: 742e4e7 17edc82
    Author: Vit Horacek <vit@expensify.com>
    Date:   Fri Jan 20 20:13:10 2023 +0000

        Merge branch 'main' into vit-updateArchiveMessageForAdmin

    commit 90dcb3f
    Author: Ionatan Wiznia <ionatan@expensify.com>
    Date:   Fri Jan 20 14:06:01 2023 -0300

        Fix currency search

    commit 27f5fea
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 11:11:28 2023 +0100

        fix: add picker scroll functionality to (currently) unused screens

    commit 8cba034
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 11:07:34 2023 +0100

        fix: add picker scroll functionality to AdditionalDetailsStep

    commit b7ff191
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 10:57:46 2023 +0100

        add picker scroll functionality to CompanyStep

    commit 3505fd9
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 10:25:24 2023 +0100

        doc: add docs on how to handle pickers in forms

    commit 8edc865
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 10:06:48 2023 +0100

        fix: add explanation for two Form props

    commit 8172dce
    Merge: 7ba22bd 5aabd37
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Fri Jan 20 10:03:09 2023 +0100

        Merge branch 'main' into fix/scroll-to-picker-regression

    commit 7ba22bd
    Merge: 65d5e9c b197f26
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 16:48:27 2023 +0100

        Merge branch 'main' into fix/scroll-to-picker-regression

    commit 65d5e9c
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 13:02:18 2023 +0100

        fix: usage of new ref in Form

    commit fe8d4cd
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 13:00:34 2023 +0100

        fix: remove random string in Form

    commit 1cbeaa7
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 12:59:42 2023 +0100

        Use scrollContext and overflow on AddDebitCardPage

    commit 384eedb
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 12:58:51 2023 +0100

        fix: use scrollToOverflowEnabled prop from passed down props

    commit 71a415a
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 12:58:23 2023 +0100

        feat: Introduce scrollContextEnabled and scrollToOverflowEnabled props on Form component

    commit c4e8ea8
    Author: Christoph Pader <christoph@margelo.io>
    Date:   Thu Jan 19 12:02:07 2023 +0100

        fix: add missing forwardRef to ScrollViewWithContext

    commit 559df8b
    Author: Oliver Wilks <ollywilks@googlemail.com>
    Date:   Wed Jan 18 21:36:36 2023 +0000

        Changed getIOUReportActions filter order

    commit b545c93
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 17:00:26 2023 -0700

        validate if preferred locale changes

    commit e9f4cd3
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:54:01 2023 -0700

        fix toggleAllusers logic

    commit 6ec1826
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:38:05 2023 -0700

        fix logic for select all

    commit b85e275
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:28:16 2023 -0700

        keep select all checked if admin is selected

    commit 96afdf0
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:21:52 2023 -0700

        display error message

    commit 6d0ef22
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:07:02 2023 -0700

        add early return for delete modal

    commit 52dd36f
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 16:00:07 2023 -0700

        early return if errors are not empty

    commit 8cd37db
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 15:58:16 2023 -0700

        revert changes to select all checkbox

    commit 2237a6b
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 15:35:06 2023 -0700

        rm setWorkspaceMemberErrors

    commit a3a7337
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 15:32:40 2023 -0700

        fix setWorkspaceMemberErrors

    commit 689a4bc
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 15:05:57 2023 -0700

        create setWorkspaceMemberErrors

    commit d31d4be
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:47:26 2023 -0700

        rm comment and create validate

    commit b6d28d3
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:45:21 2023 -0700

        rm filter in submit function

    commit e2a9256
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:42:50 2023 -0700

        fix select all logic

    commit 5be2153
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:38:52 2023 -0700

        clean up removableMembers

    commit dcf6a1d
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 14:31:30 2023 -0700

        clean up CheckboxWithTooltip

    commit 509be3f
    Merge: be59dc3 3636f1f
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Tue Jan 17 11:32:16 2023 -0700

        Merge branch 'main' into cmartins-fixMembersPage

    commit be59dc3
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Mon Jan 16 17:23:03 2023 -0700

        rm showTooltipForLogin state

    commit d177feb
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Mon Jan 16 17:20:14 2023 -0700

        rm willTooltipShowForLogin

    commit 0f7f685
    Author: Carlos Martins <cmartins@expensify.com>
    Date:   Mon Jan 16 17:15:53 2023 -0700

        rm canBeRemoved var

    commit 742e4e7
    Author: Vit Horacek <vit@expensify.com>
    Date:   Tue Jan 17 00:36:09 2023 +0100

        Clean up

    commit a84aab4
    Author: Vit Horacek <vit@expensify.com>
    Date:   Tue Jan 17 00:33:54 2023 +0100

        Add a comment

    commit 55cbf0f
    Author: Vit Horacek <vit@expensify.com>
    Date:   Mon Jan 16 22:23:54 2023 +0100

        Build method to create closed optimistic actions

    commit 868fff6
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 17:36:47 2023 -0500

        remove another shouldShowLargeAvatars

    commit 19c9602
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 17:33:58 2023 -0500

        remove unused variable

    commit e1e86b3
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 17:32:01 2023 -0500

        center number on mobile

    commit 8407368
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 17:05:58 2023 -0500

        center number

    commit 4aee6b7
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 16:43:33 2023 -0500

        remove shouldShowLargeAvatars

    commit 679476f
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Fri Jan 13 16:36:20 2023 -0500

        remove console logs and add constant

    commit 0167179
    Author: Daniel Gale-Rosen <dgalerosen@expensify.com>
    Date:   Thu Jan 12 17:39:39 2023 -0500

        initial updates for new shared size avatars

commit 8992e46
Merge: 7a10eff ae66a7f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 23 17:55:31 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 7a10eff
Merge: c2fb8f8 e43bab5
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 22 20:22:03 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit c2fb8f8
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Jan 19 18:29:28 2023 -0500

    fixed some minor issues

commit 246073a
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Jan 19 18:10:34 2023 -0500

    Update src/components/AttachmentCarousel/CarouselActions/index.native.js

    Co-authored-by: Santhoshkumar Sellavel <85645967+Santhosh-Sellavel@users.noreply.github.com>

commit a8daa2b
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 17 23:31:40 2023 -0500

    minor fixes

commit 9efe361
Merge: 5684e41 e62a79f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 17 23:27:36 2023 -0500

    Merge branch 'main' into arrow-feature-signed

commit 5684e41
Merge: c97a7dc 8662d3d
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 14:46:23 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit c97a7dc
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 14:45:07 2023 -0500

    minor updates for comments

commit 50143fb
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 14:37:49 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit aef4993
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 14:37:14 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit cb4ed59
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jan 16 00:04:40 2023 -0500

    removed line

commit 1ce9be6
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 15 23:59:55 2023 -0500

    added comments, fixed linting

commit e7ad0d3
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 15 23:40:27 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Santhoshkumar Sellavel <85645967+Santhosh-Sellavel@users.noreply.github.com>

commit 31e389b
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 15 23:39:54 2023 -0500

    Update src/components/AttachmentCarousel/CarouselActions/index.native.js

    Co-authored-by: Santhoshkumar Sellavel <85645967+Santhosh-Sellavel@users.noreply.github.com>

commit 77eb354
Merge: d286d16 7ca2979
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Jan 14 21:52:11 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit d286d16
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Jan 14 21:48:18 2023 -0500

    fixed issue with highlight

commit 27c4f08
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Jan 14 21:29:34 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit f1e31af
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Jan 14 21:27:01 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 1c3c3f7
Merge: bc8fc1a 5a09253
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 10 22:23:23 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit bc8fc1a
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 10 22:22:21 2023 -0500

    fixed up some code per comments, added debounce to image size

commit 17fe0fc
Merge: 2f73a45 a53b274
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 8 14:43:06 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 2f73a45
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 8 13:49:02 2023 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 2199eae
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jan 8 13:44:22 2023 -0500

    Update src/components/AttachmentCarousel/CarouselActions/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 65b694a
Merge: ba8c0e9 64b9717
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Jan 4 21:45:08 2023 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit ba8c0e9
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Jan 4 21:44:49 2023 -0500

    changed prop type

commit d9d1889
Merge: d2d4e76 5af5d30
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jan 3 20:58:04 2023 -0500

    Merge branch 'main' into arrow-feature-signed

commit d2d4e76
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 29 19:28:27 2022 -0500

    used replace for config env

commit c0f4c12
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 29 19:07:14 2022 -0500

    Revert "added replace for ngrok url"

    This reverts commit 7b7a5a0.

commit 2180ca4
Merge: 3738f1f 0bde3f8
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 29 19:05:58 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 3738f1f
Merge: 7b7a5a0 276f177
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 26 19:38:09 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 7b7a5a0
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 26 15:28:37 2022 -0500

    added replace for ngrok url

commit 95069f2
Merge: c257f2c 89e3eef
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 21 18:46:21 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit c257f2c
Merge: bfa027d 5265b5b
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 20 22:41:33 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit bfa027d
Merge: 3465da8 9a52f02
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 19 18:32:54 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 3465da8
Merge: aab283f 3620bf2
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 15 18:32:12 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit aab283f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Dec 15 18:30:06 2022 -0500

    updating var names to explain their use better

commit 3965cff
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 14 18:26:41 2022 -0500

    set dimension undefined to trigger spinner when fetching dimensions

commit 9948fca
Merge: 428aaab 1a03ee3
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 14 17:01:52 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 428aaab
Merge: 704753a 11cf564
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 13 19:05:45 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 704753a
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:41:44 2022 -0500

    Update src/components/PDFView/pdfViewPropTypes.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit e042066
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:41:24 2022 -0500

    Update src/components/ImageView/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit f148909
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:40:08 2022 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 47ed2db
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:39:08 2022 -0500

    Update src/components/AttachmentCarousel/index.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit 938adda
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Dec 12 20:37:14 2022 -0500

    Update src/components/ImageView/index.native.js

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>

commit e46566d
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Dec 11 18:00:15 2022 -0500

    updating attachment download url

commit f1dfd4c
Merge: 2e56ef8 10dd188
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Dec 11 16:54:35 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit 2e56ef8
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 7 22:28:11 2022 -0500

    fixed sliding, set buttons to circles

commit 4dd29c6
Merge: a895d00 5501ff5
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Dec 7 20:27:44 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit a895d00
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 19:32:14 2022 -0500

    cleaned up some of the code in reduce

commit cdd60bc
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 19:25:35 2022 -0500

    added comment to reducer

commit c6e5b53
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 19:15:55 2022 -0500

    added comment, use full url

commit 2226040
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 17:25:55 2022 -0500

    moved auth token method into render to prevent undefined page

commit 337dbf2
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 16:27:20 2022 -0500

    fixed keyboard inputs

commit 8d05018
Merge: 70c9ac3 5869c66
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Dec 6 16:12:33 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 70c9ac3
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Dec 4 18:49:03 2022 -0500

    fixed error with sorting values, fixing styles

commit 480e550
Merge: f738465 01e7a70
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Dec 4 18:16:56 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit f738465
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Nov 19 18:36:53 2022 -0500

    cleaned up report actions, fixed issue with pagination

commit 7abd76e
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Nov 19 17:29:49 2022 -0500

    updating comment, added required to props

commit 3dd0e19
Merge: a873db7 cd83501
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Nov 19 16:53:21 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit a873db7
Merge: 6f02e04 e09d228
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 14 08:04:46 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 6f02e04
Merge: 5f49543 0de35b9
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 14 08:03:31 2022 -0500

    Merge branch 'main' into arrow-feature-signed

commit 5f49543
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 7 23:19:02 2022 -0500

    removed console, removed string replace

commit 2911b43
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 7 22:13:24 2022 -0500

    adding functionality to load more attachments as needed

commit a083df2
Merge: a7200ba 91acada
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Nov 7 20:49:00 2022 -0500

    Merge branch 'Expensify:main' into arrow-feature-signed

commit a7200ba
Merge: 05e8623 63ccac8
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Nov 2 20:36:50 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 05e8623
Merge: fad847f 03d7e8f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Oct 26 18:52:43 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit fad847f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Oct 26 18:38:42 2022 -0400

    moved and renamed some files

commit 7a7ae20
Merge: f6e6b43 70efb00
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Oct 22 23:15:00 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit f6e6b43
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Oct 22 23:14:10 2022 -0400

    removed fix for something that was fixed elsewhere

commit 962c589
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Fri Oct 21 17:44:12 2022 -0400

    fixes for comments

commit 8bbf5a7
Merge: 6b9accf b2acb8f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Fri Oct 21 10:47:07 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 6b9accf
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Oct 20 20:57:08 2022 -0400

    fixed up some mobile issues from the move

commit 799cf6c
Merge: 0cd79cc fbf0334
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Oct 19 20:09:57 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 0cd79cc
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Oct 18 21:26:07 2022 -0400

    reverted back the swipeableview, move events with web-based carousel

commit 5b303d0
Merge: 4c76f2e 555a679
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Oct 18 20:09:35 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 4c76f2e
Merge: 16531eb b299503
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Thu Sep 29 21:32:03 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 16531eb
Merge: e327533 b75faf0
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Sep 25 09:02:49 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit e327533
Merge: f1e3411 09ff150
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Sep 21 18:31:08 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit f1e3411
Merge: 468cba3 0302ce7
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Sep 19 07:53:10 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 468cba3
Merge: 594ff07 ca08fb0
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Sep 13 09:55:56 2022 -0400

    Merge branch 'Expensify:main' into arrow-feature-signed

commit 594ff07
Merge: 59e461c f95b761
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Wed Sep 7 18:43:07 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 59e461c
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Sep 5 14:05:04 2022 -0400

    set up attachment download to work

commit 19d648a
Merge: 240e1e3 11761be
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Sep 5 11:44:04 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 240e1e3
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Aug 30 19:22:53 2022 -0400

    use shap instead of object for linting

commit 9a9620e
Merge: 8aaf7fe 41ec9bd
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Aug 30 18:52:33 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 8aaf7fe
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Aug 13 19:41:04 2022 -0400

    cleaned up code, fixed some arrow showing issues

commit 91a5a05
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sat Aug 13 16:52:18 2022 -0400

    adding a native press event for pdfs

commit 191d8d7
Merge: 0366275 a06358c
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jul 31 13:34:12 2022 -0400

    Merge branch 'main' into arrow-feature-signed

commit 0366275
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Sun Jul 31 13:10:11 2022 -0400

    fixed up some issues with pdf

commit 199a8b1
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jul 26 23:22:45 2022 -0400

    Set up animation to swipe

commit 69d6a97
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jul 19 23:23:36 2022 -0400

    added resize for cycling images

commit 70d5d29
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jul 19 23:13:37 2022 -0400

    adding some logic to update the size of image when cycled

commit e2e9633
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Tue Jul 19 22:19:01 2022 -0400

    finished with swiping to change images

commit ad64a2f
Author: Robert Daly <JediWattson@users.noreply.github.com>
Date:   Mon Jul 18 21:22:03 2022 -0400

    moved everything into carousel

commit b741616
Author: Robert <JediWattson@users.noreply.github.com>
Date:   Sun Jul 17 19:45:51 2022 -0400

    setting up show arrows with ios

commit 656d0da
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sat Jul 2 13:27:56 2022 -0400

    linting fixes

commit e38f4a8
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sat Jul 2 13:19:10 2022 -0400

    set up event handlers and styling to show arrow on mouse over

commit ecd2675
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 26 17:48:36 2022 -0400

    added arrow key handler, cleaned up function and helper text

commit 5886c90
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Mon Jun 6 16:11:30 2022 -0400

    reverting changes to image updates

commit 225fbd3
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 13:38:08 2022 -0400

    removed unused state pieces

commit bf7e03e
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 13:35:38 2022 -0400

    removed styles

commit b52ee9c
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 13:25:03 2022 -0400

    cleaned up styling of buttons

commit 2e6ae8d
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 12:46:19 2022 -0400

    wrong value passed

commit 33a8e35
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 12:18:56 2022 -0400

    removed dry code

commit 0e0cdf1
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Sun Jun 5 12:14:36 2022 -0400

    use button for app default styles, added disable

commit c216164
Author: JediWattson <JediWattson@users.noreply.github.com>
Date:   Wed Jun 1 15:27:47 2022 -0400

    adding carousel to attachment modal
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.59-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

namhihi237
namhihi237 reviewed Oct 8, 2023
View reviewed changes
src/libs/ReportUtils.js
automatic: false,
avatar: lodashGet(allPersonalDetails, [currentUserEmail, 'avatar'], getDefaultAvatar(currentUserEmail)),
clientID: NumberUtils.generateReportActionClientID(),
created: DateUtils.getDBTime(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mountiny Can you explain why we need to use created here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as any report action, this indicated when the action took place, ie when the chat was archived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhihi237 namhihi237 namhihi237 left review comments

@rushatgabhane rushatgabhane rushatgabhane approved these changes

@nkuoch nkuoch nkuoch approved these changes

Assignees

@mountiny mountiny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mountiny @nkuoch @rushatgabhane @OSBotify @namhihi237