Translate IOU buttons #14344

luacmartins · 2023-01-16T23:42:21Z

Details

Makes sure that the IOU confirmation button is always translated to the selected language

Fixed Issues

$ #14305

Tests

Open the App in 2 sessions logged in to the same account
In session A, navigate to + > Send money > Enter Amount > Select participant`
Note the text of the confirmation button
In session B, navigate to Settings > Preferences and change the selected language
In session A, verify that the confirmation button was translated accordingly
In session A, select a different option in the dropdown button and repeat steps 4-5
Repeat steps 2-6 for the following pages:

+ > Request money > Enter amount > Select participant
+ > Split bill > Enter amount > Select participants
Select an open IOU where you owe money
Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-01-16T23:49:50Z

@Santhosh-Sellavel @youssef-lr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-01-17T20:46:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-01-18.at.2.08.12.AM.mov

Desktop

Screen.Recording.2023-01-18.at.2.10.06.AM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-01-18.at.2.14.03.AM.mov

iOS & Android

Screen.Recording.2023-01-18.at.3.13.26.AM.mov

Santhosh-Sellavel · 2023-01-17T21:59:18Z

src/components/IOUConfirmationList.js

+     * Get the confirmation button options
+     * @returns {Array}
+     */
+    getSplitOrRequestOptions() {


Shouldn't we bind to this?

From our guidelines:

For class components, methods should be bound in the constructor() if passed directly as a prop or needing to be accessed via the component instance from outside of the component's execution context. Binding all methods in the constructor is unnecessary. Learn and understand how this works here.

We are calling the method and passing its return value to the child component, not the method itself. We also don't access it in the child component. So I don't think we need to bind it.

Thanks for the clarification, looks good!

Santhosh-Sellavel

LGTM tests well!

Santhosh-Sellavel · 2023-01-19T16:11:35Z

bump @youssef-lr

youssef-lr

LGTM and tested well!

OSBotify · 2023-01-20T13:01:36Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.2.57-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-01-23T18:08:35Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.57-3 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins added 5 commits January 16, 2023 16:21

use state index

67a0555

create getSplitOrRequestOptions

09a728c

add componentDidUpdate

4d32e57

rm componentDidUpdate

e4bba82

add js docs

c2732be

luacmartins self-assigned this Jan 16, 2023

luacmartins marked this pull request as ready for review January 16, 2023 23:49

luacmartins requested a review from a team as a code owner January 16, 2023 23:49

melvin-bot bot requested review from Santhosh-Sellavel and youssef-lr and removed request for a team January 16, 2023 23:49

Merge branch 'main' into cmartins-translateSendMoneyButton

3b7d72a

Santhosh-Sellavel reviewed Jan 17, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Jan 18, 2023

View reviewed changes

youssef-lr approved these changes Jan 20, 2023

View reviewed changes

youssef-lr merged commit f586e02 into main Jan 20, 2023

youssef-lr deleted the cmartins-translateSendMoneyButton branch January 20, 2023 11:40

OSBotify mentioned this pull request Jan 20, 2023

Deploy Checklist: New Expensify 2023-01-19 #14423

Closed

21 tasks

luacmartins mentioned this pull request Jan 20, 2023

[HOLD for payment 2023-02-10] Request -The selected participant is highlighted when the profile's language is changed #14441

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Translate IOU buttons #14344

Translate IOU buttons #14344

luacmartins commented Jan 16, 2023 •

edited

Loading

melvin-bot bot commented Jan 16, 2023

Santhosh-Sellavel commented Jan 17, 2023 •

edited

Loading

Santhosh-Sellavel Jan 17, 2023

luacmartins Jan 18, 2023 •

edited

Loading

Santhosh-Sellavel Jan 18, 2023

Santhosh-Sellavel left a comment

Santhosh-Sellavel commented Jan 19, 2023

youssef-lr left a comment

OSBotify commented Jan 20, 2023

OSBotify commented Jan 23, 2023

Translate IOU buttons #14344

Translate IOU buttons #14344

Conversation

luacmartins commented Jan 16, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 16, 2023

Santhosh-Sellavel commented Jan 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel Jan 17, 2023

Choose a reason for hiding this comment

luacmartins Jan 18, 2023 • edited Loading

Choose a reason for hiding this comment

Santhosh-Sellavel Jan 18, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Jan 19, 2023

youssef-lr left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 20, 2023

OSBotify commented Jan 23, 2023

luacmartins commented Jan 16, 2023 •

edited

Loading

Santhosh-Sellavel commented Jan 17, 2023 •

edited

Loading

luacmartins Jan 18, 2023 •

edited

Loading