-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track Push Notification Opt-In Status #14579
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
2b5d385
Install react-native-device-info
roryabraham b6e2b21
Upgrade urbanairship-react-native
roryabraham 4fc6f26
Add mock for react-native-device-info
roryabraham efc4490
Update urbanairship-react-native mock
roryabraham 599be59
Update CustomNotificationProvider
roryabraham cce0558
Make PushNotification lib have same exports on web and native
roryabraham 51116a7
Create User actions to opt in and out of push notifications
roryabraham e158dbd
Fix ternary
roryabraham 6ddd67c
Use only one user action instead of two
roryabraham 735e5a9
Hook up listeners in the PushNotification library to track push notif…
roryabraham 7e0a54a
Fix JS style
roryabraham fa2fe5e
Fix Onyx.connect callback to handle updated NVP shape
roryabraham 72fea38
Merge branch 'main' into Rory-PushNotificationOptInStatus
roryabraham 8941f11
Fix Onyx.connect to be keyed by deviceID
roryabraham 01048e3
Consolidate Onyx connection into PushNotification lib
roryabraham 6f89dc0
Fix require cycle
roryabraham 29f15e0
Use Google Play-compliant deviceID alternative
roryabraham 973b551
Move Device to its own action
roryabraham 1513b20
Fix require cycle by moving push notification tracking to separate mo…
roryabraham ac8badf
Fix permission tracker export
roryabraham 3b13de7
Fix require cycle by moving setPushNotificationOptInStatus out of User
roryabraham 6a7c215
Remove awkward newline
roryabraham 6621f1e
Clarify comment
roryabraham 4f2ca7b
Simplify Onyx data to a boolean
roryabraham 77f029d
Fix use of PermissionsTracker
roryabraham fb853a3
Remove permissionTracker entirely
roryabraham 1470b01
Improve device comment again
roryabraham 1924a4b
Add static deviceID for the desktop app
roryabraham ae22dee
Separate out Android and web deviceID implementations
roryabraham 7287f42
Improve comment on invoke
roryabraham 4baf080
Improve comment in generateDeviceID/index.android.js
roryabraham 137740d
Fix ReportTest
roryabraham d9d8999
Rename index.js to index.website.js
roryabraham 412e6c3
Fix expensify-common import
roryabraham 9bc0558
Fix NetworkTest
roryabraham 050f700
Merge branch main into Rory-PushNotificationOptInStatus
roryabraham 0b6b425
Remove super bizzare unnecessary import
roryabraham ba8728f
Remove context
roryabraham db124ad
Clarify comments around PUSH_NOTIFICATIONS_ENABLED
roryabraham 8fe9141
Remove server-side assumption from comment
roryabraham 99d799d
Merge branch 'main' into Rory-PushNotificationOptInStatus
roryabraham 5af1d26
Merge branch 'main' into Rory-PushNotificationOptInStatus
roryabraham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import MockDeviceInfo from 'react-native-device-info/jest/react-native-device-info-mock'; | ||
|
||
export default MockDeviceInfo; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,14 @@ | ||
const ELECTRON_EVENTS = { | ||
BLUR: 'blur', | ||
FOCUS: 'focus', | ||
LOCALE_UPDATED: 'locale-updated', | ||
REQUEST_DEVICE_ID: 'requestDeviceID', | ||
REQUEST_FOCUS_APP: 'requestFocusApp', | ||
REQUEST_UPDATE_BADGE_COUNT: 'requestUpdateBadgeCount', | ||
REQUEST_VISIBILITY: 'requestVisibility', | ||
REQUEST_FOCUS_APP: 'requestFocusApp', | ||
SHOW_KEYBOARD_SHORTCUTS_MODAL: 'show-keyboard-shortcuts-modal', | ||
START_UPDATE: 'start-update', | ||
UPDATE_DOWNLOADED: 'update-downloaded', | ||
FOCUS: 'focus', | ||
BLUR: 'blur', | ||
LOCALE_UPDATED: 'locale-updated', | ||
}; | ||
|
||
module.exports = ELECTRON_EVENTS; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
REQUEST_DEVICE_ID
is the new one, I just alphabetized this object.