Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #14592

Merged
merged 7 commits into from
Jan 27, 2023
Merged

Update CONTRIBUTING.md #14592

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c79df43
Update CONTRIBUTING.md
dylanexpensify Jan 26, 2023
eac770a
Update contributingGuides/CONTRIBUTING.md
dylanexpensify Jan 27, 2023
1e90ed4
Update contributingGuides/CONTRIBUTING.md
dylanexpensify Jan 27, 2023
3dc33a2
Update CONTRIBUTING.md
dylanexpensify Jan 27, 2023
b60cea8
Update contributingGuides/CONTRIBUTING.md
dylanexpensify Jan 27, 2023
9505a95
Update contributingGuides/CONTRIBUTING.md
dylanexpensify Jan 27, 2023
82ed2fb
Update contributingGuides/CONTRIBUTING.md
dylanexpensify Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions contributingGuides/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,15 @@ Additionally if you want to discuss an idea with the open source community witho
15. Upon submission of a PR, please include a numbered list of explicit testing steps for each platform (Web, Desktop, iOS, Android, and Mobile Web) to confirm the fix works as expected and there are no regressions.
16. Please add a screenshot of the app running on each platform (Web, Desktop, iOS, Android, Mobile Web).

#### Completing the final checklist
17. Once your PR has been deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued.
18. The items requiring your completion consist of:
1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head [here](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md)).
2. Identifying and noting the offending PR that caused the bug (if any).
3. Commenting on the offending PR to note the bug it caused and why (if applicable).
4. Starting a conversation on if any additional steps should be taken to prevent further bugs similar to the one fixed from occurring again.
20. Once the above items have been successfully completed, then payments will begin to be issued.

#### Timeline expectations and asking for help along the way
- If you have made a change to your pull request and are ready for another review, leave a comment that says "Updated" on the pull request itself.
- Please keep the conversation in GitHub, and do not ping individual reviewers in Slack or Upwork to get their attention.
Expand Down