Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #14921 to staging 🍒 #14928

Merged
merged 2 commits into from
Feb 7, 2023
Merged

🍒 Cherry pick PR #14921 to staging 🍒 #14928

merged 2 commits into from
Feb 7, 2023

Conversation

OSBotify
Copy link
Contributor

@OSBotify OSBotify commented Feb 7, 2023

🍒 Cherry pick #14921 to staging 🍒

OSBotify and others added 2 commits February 7, 2023 21:49
@OSBotify
Merge pull request #14927 from Expensify/version-BUILD-F8546E38-CB1D-…
90ee142 
…47FD-84EB-9EC601FC86D3

Update version to 1.2.67-5 on main

(cherry picked from commit ea3a876)
@aldo-expensify @OSBotify
Merge pull request #14921 from Expensify/hayata-fixAddressFieldDefaul…
42cde06 
…tMaxInputLength

change maxInputLength default value to undefined from -1

(cherry picked from commit 017cde6)
@OSBotify OSBotify requested a review from a team as a code owner February 7, 2023 21:49
@melvin-bot melvin-bot bot removed request for a team February 7, 2023 21:49
@MelvinBot
Copy link

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@OSBotify OSBotify merged commit 99d0a53 into staging Feb 7, 2023
@OSBotify OSBotify deleted the OSBotify-cherry-pick-staging-14921 branch February 7, 2023 21:49
@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 7, 2023

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.2.67-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 8, 2023

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.67-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OSBotify @MelvinBot @aldo-expensify