composer set correct numberOfLines on intitial render #15296

Pujan92 · 2023-02-20T14:02:08Z

Details

Update numberOfLines when first time the Composer TextInput renders on the screen and the initial numberOfLines is 0

Fixed Issues

$ #15024
PROPOSAL: #15024 (comment)

Tests

Open an invalid route(eg. /anything) (Need to test on browser with larger screen)
On NotFound page click on close
Verify the Composer input not gets distorted

Verify that no errors appear in the JS console

Offline tests

Open an invalid route(eg. /anything) (Need to test on browser with larger screen)
On NotFound page click on close
Verify the Composer input not gets distorted

QA Steps

Open an invalid route(eg. /anything) (Need to test on browser with larger screen)
On NotFound page click on close
Verify the Composer input not gets distorted

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-02-20.at.6.58.44.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

MelvinBot · 2023-02-20T14:02:15Z

@marcochavezf @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thesahindia · 2023-02-20T19:55:59Z

src/components/Composer/index.js

@@ -356,6 +366,7 @@ class Composer extends React.Component {
                selection={this.state.selection}
                onChange={this.shouldCallUpdateNumberOfLines}
                onSelectionChange={this.onSelectionChange}
+                onLayout={() => this.updateNumberOfLinesOnLayoutChange()}


Let's bind updateNumberOfLinesOnLayoutChange in constructor

Suggested change

onLayout={() => this.updateNumberOfLinesOnLayoutChange()}

onLayout={this.updateNumberOfLinesOnLayoutChange}

thesahindia · 2023-02-20T20:18:32Z

Hey @marcochavezf just wanna know if the final result looks fine. The composer shakes a little when repro this issue with some different steps (forgot to confirm earlier)

Steps I taken :-

Navigate to settings
Press ⬅️ button
Press ➡️ button

Screen.Recording.2023-02-21.at.1.30.31.AM.mov

The video of the final result after following the steps listed in the OP

Screen.Recording.2023-02-21.at.1.31.35.AM.mov

marcochavezf · 2023-02-20T22:23:32Z

Oh interesting, it looks like a bug, do we know why the composer shakes? Is that still happening after applying the solution?

thesahindia · 2023-02-21T11:45:12Z

Is that still happening after applying the solution?

Copy pasting @Pujan92's comment here -

On invalid route we are showing the 404(Hmm... it's not here) page but ReportScreen & ReportFooter gets mounted in the back and due to that TextArea scrollHeight 0 will be passed here.

App/src/components/Composer/index.js

Line 336 in 8f75438

const numberOfLines = getNumberOfLines(this.props.maxLines, lineHeight, paddingTopAndBottom, this.textInput.scrollHeight);

This leades to calculate numberOfLines to 0 and setting that will be overwritten by the browser textArea with the default rows which is 2.

The root cause is same as above when we follow the steps I provided. The composer moves a little because we are updating the numberOfLines at onLayout the height change is visible. I am not sure if there is another way to fix this. I think it's fine because the height change is only visible when we follow the steps mentioned in this comment and it's unlikely that a user will follow those steps thoughts @marcochavezf ?

Pujan92 · 2023-02-21T17:20:05Z

@thesahindia with your provided scenario I am seeing the rows issue after I did the latest commit with function bind, in the last(Press ➡️ button) step it seems the scrollHeight becoming the 0. Didn't able to find the root cause for it yet but might be calculation gets executed when it still needs to render on the screen(as in the last step ReportScreen gets rerendered).

thesahindia · 2023-02-21T20:06:47Z

src/components/Composer/index.js

@@ -128,6 +128,7 @@ class Composer extends React.Component {
        this.handleWheel = this.handleWheel.bind(this);
        this.putSelectionInClipboard = this.putSelectionInClipboard.bind(this);
        this.shouldCallUpdateNumberOfLines = this.shouldCallUpdateNumberOfLines.bind(this);
+        this.updateNumberOfLinesOnLayoutChange = this.updateNumberOfLinesOnLayoutChange(this);


Suggested change

this.updateNumberOfLinesOnLayoutChange = this.updateNumberOfLinesOnLayoutChange(this);

this.updateNumberOfLinesOnLayoutChange = this.updateNumberOfLinesOnLayoutChange.bind(this);

Oh, how I forgot it. It is working now @thesahindia , updated.

thesahindia · 2023-02-21T20:10:40Z

@thesahindia with your provided scenario I am seeing the rows issue after I did the latest commit with function bind

@Pujan92, you didn't bind the function correctly. I have suggested the change here

thesahindia · 2023-02-22T13:54:02Z

@marcochavezf, any thoughts on #15296 (comment)?

marcochavezf · 2023-02-22T17:29:38Z

Yeah, since the scrollHeight will be 0 because the element is not mounted yet, I think we can always return at least 1 for the numberOfLines here:

- const numberOfLines = getNumberOfLines(this.props.maxLines, lineHeight, paddingTopAndBottom, this.textInput.scrollHeight);
+ const numberOfLines = Math.max(getNumberOfLines(this.props.maxLines, lineHeight, paddingTopAndBottom, this.textInput.scrollHeight), 1);

And with that, we won't require the function shouldCallUpdateNumberOfLines.

@Pujan92 could you please try that approach?

thesahindia · 2023-02-22T18:00:08Z

@marcochavezf, there is a problem with that solution. Even when composer has multiline text we will be changing the numberOfLines to 1

Screen.Recording.2023-02-22.at.11.18.43.PM.mov

marcochavezf · 2023-02-23T22:36:36Z

@marcochavezf, there is a problem with that solution. Even when composer has multiline text we will be changing the numberOfLines to 1

Oh interesting, what if we use the last numberOfLines as the min value (instead of 1)?

Pujan92 · 2023-02-24T05:07:00Z

Oh interesting, what if we use the last numberOfLines as the min value (instead of 1)?

@marcochavezf that also won't work as this happens for the renders and the rerenders and due to scrollHeight 0 first and last numberOfLines might be 0.

thesahindia · 2023-03-01T10:14:07Z

@marcochavezf, thoughts^?

marcochavezf · 2023-03-01T16:58:57Z

that also won't work as this happens for the renders and the rerenders and due to scrollHeight 0 first and last numberOfLines might be 0.

Ah I mean if the text is persisted somehow here between renders I think we can also persist the numberOfLines somewhere to then use it as a min value.

thesahindia · 2023-03-02T04:27:20Z

I think we can also persist the numberOfLines somewhere to then use it as a min value.

Makes sense!

cc: @Pujan92

Pujan92 · 2023-03-02T12:30:11Z

@marcochavezf @thesahindia We are persisting numberOfLines in the state here, but I think as we are operating through the browser buttons for this scenario the component gets re-instantiated which reset the state and makes the numberOfLines back to 1.

thesahindia · 2023-03-02T12:58:53Z

I think we can also persist the numberOfLines somewhere to then use it as a min value.

@Pujan92, we are saving the draft message locally. Can you try doing the same for numberOfLines and try using it to solve the issue?

Pujan92 · 2023-03-02T16:46:21Z

I think we can also persist the numberOfLines somewhere to then use it as a min value.

@Pujan92, we are saving the draft message locally. Can you try doing the same for numberOfLines and try using it to solve the issue?

@thesahindia Same will be happens to edit message also, won't it increase the keys tremendously in Onyx if we consider every edit comments too?

Screen.Recording.2023-03-02.at.10.05.03.PM.mov

I tried for report composer with REPORT_DRAFT_COMMENT_NUMBER_OF_LINES: 'reportDraftCommentNumberOfLines_' and it seems to be working. Can we think of separate PR for this where we are saving the lines in the local and passing as a prop?

thesahindia · 2023-03-02T18:18:10Z

@thesahindia Same will be happens to edit message also, won't it increase the keys tremendously in Onyx if we consider every edit comments too?

I think that's fine?

Can we think of separate PR for this where we are saving the lines in the local and passing as a prop?

We are thinking to store numberOfLines at ONYX to fix the current issue in a more better way so I think it needs to be done in this PR. It's not out of scope.

cc: @marcochavezf

thesahindia · 2023-03-07T18:24:41Z

Sorry for the delay (had to go out)

@Pujan92, it looks like changing initWithStoredValues to false will cause an issue.

Screen.Recording.2023-03-07.at.11.46.29.PM.mov

marcochavezf · 2023-03-08T18:01:26Z

it looks like changing initWithStoredValues to false will cause an issue.

I think using the initWithStoredValues: false is fine for this case. To solve the issue with the other input, I think we can create another Onyx key for the edited input, something like REPORT_DRAFT_EDIT_COMMENT_NUMBER_OF_LINES

Pujan92 · 2023-03-08T18:16:11Z

It seems initWithStoredValues: false won't work here(for invalid route case) bcoz it will not give the onyx value initially and due to that for an invalid route in the backside we are mounting the Report which will set the numberOfLines 1(default) for this edit input.
@marcochavezf we do have a different pattern for the edited input onyx key so I think another key won't be the solution for it.

Pujan92 · 2023-03-08T18:58:20Z

I don't know how to proceed now as I am seeing only an option to delay the focus of the input now, the delay is due to the numberOfLines fetching from onyx to render the composer.

thesahindia · 2023-03-09T14:41:44Z

I don't know how to proceed now as I am seeing only an option to delay the focus of the input now, the delay is due to the numberOfLines fetching from onyx to render the composer.

I would prefer not using the delay if we can but not sure what else we can do here.

thesahindia · 2023-03-09T14:42:14Z

@marcochavezf, do you have any other ideas?

marcochavezf · 2023-03-09T22:52:13Z

Yeah, given that the issue here is an extreme edge case, we should proceed with the best solution so far 👍🏽

thesahindia · 2023-03-13T17:42:13Z

Yeah, given that the issue #15296 (comment) is an extreme edge case, we should proceed with the best solution so far 👍🏽

@marcochavezf, I don't feel good leaving this bug for edit composer while we are fixing the same bug for the main composer. I think we should fix it. Maybe we should open a new issue for edit composer or maybe we should just move to the original solution where we had this minor issue -

Hey @marcochavezf just wanna know if the final result looks fine. The composer shakes a little when repro this issue with some different steps (forgot to confirm earlier)

Steps I taken :-

Navigate to settings

Press ⬅️ button

Press ➡️ button

Screen.Recording.2023-02-21.at.1.30.31.AM.mov

thesahindia · 2023-03-13T17:42:47Z

@Pujan92, please resolve the conflicts.

Pujan92 · 2023-03-14T17:08:08Z

@Pujan92, please resolve the conflicts.

@thesahindia resolved.

thesahindia · 2023-03-14T19:15:11Z

Waiting for @marcochavezf thoughts on #15296 (comment) before proceeding with the testing/review.

marcochavezf · 2023-03-16T21:04:57Z

@marcochavezf, I don't feel good leaving this bug for edit composer while we are fixing the same bug for the main composer. I think we should fix it. Maybe we should open a new #15296 (comment) for edit composer or maybe we should just move to the original solution where we had this minor issue -

Hi @thesahindia, yeah I agree that we should fix all bugs completely, but given that this was an edge case presented during the PR I think the current solution is ok to continue forward.

Regarding the solution, I think the solution in this video is better than this one, since from a user perspective the jump looks a bit weirdest than having an edit composer presented in one line (which I think that's not super bad), also seems that @Pujan92 already coded the solution for the jump animation in this PR, no?

Pujan92 · 2023-03-17T09:05:10Z

since from a user perspective the jump looks a bit weirdest than having an edit composer presented in one line (which I think that's not super bad), also seems that @Pujan92 already coded the solution for the jump animation in this PR, no?

Yes, as we are maintaining the numberOfLines within onyx in this PR, that shake issue of the report composer gets resolved for back and forth scenraio.

thesahindia · 2023-03-21T10:12:17Z

src/pages/home/report/ReportActionCompose.js

@@ -823,6 +835,8 @@ class ReportActionCompose extends React.Component {
                                            setIsFullComposerAvailable={this.setIsFullComposerAvailable}
                                            isComposerFullSize={this.props.isComposerFullSize}
                                            value={this.state.value}
+                                            numberOfLines={this.props.numberOfLines}
+                                            onNumberOfLinesChange={numberOfLines => this.updateNumberOfLines(numberOfLines)}


Let's bind updateNumberOfLines

thesahindia · 2023-03-21T10:13:11Z

src/pages/home/report/ReportActionItemMessageEdit.js

@@ -273,6 +287,8 @@ class ReportActionItemMessageEdit extends React.Component {
                        }}
                        selection={this.state.selection}
                        onSelectionChange={this.onSelectionChange}
+                        numberOfLines={this.props.numberOfLines}
+                        onNumberOfLinesChange={numberOfLines => this.updateNumberOfLines(numberOfLines)}


thesahindia · 2023-03-21T11:21:23Z

src/components/Composer/index.js

@@ -334,11 +343,13 @@ class Composer extends React.Component {
            const lineHeight = parseInt(computedStyle.lineHeight, 10) || 20;
            const paddingTopAndBottom = parseInt(computedStyle.paddingBottom, 10)
            + parseInt(computedStyle.paddingTop, 10);
-            const numberOfLines = getNumberOfLines(this.props.maxLines, lineHeight, paddingTopAndBottom, this.textInput.scrollHeight);
+            const computedNumberOfLines = getNumberOfLines(this.props.maxLines, lineHeight, paddingTopAndBottom, this.textInput.scrollHeight);
+            const numberOfLines = computedNumberOfLines === 0 ? Math.max(this.props.numberOfLines, 1) : computedNumberOfLines;


I think we don't need Math.max

thesahindia · 2023-03-21T11:21:35Z

src/components/Composer/index.js

@@ -116,7 +124,7 @@ class Composer extends React.Component {
            : `${props.value || ''}`;

        this.state = {
-            numberOfLines: 1,
+            numberOfLines: props.numberOfLines || 1,


I believe only using props.numberOfLines will do the job? We are already using 1 for numberOfLines in default props.

Yes, thanks.

thesahindia · 2023-03-23T20:45:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-03-24.at.1.25.59.AM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thesahindia

Looks good to me!

cc: @marcochavezf

marcochavezf

LGTM, thanks guys!

OSBotify · 2023-03-27T11:34:14Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.2.90-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-28T17:19:58Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.90-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-04-26T10:17:01Z

This PR caused a regression #16931. The use of withOnyx on numberOfLines lead to a partially synced ReportActionItemMessageEdit this caused bugs when the component is rendered by two tabs. We should have synced both numberOfLines and draftMessage or none.

Pujan92 requested a review from a team as a code owner February 20, 2023 14:02

melvin-bot bot requested review from marcochavezf and thesahindia and removed request for a team February 20, 2023 14:02

Pujan92 mentioned this pull request Feb 20, 2023

[HOLD for payment 2023-04-04] [$1000] Compose box gets distorted when going to invalid url #15024

Closed

1 task

thesahindia reviewed Feb 20, 2023

View reviewed changes

Pujan92 force-pushed the fix/compose-box-onlayout-fix-15024 branch from 0040b2a to 8442a94 Compare February 21, 2023 13:43

thesahindia reviewed Feb 21, 2023

View reviewed changes

Pujan92 requested review from thesahindia and removed request for marcochavezf February 21, 2023 23:16

marcochavezf self-requested a review February 22, 2023 16:53

Pujan92 force-pushed the fix/compose-box-onlayout-fix-15024 branch from 1358dfd to 7949302 Compare March 3, 2023 12:09

Merge branch 'main' into fix/compose-box-onlayout-fix-15024

8a3371a

Merge branch 'main' into fix/compose-box-onlayout-fix-15024

56eec55

thesahindia suggested changes Mar 21, 2023

View reviewed changes

Pujan92 added 2 commits March 22, 2023 11:14

Merge branch 'main' into fix/compose-box-onlayout-fix-15024

610bc2c

bind methods and minor changes

6caefe4

thesahindia approved these changes Mar 23, 2023

View reviewed changes

marcochavezf approved these changes Mar 27, 2023

View reviewed changes

marcochavezf merged commit 773e0dd into Expensify:main Mar 27, 2023

OSBotify mentioned this pull request Mar 27, 2023

Deploy Checklist: New Expensify 2023-03-27 #16536

Closed

18 tasks

kbecciv mentioned this pull request Mar 27, 2023

mWeb/Chrome - Chat - By pressing x mark, user landed to LHN instead of chat conversation #16561

Closed

6 tasks

esh-g mentioned this pull request Mar 28, 2023

Skin tone fix #16604

Merged

53 tasks

s77rt mentioned this pull request Apr 19, 2023

[HOLD for payment 2023-05-03] [$1000] Screen is shaking when scrolling while user edit a comment between 2 tabs. #16931

Closed

6 tasks

aldo-expensify mentioned this pull request Apr 25, 2023

Fix screen shaking when editing between 2 tabs #17899

Merged

56 tasks

	onLayout={() => this.updateNumberOfLinesOnLayoutChange()}
	onLayout={this.updateNumberOfLinesOnLayoutChange}

	this.updateNumberOfLinesOnLayoutChange = this.updateNumberOfLinesOnLayoutChange(this);
	this.updateNumberOfLinesOnLayoutChange = this.updateNumberOfLinesOnLayoutChange.bind(this);

composer set correct numberOfLines on intitial render #15296

composer set correct numberOfLines on intitial render #15296

Conversation

Pujan92 commented Feb 20, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Feb 20, 2023

Choose a reason for hiding this comment

thesahindia commented Feb 20, 2023

marcochavezf commented Feb 20, 2023

thesahindia commented Feb 21, 2023

Pujan92 commented Feb 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thesahindia commented Feb 21, 2023

thesahindia commented Feb 22, 2023

marcochavezf commented Feb 22, 2023 • edited Loading

thesahindia commented Feb 22, 2023

marcochavezf commented Feb 23, 2023 • edited Loading

Pujan92 commented Feb 24, 2023

thesahindia commented Mar 1, 2023

marcochavezf commented Mar 1, 2023

thesahindia commented Mar 2, 2023

Pujan92 commented Mar 2, 2023

thesahindia commented Mar 2, 2023

Pujan92 commented Mar 2, 2023 • edited Loading

thesahindia commented Mar 2, 2023

thesahindia commented Mar 7, 2023

marcochavezf commented Mar 8, 2023

Pujan92 commented Mar 8, 2023 • edited Loading

Pujan92 commented Mar 8, 2023

thesahindia commented Mar 9, 2023

thesahindia commented Mar 9, 2023

marcochavezf commented Mar 9, 2023

thesahindia commented Mar 13, 2023

thesahindia commented Mar 13, 2023

Pujan92 commented Mar 14, 2023

thesahindia commented Mar 14, 2023

marcochavezf commented Mar 16, 2023

Pujan92 commented Mar 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thesahindia commented Mar 23, 2023

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 27, 2023

OSBotify commented Mar 28, 2023

s77rt commented Apr 26, 2023

marcochavezf commented Feb 22, 2023 •

edited

Loading

marcochavezf commented Feb 23, 2023 •

edited

Loading

Pujan92 commented Mar 2, 2023 •

edited

Loading

Pujan92 commented Mar 8, 2023 •

edited

Loading