-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] Resolve Android build OOM error by increasing JVM memory allowance #15404
Conversation
This comment was marked as spam.
This comment was marked as spam.
Reviewer Checklist
Screenshots/VideosNo screenshots required here WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LEts try this
🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.76-3 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.76-7 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.76-7 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.76-7 🚀
|
CC @chiragsalian
Details
Our distributed Android compilation actions are often failing due to an OOM issue. This also happens on our older local machines. This PR increases the JVM memory allowance in an attempt to resolve the problem.
Fixed Issues
$ #15371
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Only Android is relevant.