Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Personal Bank Account Onyx keys in componentWillUnmount #15679

Merged
merged 8 commits into from
Mar 21, 2023
Merged

Clear Personal Bank Account Onyx keys in componentWillUnmount #15679

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9252eb1
Fix prop type to avoid console warning
MariaHCD Mar 6, 2023
8403db1
Return early if we already have a selected Plaid accountID
MariaHCD Mar 6, 2023
8644ad6
Revert change to prop type
MariaHCD Mar 6, 2023
347a4f9
Merge remote-tracking branch 'origin/main' into maria-fix-plaid-retri…
MariaHCD Mar 6, 2023
eb6027d
Merge remote-tracking branch 'origin/main' into maria-fix-plaid-retri…
MariaHCD Mar 16, 2023
c3bdfe7
Revert redundant check
MariaHCD Mar 16, 2023
06a333f
Clear personal bank account Onyx keys before unmount
MariaHCD Mar 17, 2023
b38bd78
Merge remote-tracking branch 'origin/main' into maria-fix-plaid-retri…
MariaHCD Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/pages/AddPersonalBankAccountPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class AddPersonalBankAccountPage extends React.Component {
};
}

componentDidMount() {
componentWillUnmount() {
BankAccounts.clearPersonalBankAccount();
}

Expand Down Expand Up @@ -99,7 +99,6 @@ class AddPersonalBankAccountPage extends React.Component {
shouldShowButton
buttonText={this.props.translate('common.continue')}
onButtonPress={() => {
BankAccounts.clearPersonalBankAccount();
Navigation.navigate(ROUTES.SETTINGS_PAYMENTS);
}}
/>
Expand Down