Detailed list of reaction senders when long-/right-pressing a reaction #15685

perunt · 2023-03-06T16:18:56Z

Details

Fixed Issues

$ #15128
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Mobile:

Add a reaction to a message
Tap and hold the reaction bubble.
Verify that a modal appears with a list of users.
Check that the background of the emoji in the modal indicates whether or not you have already picked that emoji.

WEB:

Add a reaction to a message.
Right-clicking on the reaction bubble.
Verify that a tooltip appears with a list of users.
Check that the background of the emoji in the tooltip indicates whether or not you have already picked that emoji.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mar-07-2023.14-28-00.mp4

Mobile Web - Chrome

Mar-07-2023.14-24-49.mp4

Mobile Web - Safari

Mar-07-2023.14-26-38.mp4

Desktop

iOS

Mar-07-2023.14-17-53.mp4

Android

Mar-07-2023.14-21-05.mp4

MelvinBot · 2023-03-07T12:52:29Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/home/report/ReactionList/PopoverReactionList.js

stitesExpensify · 2023-03-08T16:26:56Z

@perunt can you pull main now that the emoji reaction PR is merged?

…into perunt/reaction-list-on-secondary-interaction

perunt · 2023-03-08T19:51:49Z

@stitesExpensify updated
However, it is important to note that this PR was created using methods primarily from this one It should be reviewed and considered in conjunction with this PR

stitesExpensify · 2023-03-08T19:53:29Z

Yep, got it! I'll probably wait to fully review this one until that PR is merged (probably tomorrow) since i've already requested changes on it

…com/margelo/expensify-app-fork into perunt/reaction-list-on-secondary-interaction

stitesExpensify · 2023-03-14T21:35:52Z

@perunt can you please pull main and fix the conflicts for the duplicated changes so that we know what really needs to be reviewed 😄

…into perunt/reaction-list-on-secondary-interaction

…eaction-list-on-secondary-interaction

src/components/Reactions/ReportActionItemReactions.js

src/pages/home/report/ReactionList/BaseReactionList.js

src/pages/home/report/ReactionList/HeaderReactionList/index.js

src/pages/home/report/ReactionList/HeaderReactionList/index.native.js

src/pages/home/report/ReactionList/PopoverReactionList.js

parasharrajat · 2023-05-02T06:44:39Z

src/pages/home/report/ReactionList/BaseReactionList.js

@@ -45,6 +45,7 @@ const renderItem = ({item}) => (
    <OptionRow
        item={item}
        boldStyle
+        isDisabled


This also makes the text on the item unselectable. Is it fine? @Julesssss and others.

Good spot. I think that's okay given that there are other ways for web/Desktop users to copy this text.

perunt · 2023-05-02T09:43:16Z

We use standard vibro as a way to interact with things after a long press. When it comes to pressing an emoji for a reaction or a long press, nothing's changed. But just to be clear:

If we tap an emoji we haven't reacted to yet, the background changes.
Nothing visual happens if we've already reacted to an emoji and tap it again.
This applies to long presses too.

So, here's a question: should the background change when we tap an emoji to undo our reaction, or should it only happen for a long press?
Long presses usually only have vibro interaction, so we must consider it.

parasharrajat · 2023-05-02T10:34:09Z

@grgia can you please help us decide the visual effect #15685 (comment)?

grgia · 2023-05-02T15:45:14Z

@perunt @parasharrajat looking into the visual effect question

perunt · 2023-05-03T12:14:20Z

@grgia so, what's the verdict? 😃

grgia · 2023-05-03T12:28:28Z

Hey! Sorry for the delay, @shawnborton and I talked about this recently and we determined there doesn't need to be a visual color change for your own (blue) reactions

perunt · 2023-05-03T12:48:27Z

@parasharrajat looks like it's good to go

parasharrajat · 2023-05-03T14:57:59Z

Thanks for the update. I will do the final testing in sometime. Everything looks good so far.

parasharrajat · 2023-05-03T14:58:11Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-05-03.at.10.20.44.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-05-03.at.10.24.36.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-05-03.at.10.30.10.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-05-03.at.10.27.18.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-05-03.at.10.28.38.PM.mov

🔲 Android / native

Screen.Recording.2023-05-03.at.10.36.12.PM.mov

src/pages/home/report/ReactionList/BaseReactionList.js

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc: @Julesssss

🎀 👀 🎀 C+ reviewed

Julesssss · 2023-05-04T08:47:59Z

@cristipaval I think you're the assigned reviewer

cristipaval

👌

melvin-bot · 2023-05-04T20:38:22Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2023-05-04T20:43:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-05T20:02:32Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2023-05-08T07:58:00Z

Looks like there is an issue #18552 when we change the skin tone. cc: @perunt

Root cause was present before this PR but we used that data in this PR thus it started crashing the app.

perunt · 2023-05-08T08:27:58Z

I figured out what was wrong and fixed it PR. Oh, and I also noticed that the background of the emoji you picked wasn't changing in the list, but I took care of that too.

perunt · 2023-05-08T09:20:39Z

@parasharrajat It probably makes more sense to fix this issue directly in getPersonalDetailsByIDs, but for now, I've made these changes as a quick fix. I haven't had a chance to investigate how making changes in getPersonalDetailsByIDs would affect the app

parasharrajat · 2023-05-08T09:40:07Z

I think we can fix the root cause. That will be better.

OSBotify · 2023-05-09T04:05:07Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane · 2023-06-11T21:27:28Z

src/pages/home/report/ReactionList/ReactionList.js

+    users,
+    emojiName,
+    emojiCodes,
+    hasUserReacted,


Beep boop 🤖 🐧

Just dropping a friendly note that we missed an edge case while implementing this feature - The emoji reaction number and the user who reached the emoji doesn't dynamically update.

We should get the emoji info related to the reportActionId from Onyx.

mollfpr · 2023-10-20T16:33:11Z

src/components/Reactions/ReportActionItemReactions.js

@@ -81,12 +109,16 @@ const ReportActionItemReactions = (props) => {
                        key={reaction.emoji}
                    >
                        <EmojiReactionBubble
+                            ref={props.forwardedRef}


✋ Coming from #25976

We are preventing the popover from closing when clicking on the popover and the anchor. In this case, the entire View component where the reactions sit is used as the anchor, causing clicks to be ignored in this area.

perunt added 3 commits March 6, 2023 17:17

ReactionList

f6279ea

update styles

bc5a517

add isLongPressEnabledWithHover to PressableWithSecondaryInteraction

5732ada

perunt marked this pull request as ready for review March 7, 2023 12:51

perunt requested a review from a team as a code owner March 7, 2023 12:51

melvin-bot bot requested review from cristipaval and removed request for a team March 7, 2023 12:52

reactionCount

72d53e9

hannojg reviewed Mar 7, 2023

View reviewed changes

src/pages/home/report/ReactionList/PopoverReactionList.js Outdated Show resolved Hide resolved

perunt changed the title ~~Reaction list~~ Detailed list of reaction senders when long-/right-pressing a reaction Mar 7, 2023

typo

0280636

stitesExpensify self-requested a review March 8, 2023 13:57

stitesExpensify assigned perunt Mar 8, 2023

Merge branch 'main' of https://github.com/margelo/expensify-app-fork …

82b02be

…into perunt/reaction-list-on-secondary-interaction

perunt added 5 commits March 10, 2023 19:53

Merge branch 'hanno/feat-tolltip-reaction-senders' of https://github.…

156d6ef

…com/margelo/expensify-app-fork into perunt/reaction-list-on-secondary-interaction

import getPersonalDetailsByIDs

c66388b

take hasUserReacted from Report

0317bd7

Resolving a merge conflict

e36ba93

Merge branch 'hanno/feat-tolltip-reaction-senders' of https://github.…

b16febf

…com/margelo/expensify-app-fork into perunt/reaction-list-on-secondary-interaction

perunt added 3 commits March 15, 2023 14:39

Merge branch 'main' of https://github.com/margelo/expensify-app-fork …

fbc69cf

…into perunt/reaction-list-on-secondary-interaction

remove container

502920e

Merge branch 'main' of https://github.com/Expensify/App into perunt/r…

5bc555d

…eaction-list-on-secondary-interaction

hannojg mentioned this pull request Mar 17, 2023

[$1000] [HOLD for payment 2023-05-16] Create a detailed list of reaction senders when long-/right-pressing a reaction #15128

Closed

hannojg reviewed Mar 20, 2023

View reviewed changes

update propTypes

6bc54ce

parasharrajat reviewed May 2, 2023

View reviewed changes

Julesssss reviewed May 3, 2023

View reviewed changes

src/pages/home/report/ReactionList/BaseReactionList.js Show resolved Hide resolved

parasharrajat approved these changes May 3, 2023

View reviewed changes

Julesssss approved these changes May 4, 2023

View reviewed changes

cristipaval approved these changes May 4, 2023

View reviewed changes

cristipaval merged commit 75d03a4 into Expensify:main May 4, 2023

OSBotify mentioned this pull request May 5, 2023

Deploy Checklist: New Expensify 2023-05-05 #18498

Closed

31 tasks

Natnael-Guchima mentioned this pull request May 7, 2023

[HOLD for payment 2023-05-22] [$1000] App crashes when right clicking on a reaction once sender react to message with multiple emoji tone color, and recipient reacts to it #18552

Closed

6 tasks

s77rt mentioned this pull request May 9, 2023

Prevent crash after interacting with reaction tooltip #18037

Merged

56 tasks

rushatgabhane reviewed Jun 11, 2023

View reviewed changes

rushatgabhane mentioned this pull request Jun 11, 2023

[HOLD for payment 2023-06-02] [$1000] The emoji reaction number and the user who reached the emoji doesn't dynamically update on mweb chrome #18554

Closed

6 tasks

mollfpr reviewed Oct 20, 2023

View reviewed changes

mollfpr mentioned this pull request Oct 20, 2023

[$500] Chat - Unable to close Emoji-reacted popover when click outside, near the bottom of popover #25976

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detailed list of reaction senders when long-/right-pressing a reaction #15685

Detailed list of reaction senders when long-/right-pressing a reaction #15685

perunt commented Mar 6, 2023 •

edited

Loading

MelvinBot commented Mar 7, 2023

stitesExpensify commented Mar 8, 2023

perunt commented Mar 8, 2023

stitesExpensify commented Mar 8, 2023

stitesExpensify commented Mar 14, 2023

parasharrajat May 2, 2023

Julesssss May 2, 2023

perunt commented May 2, 2023

parasharrajat commented May 2, 2023

grgia commented May 2, 2023

perunt commented May 3, 2023

grgia commented May 3, 2023

perunt commented May 3, 2023

parasharrajat commented May 3, 2023

parasharrajat commented May 3, 2023 •

edited

Loading

parasharrajat left a comment

Julesssss commented May 4, 2023

cristipaval left a comment

melvin-bot bot commented May 4, 2023

OSBotify commented May 4, 2023

OSBotify commented May 5, 2023

parasharrajat commented May 8, 2023 •

edited

Loading

perunt commented May 8, 2023 •

edited

Loading

perunt commented May 8, 2023

parasharrajat commented May 8, 2023

OSBotify commented May 9, 2023

rushatgabhane Jun 11, 2023 •

edited

Loading

mollfpr Oct 20, 2023

Detailed list of reaction senders when long-/right-pressing a reaction #15685

Detailed list of reaction senders when long-/right-pressing a reaction #15685

Conversation

perunt commented Mar 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 7, 2023

stitesExpensify commented Mar 8, 2023

perunt commented Mar 8, 2023

stitesExpensify commented Mar 8, 2023

stitesExpensify commented Mar 14, 2023

parasharrajat May 2, 2023

Choose a reason for hiding this comment

Julesssss May 2, 2023

Choose a reason for hiding this comment

perunt commented May 2, 2023

parasharrajat commented May 2, 2023

grgia commented May 2, 2023

perunt commented May 3, 2023

grgia commented May 3, 2023

perunt commented May 3, 2023

parasharrajat commented May 3, 2023

parasharrajat commented May 3, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Julesssss commented May 4, 2023

cristipaval left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 4, 2023

OSBotify commented May 4, 2023

OSBotify commented May 5, 2023

parasharrajat commented May 8, 2023 • edited Loading

perunt commented May 8, 2023 • edited Loading

perunt commented May 8, 2023

parasharrajat commented May 8, 2023

OSBotify commented May 9, 2023

rushatgabhane Jun 11, 2023 • edited Loading

Choose a reason for hiding this comment

mollfpr Oct 20, 2023

Choose a reason for hiding this comment

perunt commented Mar 6, 2023 •

edited

Loading

parasharrajat commented May 3, 2023 •

edited

Loading

parasharrajat commented May 8, 2023 •

edited

Loading

perunt commented May 8, 2023 •

edited

Loading

rushatgabhane Jun 11, 2023 •

edited

Loading