Remove accountID param when signing with SigninUser command #15709

cristipaval · 2023-03-07T14:51:12Z

Details

Here some details.

Fixed Issues

$ #15637

Tests and QA Steps

Verify that you can sign in with an account with 2fa enabed
Verify that you can sign in with an account with 2fa disabled
Verify that you can authenticate with the magic link. Use an account with 2fa enabled
Verify that you can authenticate with the magic link on an account with 2fa disabled

Verify that no errors appear in the JS console

Offline tests

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mobile.chrome.mov

Mobile Web - Safari

mobile.safari.mov

Desktop

desktop.mov

iOS

ios.native.mov

Android

MelvinBot · 2023-03-07T14:51:58Z

@rushatgabhane @alex-mechler One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NikkiWines · 2023-03-08T21:48:16Z

@cristipaval this is held on https://github.com/Expensify/Web-Expensify/pull/36713 being merged + deployed, right?

NikkiWines

👍 Looks good

alex-mechler · 2023-03-08T23:12:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

2023-03-08_15-22-10.mp4

Mobile Web - Chrome

2023-03-08_15-37-27.mp4

Mobile Web - Safari

2023-03-08_15-35-00.mp4

Desktop

2023-03-08_15-38-47.mp4

iOS

2023-03-08_15-33-44.mp4

Android

2023-03-08_15-36-16.mp4

alex-mechler · 2023-03-08T23:39:57Z

This is on hold for now, but feel free to merge it when the blocking PR is on prod

cristipaval · 2023-03-09T10:34:56Z

@cristipaval this is held on Expensify/Web-Expensify#36713 being merged + deployed, right?

Yes, we decided yesterday to integrate the new command in this PR, so it is on hold now. Thanks @alex-mechler for updating the title! 🙇

NikkiWines · 2023-03-09T22:55:47Z

This is off hold now cc: @rushatgabhane

rushatgabhane · 2023-03-10T17:10:03Z

Reviewer Checklist

Screenshots/Videos

Web

Screen.Recording.2023-03-11.at.2.16.28.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-03-11.at.2.48.57.PM.mov

Mobile Web - Safari

Screen.Recording.2023-03-11.at.2.44.52.PM.mov

Desktop

Screen.Recording.2023-03-11.at.2.50.08.PM.mov

iOS

Screen.Recording.2023-03-11.at.2.43.17.PM.mov

Android

WhatsApp.Video.2023-03-11.at.14.47.12.mp4

rushatgabhane · 2023-03-11T09:01:09Z

@cristipaval i tested all platforms, and can sign in with 2fa enabled and disabled. (step 1 and step 2)

But idk how to login with magic code. Can you please help me with it?
https://expensify.slack.com/archives/C01GTK53T8Q/p1678526586324939

src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

github-actions · 2023-03-11T23:32:30Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

roryabraham · 2023-03-11T23:32:32Z

Adding the CP Staging label because the passwordless flow is quite borked at the moment and this makes it better.

NikkiWines

👍

src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

NikkiWines

…ID-in-SIgninUser-command Remove accountID param when signing with SigninUser command (cherry picked from commit 71ffd42)

…-15709 🍒 Cherry pick PR #15709 to staging 🍒

OSBotify · 2023-03-12T01:01:26Z

🚀 Cherry-picked to staging by https://github.com/NikkiWines in version: 1.2.82-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Julesssss · 2023-03-13T11:50:30Z

Verified all 4 test cases and I'm checking this off the deploy checklist 🚀

RPReplay_Final1678708012.MP4

OSBotify · 2023-03-13T12:37:58Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.2.82-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:35:43Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:53:28Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Remove accountID param when signing with SigninUser command

1976c2d

cristipaval requested a review from a team as a code owner March 7, 2023 14:51

cristipaval self-assigned this Mar 7, 2023

melvin-bot bot requested review from alex-mechler and rushatgabhane and removed request for a team March 7, 2023 14:51

cristipaval added 3 commits March 7, 2023 16:56

Fix Lint error.

b575ae4

Lint

1fdb753

New command for when the user signs in with magic link.

56f1582

cristipaval requested a review from NikkiWines March 8, 2023 20:20

Remove unnecessary comment.

456c538

cristipaval mentioned this pull request Mar 8, 2023

[HOLD for payment 2023-03-20] 2FA prompt displayed for account with 2FA disabled #15637

Closed

6 tasks

NikkiWines previously approved these changes Mar 8, 2023

View reviewed changes

alex-mechler changed the title ~~Remove accountID param when signing with SigninUser command~~ [HOLD Web-E 36713]Remove accountID param when signing with SigninUser command Mar 8, 2023

alex-mechler changed the title ~~[HOLD Web-E 36713]Remove accountID param when signing with SigninUser command~~ [HOLD Web-E 36713] Remove accountID param when signing with SigninUser command Mar 8, 2023

alex-mechler previously approved these changes Mar 8, 2023

View reviewed changes

NikkiWines changed the title ~~[HOLD Web-E 36713] Remove accountID param when signing with SigninUser command~~ Remove accountID param when signing with SigninUser command Mar 9, 2023

rushatgabhane previously approved these changes Mar 11, 2023

View reviewed changes

New endpoint when signing with magic link.

5e04149

cristipaval dismissed stale reviews from rushatgabhane, alex-mechler, and NikkiWines via 5e04149 March 11, 2023 23:11

roryabraham reviewed Mar 11, 2023

View reviewed changes

src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js Outdated Show resolved Hide resolved

Remove unnecessary default from lodashGet

538c9bc

roryabraham added the CP Staging label Mar 11, 2023

NikkiWines previously approved these changes Mar 11, 2023

View reviewed changes

src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js Show resolved Hide resolved

Remove unnecessary member functions

271ac44

roryabraham dismissed NikkiWines’s stale review via 271ac44 March 11, 2023 23:36

NikkiWines approved these changes Mar 11, 2023

View reviewed changes

NikkiWines merged commit 71ffd42 into main Mar 11, 2023

NikkiWines deleted the cristi_avoid-sending-accountID-in-SIgninUser-command branch March 11, 2023 23:50

OSBotify pushed a commit that referenced this pull request Mar 11, 2023

Merge pull request #15709 from Expensify/cristi_avoid-sending-account…

f279140

…ID-in-SIgninUser-command Remove accountID param when signing with SigninUser command (cherry picked from commit 71ffd42)

OSBotify mentioned this pull request Mar 11, 2023

🍒 Cherry pick PR #15709 to staging 🍒 #15882

Merged

OSBotify added a commit that referenced this pull request Mar 11, 2023

Merge pull request #15882 from Expensify/OSBotify-cherry-pick-staging…

e5e3edd

…-15709 🍒 Cherry pick PR #15709 to staging 🍒

OSBotify mentioned this pull request Mar 11, 2023

Deploy Checklist: New Expensify 2023-03-10 #15836

Closed

16 tasks

OSBotify mentioned this pull request Mar 13, 2023

Deploy Checklist: New Expensify 2023-03-13 #15889

Closed

16 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove accountID param when signing with SigninUser command #15709

Remove accountID param when signing with SigninUser command #15709

cristipaval commented Mar 7, 2023 •

edited

Loading

MelvinBot commented Mar 7, 2023

NikkiWines commented Mar 8, 2023

NikkiWines left a comment

alex-mechler commented Mar 8, 2023 •

edited

Loading

alex-mechler commented Mar 8, 2023

cristipaval commented Mar 9, 2023

NikkiWines commented Mar 9, 2023

rushatgabhane commented Mar 10, 2023 •

edited

Loading

rushatgabhane commented Mar 11, 2023 •

edited

Loading

github-actions bot commented Mar 11, 2023

roryabraham commented Mar 11, 2023

NikkiWines left a comment

NikkiWines left a comment

OSBotify commented Mar 12, 2023

Julesssss commented Mar 13, 2023

OSBotify commented Mar 13, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Remove accountID param when signing with SigninUser command #15709

Remove accountID param when signing with SigninUser command #15709

Conversation

cristipaval commented Mar 7, 2023 • edited Loading

Details

Fixed Issues

Tests and QA Steps

Offline tests

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 7, 2023

NikkiWines commented Mar 8, 2023

NikkiWines left a comment

Choose a reason for hiding this comment

alex-mechler commented Mar 8, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

alex-mechler commented Mar 8, 2023

cristipaval commented Mar 9, 2023

NikkiWines commented Mar 9, 2023

rushatgabhane commented Mar 10, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented Mar 11, 2023 • edited Loading

github-actions bot commented Mar 11, 2023

roryabraham commented Mar 11, 2023

NikkiWines left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 12, 2023

Julesssss commented Mar 13, 2023

OSBotify commented Mar 13, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

cristipaval commented Mar 7, 2023 •

edited

Loading

alex-mechler commented Mar 8, 2023 •

edited

Loading

rushatgabhane commented Mar 10, 2023 •

edited

Loading

rushatgabhane commented Mar 11, 2023 •

edited

Loading