-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Update go back spanish copy #15840
Conversation
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
Reviewer Checklist
Screenshots/VideosSuper simple Spanish copy change no need to test this on all platforms, tested on web in the PR body WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
Merging since it's pretty simple and we got two Spanish speaker approvals. |
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.2.82-3 🚀
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.2.82-3 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.2.82-4 🚀
|
Details
Updating the go back copy to Volver
Fixed Issues
https://expensify.slack.com/archives/C21FRDWCV/p1678451003100569
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
Very simple change, no need for testing on all platforms
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android