Clean up MoneyRequestModal #16976

thienlnam · 2023-04-05T19:59:21Z

Details

None of this stuff is used - I modified the API to always send back an error response, and even then nothing happened because props.iou.creatingIOUTransaction is not used or set anywhere

Fixed Issues

$ #16942
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

This is gutting some unused functionality of the IOUModal so lets test the main flows in all sorts of ways

Request Money

Request money via the global create
Update the currency to something random
Select a participant
Verify a transaction is created between you and the participant

Split bill

Split bill via the global create
Update the currency to USD
Select 8 participants and notice you see the text You've selected the maximum number (8) of participants.
Continue and write a description
Notice that a group chat was created, and in each DM a message was sent

Send Money

Send money via the global create
Update the currency to USD
Select a participant and hit 'Settle outside of Expensify'
Verify it works as expected

Verify that the nothing about the IOU functionality has changed
Verify that no errors appear in the JS console

Offline tests

Requesting money when offline should create the IOU in the pending state:

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-04-27.at.3.36.40.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-04-27.at.3.37.40.PM.mov

Mobile Web - Safari

Desktop

Screen.Recording.2023-04-27.at.3.39.11.PM.mov

iOS

Android

MelvinBot · 2023-04-27T23:15:34Z

@mollfpr @tgolen One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2023-04-28T02:01:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

16976.Web.mp4

Mobile Web - Chrome

16976.mWeb-Chrome.mp4

Mobile Web - Safari

16976.mWeb-Safari.mp4

Desktop

16976.Desktop.mp4

iOS

16976.iOS.mp4

Android

16976.Android.mp4

tgolen · 2023-04-28T14:17:06Z

src/pages/iou/MoneyRequestModal.js

-        }
-    }, [props.iou]);
-
-    useEffect(() => {


Wouldn't this one still be in use?

Ah yeah this useEffect is something still works. I was looking to see how far back when we decided to add this because I wasn't sure it was being useful (just changes the currency to current location)

But I can add it back - I was a little overzealous on the refactoring and removing old code

mollfpr · 2023-04-28T14:31:06Z

@thienlnam Since you mention that creatingIOUTransaction is not used anymore, it should make sense to remove it altogether.

App/src/pages/iou/MoneyRequestModal.js

Lines 52 to 53 in b4ed202

    
           /** Whether or not transaction creation has started */ 
        
           creatingIOUTransaction: PropTypes.bool,

App/src/pages/iou/MoneyRequestModal.js

Line 94 in b4ed202

creatingIOUTransaction: false,

App/src/setup/index.js

Line 38 in b4ed202

loading: false, error: false, creatingIOUTransaction: false,

tgolen · 2023-05-02T14:13:44Z

bump @thienlnam for response on the reviews

thienlnam · 2023-05-02T16:24:42Z

Thanks! Will also address Luthfi's comments soon. Though going to put this on hold because now that we're adding back this offline code it is being refactored to add a useOnNetworkReconnect hook in https://github.com/Expensify/App/pull/17400/files

thienlnam · 2023-05-11T20:09:47Z

Okay addressed, ready for another review

mollfpr

LGTM and tests well 🚀

thienlnam · 2023-05-12T19:00:59Z

Self-merging since reviewers both approved!

OSBotify · 2023-05-12T19:06:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-15T09:19:35Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-17T00:19:25Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

thienlnam added 3 commits April 5, 2023 12:17

Update MoneyRequestModal.js

a06bdc6

remove update currency

0f4c790

remove unused

56bbbac

thienlnam self-assigned this Apr 5, 2023

thienlnam added 3 commits April 11, 2023 17:37

Merge branch 'main' into jack-cleanMoneyRequestModal

9159884

clean up unused

6fba602

Merge branch 'main' into jack-cleanMoneyRequestModal

aed6578

thienlnam marked this pull request as ready for review April 27, 2023 23:14

thienlnam requested a review from a team as a code owner April 27, 2023 23:14

melvin-bot bot requested review from mollfpr and tgolen and removed request for a team April 27, 2023 23:15

tgolen reviewed Apr 28, 2023

View reviewed changes

thienlnam changed the title ~~Clean up MoneyRequestModal~~ [HOLD] Clean up MoneyRequestModal May 2, 2023

thienlnam added 2 commits May 11, 2023 12:53

Merge branch 'main' into jack-cleanMoneyRequestModal

3b0f78f

address review comments / remove creatingIOUTransaction

9d24507

lint fixxx

5b409ab

thienlnam changed the title ~~[HOLD] Clean up MoneyRequestModal~~ Clean up MoneyRequestModal May 11, 2023

tgolen approved these changes May 12, 2023

View reviewed changes

mollfpr approved these changes May 12, 2023

View reviewed changes

thienlnam merged commit 3fba7dc into main May 12, 2023

thienlnam deleted the jack-cleanMoneyRequestModal branch May 12, 2023 19:01

OSBotify mentioned this pull request May 15, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

melvin-bot bot mentioned this pull request May 16, 2023

[HOLD for payment 2023-05-23] Investigate how to clean up MoneyRequestModal effects #16942

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up MoneyRequestModal #16976

Clean up MoneyRequestModal #16976

thienlnam commented Apr 5, 2023 •

edited

Loading

MelvinBot commented Apr 27, 2023

mollfpr commented Apr 28, 2023 •

edited

Loading

tgolen Apr 28, 2023

thienlnam May 2, 2023

mollfpr commented Apr 28, 2023

tgolen commented May 2, 2023

thienlnam commented May 2, 2023

thienlnam commented May 11, 2023

mollfpr left a comment

thienlnam commented May 12, 2023

OSBotify commented May 12, 2023

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

Clean up MoneyRequestModal #16976

Clean up MoneyRequestModal #16976

Conversation

thienlnam commented Apr 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 27, 2023

mollfpr commented Apr 28, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

tgolen Apr 28, 2023

Choose a reason for hiding this comment

thienlnam May 2, 2023

Choose a reason for hiding this comment

mollfpr commented Apr 28, 2023

tgolen commented May 2, 2023

thienlnam commented May 2, 2023

thienlnam commented May 11, 2023

mollfpr left a comment

Choose a reason for hiding this comment

thienlnam commented May 12, 2023

OSBotify commented May 12, 2023

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

thienlnam commented Apr 5, 2023 •

edited

Loading

mollfpr commented Apr 28, 2023 •

edited

Loading