Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add should deploy to production env variable #1729

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Conversation

AndrewGable
Copy link
Contributor

Details

Adds logic to determine where to deploy (staging vs production).

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/155196
Fixes https://github.com/Expensify/Expensify/issues/155195

Tests

  1. Merge this PR
  2. Make sure that:
  • On web, always deploy to production
  • On desktop, always deploy to production
  • On iOS, always deploy to staging
  • On Android, always deploy to staging

@AndrewGable AndrewGable requested a review from roryabraham March 11, 2021 19:28
@AndrewGable AndrewGable requested a review from a team as a code owner March 11, 2021 19:28
@AndrewGable AndrewGable self-assigned this Mar 11, 2021
@botify botify requested review from robertjchen and tgolen and removed request for a team March 11, 2021 19:28
@tgolen tgolen merged commit fff0c91 into master Mar 11, 2021
@tgolen tgolen deleted the andrew-prod-actions branch March 11, 2021 21:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants