Fix keyboard flicker and input overlap in SignInPage #17445

hellohublot · 2023-04-14T06:01:38Z

Details

This PR fixes the problem that after clicking [Create A New Account, Log In, Go Back, Back, Forget], the native keyboard will flash or the input is covered

~~This PR adds the null value judgment of Hoverable.onBlur.wrapperView, it also work fine in #14507~~

Fixed Issues

$ #16357
$ #16357 (comment)

Tests

Case 1:

Log out
Enter your phone number or email address and click Continue
Scroll to the bottom and click Create A New Account
Verify that the keyboard don't flicker

Case 2:

Log out
Enter your phone number or email address and click Continue
Scroll until you can hide the input (Web and desktop can be skipped)
Click Go back
Verify the page will automatically scroll to the top, and without covering the input

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as the other

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

_web.mov

Mobile Web - Chrome

_mobile_chrome.mp4

Mobile Web - Safari

_mobile_safari.mp4

Desktop

_desktop.mov

iOS

_ios.mp4

Android

_android.mp4

MelvinBot · 2023-04-14T08:02:07Z

@roryabraham @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-04-14T20:57:02Z

@hellohublot I see 6 out of 5 commits say fix lint, it's better to fix them all in one commit and avoid unnecessary commits. Also you can check lint npm run lint before committing changes.

Santhosh-Sellavel · 2023-04-14T20:59:04Z

Can you update the title meaningfully & avoid spelling mistakes?

hellohublot · 2023-04-15T02:34:02Z

@Santhosh-Sellavel Thank you very much. Every time I run 'npm run lint', it gives an error of excessive memory usage. Therefore, I sometimes use the GitHub lint. I will do my best to resolve this issue. I have merged all the lint commits and also modified the PR title

Santhosh-Sellavel

Can you also update the test steps covering everything i.e every case? Also, Don't repeat the same steps in two sections. Please leave a comment saying the same as the other.

Also please resolve conflicts, thanks!

src/components/Hoverable/index.js

src/pages/signin/SignInPageLayout/index.js

roryabraham · 2023-04-17T19:03:13Z

@hellohublot Looks like there are merge conflicts to resolve here.

hellohublot · 2023-04-17T22:23:52Z

@Santhosh-Sellavel Thanks, everything has been edited

src/components/Hoverable/index.js

Santhosh-Sellavel · 2023-04-18T23:19:49Z

@hellohublot Please avoid force-pushing the review history is kind of messed up here

Santhosh-Sellavel · 2023-04-20T22:24:33Z

Sign-in Details not cleared

Screen.Recording.2023-04-21.at.3.37.28.AM.mov

But seem this is occurring in production too, behaviour change is occurring from this PR

Santhosh-Sellavel · 2023-04-21T19:15:07Z

@roryabraham Can we hold this PR till the above Regression is handled, because this PR is dependent on the changes made there?

I've left a comment here on the PR #17119 (comment) and an issue as well.

roryabraham · 2023-04-21T19:58:48Z

Sorry, I'm not following ... can someone explain how this PR is related to #16052 ?

Santhosh-Sellavel · 2023-04-21T20:02:36Z

Sorry, I'm not following ... can someone explain how this PR is related to #16052 ?

It was about this change, more details on why #16357 (comment)

This PR adds the null value judgment of Hoverable.onBlur.wrapperView, it also work fine in #14507

Hoverable.onBlur will be removed #16052 or #17422

Santhosh-Sellavel · 2023-04-24T20:12:12Z

We are waiting for this #17812

roryabraham · 2023-04-25T18:12:50Z

We are waiting for this #17812

Got that PR updated and ready for re-view

Santhosh-Sellavel · 2023-05-03T20:03:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-05-07.at.11.12.42.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-05-07.at.11.17.10.PM.mov

iOS & Android

Screen.Recording.2023-05-07.at.11.14.18.PM.mov

Santhosh-Sellavel · 2023-05-03T20:46:00Z

@hellohublot Can you pull changes from the latest main and update the test steps and screen records here as there have been some changes recently? thanks!

hellohublot · 2023-05-04T11:50:37Z

@Santhosh-Sellavel Thanks, updated

Santhosh-Sellavel · 2023-05-07T18:32:19Z

I've run into a weird issue while testing.

Unable to focus the login input after performing few steps, this happens on the main & staging as well so reported on slack here

Screen_Recording_20230507_234916_New.Expensify.mp4

Santhosh-Sellavel

LGTM tests well!

Found this one while testing. But happens on the main as well.
Refer this #17445 (comment)

All yours @roryabraham!

Santhosh-Sellavel · 2023-05-11T15:20:14Z

@hellohublot We have conflicts here, please resolve!

hellohublot · 2023-05-11T15:48:28Z

@Santhosh-Sellavel Thanks, done and tested again

Santhosh-Sellavel · 2023-05-11T15:56:00Z

LGTM tests well!

Found this one while testing. But happens on the main as well. Refer this #17445 (comment)

All yours @roryabraham!

bump @roryabraham!

OSBotify · 2023-05-11T20:21:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-15T09:20:14Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-17T00:20:04Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2023-07-12T17:50:56Z

src/pages/signin/SignInPageLayout/index.js

+        scrollViewRef.current.scrollTo({y: 0, animated});
+    };
+
+    useEffect(scrollPageToTop, [props.welcomeHeader, props.welcomeText]);


This caused an issue where changing the language also caused the page to scroll. #21504

hellohublot mentioned this pull request Apr 14, 2023

Fix Hoverable onBlur wrapperView null value crash #17446

Closed

56 tasks

melvin-bot bot added the Reviewing Has a PR in review label Apr 14, 2023

hellohublot mentioned this pull request Apr 14, 2023

[HOLD for payment 2023-05-23] [$2000] Android - Sign in - The keyboard opens and disappears for a brief moment #16357

Closed

6 tasks

hellohublot marked this pull request as ready for review April 14, 2023 08:02

hellohublot requested a review from a team as a code owner April 14, 2023 08:02

melvin-bot bot requested review from roryabraham and Santhosh-Sellavel and removed request for a team April 14, 2023 08:02

hellohublot force-pushed the Fix_SignIn_ScrollTop branch from 18ade24 to 67f7d54 Compare April 15, 2023 02:25

hellohublot changed the title ~~Fix SinInPage all click scrollToTop~~ Fix keyboard flicker and input overlap in SignInPage Apr 15, 2023

Santhosh-Sellavel suggested changes Apr 17, 2023

View reviewed changes

src/components/Hoverable/index.js Outdated Show resolved Hide resolved

src/pages/signin/SignInPageLayout/index.js Show resolved Hide resolved

hellohublot added 3 commits April 18, 2023 05:52

Merge origin/main to resolve conflicts

ed5608a

Fix Hoverable onBlur wrapperView null value crash

3b31959

Fix Lint

862c618

hellohublot force-pushed the Fix_SignIn_ScrollTop branch from 3c6ee9c to 862c618 Compare April 17, 2023 22:11

hellohublot force-pushed the Fix_SignIn_ScrollTop branch 3 times, most recently from aa0cc22 to aa52949 Compare April 18, 2023 01:29

Avoid scrolling by every render

097807d

hellohublot force-pushed the Fix_SignIn_ScrollTop branch from aa52949 to 097807d Compare April 18, 2023 02:20

Santhosh-Sellavel reviewed Apr 18, 2023

View reviewed changes

src/components/Hoverable/index.js Outdated Show resolved Hide resolved

hellohublot added 2 commits April 18, 2023 23:35

Remove Hoverable Clone child onBlur this.wrapperView condition

af048d5

Clarity of Judgment Conditions

7dfc6c4

rushatgabhane mentioned this pull request Apr 26, 2023

[HOLD for payment 2023-04-26] [$1000] Wrong transition in Login page when click Login menu #16981

Closed

6 tasks

hellohublot added 2 commits May 4, 2023 18:39

Merge branch 'main' into Fix_SignIn_ScrollTop

04e6020

Update scroll condition

033f9cd

Santhosh-Sellavel reviewed May 7, 2023

View reviewed changes

Merge from main

6391d1a

Santhosh-Sellavel approved these changes May 11, 2023

View reviewed changes

roryabraham approved these changes May 11, 2023

View reviewed changes

roryabraham merged commit 1eb3ffd into Expensify:main May 11, 2023

OSBotify mentioned this pull request May 15, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

neil-marcellini mentioned this pull request Jun 27, 2023

[HOLD for payment 2023-07-10] [$1000] Login page scroll to top on change language #21504

Closed

6 tasks

hoangzinh mentioned this pull request Jun 28, 2023

Fix Login page scroll to top on change language #21815

Merged

57 tasks

parasharrajat reviewed Jul 12, 2023

View reviewed changes

sobitneupane mentioned this pull request Feb 2, 2024

[HOLD for payment 2024-01-17] [$500] Log in - E-mail input field not focused when scroll down and click Create A New Account/Log in #32508

Closed

6 tasks

linhvovan29546 mentioned this pull request Jan 24, 2025

[Due for payment 2025-02-13] [$250] Log in - Login page scroll to top on change language #55368

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix keyboard flicker and input overlap in SignInPage #17445

Fix keyboard flicker and input overlap in SignInPage #17445

hellohublot commented Apr 14, 2023 •

edited

Loading

MelvinBot commented Apr 14, 2023

Santhosh-Sellavel commented Apr 14, 2023

Santhosh-Sellavel commented Apr 14, 2023

hellohublot commented Apr 15, 2023

Santhosh-Sellavel left a comment

roryabraham commented Apr 17, 2023

hellohublot commented Apr 17, 2023

Santhosh-Sellavel commented Apr 18, 2023

Santhosh-Sellavel commented Apr 20, 2023

Santhosh-Sellavel commented Apr 21, 2023 •

edited

Loading

roryabraham commented Apr 21, 2023

Santhosh-Sellavel commented Apr 21, 2023 •

edited

Loading

Santhosh-Sellavel commented Apr 24, 2023

roryabraham commented Apr 25, 2023

Santhosh-Sellavel commented May 3, 2023 •

edited

Loading

Santhosh-Sellavel commented May 3, 2023

hellohublot commented May 4, 2023

Santhosh-Sellavel commented May 7, 2023

Santhosh-Sellavel left a comment

Santhosh-Sellavel commented May 11, 2023

hellohublot commented May 11, 2023

Santhosh-Sellavel commented May 11, 2023

OSBotify commented May 11, 2023

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

parasharrajat Jul 12, 2023

Fix keyboard flicker and input overlap in SignInPage #17445

Fix keyboard flicker and input overlap in SignInPage #17445

Conversation

hellohublot commented Apr 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 14, 2023

Santhosh-Sellavel commented Apr 14, 2023

Santhosh-Sellavel commented Apr 14, 2023

hellohublot commented Apr 15, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

roryabraham commented Apr 17, 2023

hellohublot commented Apr 17, 2023

Santhosh-Sellavel commented Apr 18, 2023

Santhosh-Sellavel commented Apr 20, 2023

Santhosh-Sellavel commented Apr 21, 2023 • edited Loading

roryabraham commented Apr 21, 2023

Santhosh-Sellavel commented Apr 21, 2023 • edited Loading

Santhosh-Sellavel commented Apr 24, 2023

roryabraham commented Apr 25, 2023

Santhosh-Sellavel commented May 3, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented May 3, 2023

hellohublot commented May 4, 2023

Santhosh-Sellavel commented May 7, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented May 11, 2023

hellohublot commented May 11, 2023

Santhosh-Sellavel commented May 11, 2023

OSBotify commented May 11, 2023

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

parasharrajat Jul 12, 2023

Choose a reason for hiding this comment

hellohublot commented Apr 14, 2023 •

edited

Loading

Santhosh-Sellavel commented Apr 21, 2023 •

edited

Loading

Santhosh-Sellavel commented Apr 21, 2023 •

edited

Loading

Santhosh-Sellavel commented May 3, 2023 •

edited

Loading