-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make preDeploy workflow handle StagingDeployCash logic #1745
Conversation
# Conflicts: # .github/workflows/preDeploy.yml
This is off hold and ready for review, but don't merge just yet because I want to do some testing in another repo |
Okay, did some testing of the stuff I was unsure about here. This is updated and ready for review & merge-test. |
Is this off hold too? |
Tests failed second step:
https://github.com/Expensify/Expensify.cash/actions/runs/647369887 I will make a PR to resolve this and continue testing |
PR to resolve typo 👉 #1750 I will continue testing once this is merged! |
Got another error:
https://github.com/Expensify/Expensify.cash/runs/2098738279?check_suite_focus=true |
@roryabraham fixed that error: #1752 Back on the testing 🐴 |
Verified that the first set of tests pass ✅ Now working on verifying the 🔒 label works |
Tested the 🔒 functionality in: #1754 Got an error:
We think we know the fix |
Details
Run two new actions at the beginning of the workflow:
github_token
input (note lowercase notGITHUB_TOKEN
😉), so should be pretty difficulty to misconfigure.Then if the StagingDeployCash is locked, we comment on the PR stating that it will be merged later, and skip all the rest of the workflow steps. Otherwise, continue as usual, except with one new final step. In the last step, use the
createOrUpdateStagingDeploy
action to add the newly merged PR to the StagingDeployCash.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/155208
Tests
Testing plan:
OSBotify
does not comment on the merged PR stating that it was not deployed yet.🔐 LockCashDeploys 🔐
label to theStagingDeployCash
.OSBotify
comments on the merged PR staging that is was not deployed yet.