Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 16528 upload gif image fluctuate #17454

Merged

Conversation

tienifr
Copy link
Contributor

@tienifr tienifr commented Apr 14, 2023

Details

Fixed Issues

$ #16528
PROPOSAL: #16528 (comment)

Tests

  • The image shouldn’t fluctuate while trying to preview the image
  1. Open web chrome and open any chat and send a message
  2. Click on profile icon and upload a gif image. Crop the image to full.
  3. From the chat, click on your profile picture and preview it.
  4. Verify the image shouldn’t fluctuate
  • The image shouldn’t be empty when preview the image
  1. Open web chrome and open any chat and send a message
  2. Click on profile icon and upload a large image.
  3. From the chat, click on your profile picture and preview it.
  4. Verify the image shouldn’t be empty
  • Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

  • The image shouldn’t fluctuate while trying to preview the image
  1. Open web chrome and open any chat and send a message
  2. Click on profile icon and upload a gif image. Crop the image to full.
  3. From the chat, click on your profile picture and preview it.
  4. Verify the image shouldn’t fluctuate
  • The image shouldn’t be empty when preview the image
  1. Open web chrome and open any chat and send a message
  2. Click on profile icon and upload a large image.
  3. From the chat, click on your profile picture and preview it.
  4. Verify the image shouldn’t be empty
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-04-14.at.14.54.59.mp4
Mobile Web - Chrome
RPReplay_Final1681470972.mp4
Mobile Web - Safari
RPReplay_Final1681470324.mp4
Desktop
Screen.Recording.2023-04-14.at.18.21.37.mp4
iOS
Screen-Recording-2023-04-14-at-18.48.32.mp4
Android

@tienifr tienifr marked this pull request as ready for review April 14, 2023 11:56
@tienifr tienifr requested a review from a team as a code owner April 14, 2023 11:56
@melvin-bot melvin-bot bot requested review from danieldoglas and eVoloshchak and removed request for a team April 14, 2023 11:56
@MelvinBot
Copy link

@danieldoglas @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@@ -35,7 +35,7 @@ class ImageView extends PureComponent {
this.trackPointerPosition = this.trackPointerPosition.bind(this);

this.state = {
isLoading: false,
isLoading: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to change this line because it can improve the performance a bit. isLoading is always set to true then false when image is loaded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree, it should be set to true initially

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for testing?

src/components/AttachmentModal.js Outdated Show resolved Hide resolved
@@ -35,7 +35,7 @@ class ImageView extends PureComponent {
this.trackPointerPosition = this.trackPointerPosition.bind(this);

this.state = {
isLoading: false,
isLoading: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree, it should be set to true initially

@@ -196,14 +196,12 @@ function getZoomCursorStyle(isZoomed, isDragging) {
* @param {Number} zoomScale
* @param {Number} containerHeight
* @param {Number} containerWidth
* @return {Object}
* @param {Boolean} isLoading
* @return {Object | undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our style guide:

Do not use type unions e.g. {(number|boolean)}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eVoloshchak . I know but I still see other place use type unions:

* @param {Number | null} height
.
I don't actually know the best way to do here. What is your thought?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think it's acceptable in this case

src/pages/DetailsPage.js Outdated Show resolved Hide resolved
@@ -196,14 +196,12 @@ function getZoomCursorStyle(isZoomed, isDragging) {
* @param {Number} zoomScale
* @param {Number} containerHeight
* @param {Number} containerWidth
* @return {Object}
* @param {Boolean} isLoading
* @return {Object | undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think it's acceptable in this case

@@ -196,14 +196,12 @@ function getZoomCursorStyle(isZoomed, isDragging) {
* @param {Number} zoomScale
* @param {Number} containerHeight
* @param {Number} containerWidth
* @return {Object}
* @param {Boolean} isLoading
* @return {Object | undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @return {Object | undefined}
* @returns {Object | null}

width: isZoomed ? '250%' : '100%',
};
function getZoomSizingStyle(isZoomed, imgWidth, imgHeight, zoomScale, containerHeight, containerWidth, isLoading) {
if (isLoading || imgWidth === 0 || imgHeight === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (isLoading || imgWidth === 0 || imgHeight === 0) {
// Hide image until finished loading to prevent showing preview with wrong dimensions
if (isLoading || imgWidth === 0 || imgHeight === 0) {

@@ -289,11 +289,13 @@ function updateAvatar(file) {
[currentUserEmail]: {
avatar: file.uri,
avatarThumbnail: file.uri,
avatarFileName: file.name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
avatarFileName: file.name,
originalFileName: file.name,

errorFields: {
avatar: null,
},
pendingFields: {
avatar: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
avatarFileName: null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
avatarFileName: null,
originalFileName: null,

@@ -130,6 +130,7 @@ class DetailsPage extends React.PureComponent {
headerTitle={isSMSLogin ? this.props.toLocalPhone(details.displayName) : details.displayName}
source={ReportUtils.getFullSizeAvatar(details.avatar, details.login)}
isAuthTokenRequired
originalFileName={details.avatarFileName}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
originalFileName={details.avatarFileName}
originalFileName={details.originalFileName}

@tienifr
Copy link
Contributor Author

tienifr commented Apr 17, 2023

@eVoloshchak Thanks for your review. I've updated my PR, but just one minor question. Why do you suggest change @returns {Object | null} instead of @returns {Object | undefined}? I agree with using @returns but I'm not sure we want to return null here 😆 😁

@eVoloshchak
Copy link
Contributor

@eVoloshchak Thanks for your review. I've updated my PR, but just one minor question. Why do you suggest change @returns {Object | null} instead of @returns {Object | undefined}? I agree with using @returns but I'm not sure we want to return null here 😆 😁

It's just easier to read. If that causes problems - I'm perfectly fine with undefined

@tienifr
Copy link
Contributor Author

tienifr commented Apr 18, 2023

@eVoloshchak ok thanks, any updates?

@tienifr
Copy link
Contributor Author

tienifr commented Apr 18, 2023

@eVoloshchak Yes, it's ready for testing

function getZoomSizingStyle(isZoomed, imgWidth, imgHeight, zoomScale, containerHeight, containerWidth, isLoading) {
// Hide image until finished loading to prevent showing preview with wrong dimensions
if (isLoading || imgWidth === 0 || imgHeight === 0) {
return undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return undefined;
return null;

Or if we have to return undefined, change jsdoc to * @returns {Object | undefined}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eVoloshchak I prefer using undefined. I tested all platforms with undefined and I believe it works well. And changing @returns {Object | undefined} is good. Thanks

@tienifr
Copy link
Contributor Author

tienifr commented Apr 19, 2023

@eVoloshchak I think all comments are resolved, can you help test. Thanks

Copy link
Contributor

@eVoloshchak eVoloshchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, tests well on web/Desktop/mWeb
I've encountered a couple of problems in native apps
Android: I'm unable to upload gif as user avatar, get unhandled promise rejection
iOS: getting the following prop type warning when opening user's avatar from chat
IMG_0029
Safari mobile: endless loading spinner if you view image after uploading

IMG_0027.MP4

@tienifr
Copy link
Contributor Author

tienifr commented Apr 20, 2023

@eVoloshchak Do these bug happens on main?

@tienifr
Copy link
Contributor Author

tienifr commented Apr 20, 2023

actually, we don't need to use the gif, the image is enough

@eVoloshchak
Copy link
Contributor

eVoloshchak commented Apr 20, 2023

@eVoloshchak Do these bug happens on main?

Can't reproduce the bug with an endless loading spinner in Safari, I think it was resolved in main.

But I can verify that propTypes warning is caused by this PR, it's not present in main.
This tests well for me, so when we sort the warning out, please upload the missing video for Android, merge main once again, and I'll be able to do the final review

Copy link
Contributor

@eVoloshchak eVoloshchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tienifr, there is still a propType warning on iOS when opening user's avatar from chat
image

And please add a screen recording for Android

@tienifr
Copy link
Contributor Author

tienifr commented Apr 21, 2023

@eVoloshchak I've updated my PR to fix the console warning. Please help take a look

@tienifr
Copy link
Contributor Author

tienifr commented Apr 21, 2023

@eVoloshchak I see the problem when I record the video for android. The endless loading spinner is shown when I open user's avatar from chat

@tienifr
Copy link
Contributor Author

tienifr commented Apr 21, 2023

Screen.Recording.2023-04-21.at.19.16.14.mov

This bug still happens on main

@eVoloshchak
Copy link
Contributor

This bug still happens on main

Can also reproduce this on main. Could you report this in slack, please?

@eVoloshchak
Copy link
Contributor

eVoloshchak commented Apr 21, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-04-27.at.00.48.58.mov
Mobile Web - Chrome
Screen_Recording_20230426-212828_Chrome.mp4
Screen_Recording_20230426-212754_Chrome.mp4
Mobile Web - Safari
IMG_0040.MP4
Desktop
Screen.Recording.2023-04-27.at.00.49.51.mov
iOS
IMG_0043.MP4
Android
Screen_Recording_20230427-003613_New.Expensify.mp4
Screen_Recording_20230427-003929_New.Expensify.mp4

@eVoloshchak
Copy link
Contributor

@tienifr, I'm still getting the bug with endless spinner in Safari after uploading a large image

Screen.Recording.2023-04-21.at.16.40.46.mov

Here's how it looks without this PR

Screen.Recording.2023-04-21.at.16.39.51.mov

@tienifr
Copy link
Contributor Author

tienifr commented Apr 24, 2023

original-30F2EFCF-D0BA-46DE-8716-FCEC6B11D93F.mp4

@eVoloshchak I can't reproduce on physical device. Should we test on physical device?

@tienifr
Copy link
Contributor Author

tienifr commented Apr 24, 2023

I reported the endless spinner bug on android: https://expensify.slack.com/archives/C049HHMV9SM/p1682331646153809

@eVoloshchak
Copy link
Contributor

eVoloshchak commented Apr 24, 2023

I can't reproduce on physical device. Should we test on physical device?

I can reproduce it on a physical device.
The key here is to open the image before it was uploaded (on your video it flashes grey at 0:18, meaning it was uploaded before you opened it). It's much easier to reproduce using the network link conditioner

@tienifr
Copy link
Contributor Author

tienifr commented Apr 25, 2023

@eVoloshchak I found this issue happens even on main

Screen.Recording.2023-04-25.at.16.29.46.mp4

When I try to upload image on small screen, the api UpdateUserAvatar call too many times because the API is error => the image is still blob:http://localhost:8080/<<id>>

As usual, the uri blob:http://localhost:8080/<<id>> should render the image but in this commit:

2f8f93d#diff-5d4cb2a76afdf22bdefb20480e5a8267efdfb76629f06d2e9562be8ff7c0d618

We add isAuthTokenRequired in src/components/AttachmentView.js: <ImageView url={props.source} isAuthTokenRequired={props.isAuthTokenRequired} /> => isAuthTokenRequired is always true. When the uri is blob:http://localhost:8080/<<id>> the isAuthTokenRequired should be false

@tienifr
Copy link
Contributor Author

tienifr commented Apr 25, 2023

@eVoloshchak What do you think? Should we handle it on other PR?

@tienifr
Copy link
Contributor Author

tienifr commented Apr 25, 2023

@eVoloshchak
Copy link
Contributor

Awesome job investigating this!
I think it should be handled as a separate issue, but it might be worth putting this on HOLD until we merge that PR, since an endless loading spinner is worse than an empty attachment we currently have.

@danieldoglas, could you chime in on this please?
We have an issue that got surfaced by this PR, should we

  1. Fix it in a separate issue after merging this PR
  2. Put this PR on hold, resolve the issue, then merge this PR
  3. Fix this as a part of this PR

@danieldoglas
Copy link
Contributor

Let's fix it as part of this PR, I'll increase the bounty for the original issue since we're fixing 2 bugs.

@tienifr
Copy link
Contributor Author

tienifr commented Apr 26, 2023

@eVoloshchak I've updated my PR can you help review again? Thanks

@eVoloshchak
Copy link
Contributor

@tienifr, awesome, the issue on mWeb is resolved
I did, however, encounter a similar issue on Android, I think it wasn't present before

Screen_Recording_20230426-213041_New.Expensify.mp4

@tienifr
Copy link
Contributor Author

tienifr commented Apr 26, 2023

@eVoloshchak I think it's the bug on android that I reported before?

@eVoloshchak
Copy link
Contributor

@eVoloshchak I think it's the bug on android that I reported before?

My bad, totally forgot about that, thanks for the reminder
Will finish the checklist in a couple of hours

Copy link
Contributor

@eVoloshchak eVoloshchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
cc: @danieldoglas

@danieldoglas danieldoglas merged commit 9ec7704 into Expensify:main Apr 26, 2023
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.7-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.7-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants