prevent focus event when long press in emoji suggestion component #17788

ntdiary · 2023-04-21T15:21:08Z

Details

Fixed Issues

$ #16485
PROPOSAL: #16485 (comment)

Tests

go to any chat, type in :sm (to get the suggestion list)
long press any of the emoji from the suggestion list and nothing will happen.
Tapping an emoji in the suggestion list will place it in the main composer input.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

go to any chat, type in :sm (to get the suggestion list)
long press any of the emoji from the suggestion list and nothing will happen.
Tapping an emoji in the suggestion list will place it in the main composer input.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

mac-chrome.mp4

mac-safari.mp4

Mobile Web - Chrome

android-chrome.mp4

Mobile Web - Safari

ios-safari.mp4

Desktop

mac-desktop.mp4

iOS

ios-native.mp4

Android

android-native.mp4

MelvinBot · 2023-04-24T16:19:18Z

@tgolen @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2023-04-24T16:27:43Z

One more question, do we need to change EmojiSuggestions.js to platform specific files?
EmojiSuggestions/index.js and EmojiSuggestions/index.native.js.
Because onpointerdown will not be called in the native app, and also only needs to work on the web platform. (although native allows assignment)

ntdiary · 2023-04-24T16:51:43Z

@rushatgabhane, could you please confirm the above question when you are free? Then I will upload all the test videos tomorrow and fill in the other list items. 🙂

rushatgabhane · 2023-04-24T20:40:17Z

@ntdiary sure, go ahead!

rushatgabhane · 2023-04-25T12:38:43Z

@ntdiary im gonna assume this is ready for review. Let me know if that's not the case

rushatgabhane · 2023-04-25T12:40:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-04-26.at.19.42.14.mov

Mobile Web - Chrome

screen-20230426-000900_2.mp4

Mobile Web - Safari

Screen.Recording.2023-04-26.at.19.40.59.mov

Desktop

Screen.Recording.2023-04-26.at.19.54.02.mov

iOS

Screen.Recording.2023-04-26.at.19.35.01.mov

Android

Screen.Recording.2023-04-26.at.19.35.13.mov

ntdiary · 2023-04-25T13:04:38Z

@rushatgabhane, yeah, it's ready. Please feel free to let me know if you have any questions. 🙂

src/components/EmojiSuggestions/index.js

rushatgabhane · 2023-04-26T14:02:33Z

@ntdiary can you please merge main, there were some recent package.json changes.

Meanwhile, I've merged with main locally for testing.

rushatgabhane · 2023-04-26T14:16:10Z

src/components/EmojiSuggestions/index.js

+            return;
+        }
+        container.onpointerdown = (e) => {
+            if (DeviceCapabilities.hasHoverSupport()) {


NAB: I'm curious - Does this mean this bug will occur on mWeb devices that support a stylus??

function hasHoverSupport() { return !window.matchMedia('(hover: none)').matches; }

The purpose here is that for desktop web platforms that support hover, we don't need to prevent its default behavior, otherwise the emoji will be placed in the main composer immediately after the long-press is released.

Co-authored-by: Tim Golen <tgolen@gmail.com>

rushatgabhane · 2023-04-26T14:46:20Z

@ntdiary could you please fix the lint errors, thanks!

Tests fine after merging main

rushatgabhane

@tgolen LGTM!! 🏎️

tgolen

Thank you!

OSBotify · 2023-04-26T17:45:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-27T05:36:40Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.7-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-28T07:52:07Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ntdiary added 2 commits April 21, 2023 23:18

prevent focus event when long press in emoji suggestion component

05b7bcd

do nothing when long press on emoji suggestions.

20a16f2

ntdiary marked this pull request as ready for review April 24, 2023 16:19

ntdiary requested a review from a team as a code owner April 24, 2023 16:19

melvin-bot bot requested review from rushatgabhane and tgolen and removed request for a team April 24, 2023 16:19

ntdiary added 3 commits April 25, 2023 16:03

rename to platform-specific file

bd68abb

change forwardedRef prop type

65c466e

remove unused import

7958b74

tgolen requested changes Apr 25, 2023

View reviewed changes

src/components/EmojiSuggestions/index.js Show resolved Hide resolved

src/components/EmojiSuggestions/index.js Show resolved Hide resolved

Add the description to explain why there are platform specific file

d8a0468

tgolen requested changes Apr 26, 2023

View reviewed changes

src/components/EmojiSuggestions/index.js Outdated Show resolved Hide resolved

rushatgabhane reviewed Apr 26, 2023

View reviewed changes

ntdiary and others added 2 commits April 26, 2023 22:21

Update src/components/EmojiSuggestions/index.js

2e8f5ce

Co-authored-by: Tim Golen <tgolen@gmail.com>

Merge branch 'main' into fix-issue-16485

273b5b8

fix lint max-length error

384698c

rushatgabhane approved these changes Apr 26, 2023

View reviewed changes

tgolen approved these changes Apr 26, 2023

View reviewed changes

tgolen merged commit 566906e into Expensify:main Apr 26, 2023

0xmiros mentioned this pull request Apr 26, 2023

Add generic AutoCompleteSuggestions component #18024

Merged

56 tasks

OSBotify mentioned this pull request Apr 27, 2023

Deploy Checklist: New Expensify 2023-04-27 #18063

Closed

19 tasks

amyevans mentioned this pull request Apr 27, 2023

IOS- Chat- App is flickering when selecting the face emoji’s with hart 😍 :smiling_face_with_3_hearts: #18083

Closed

6 tasks

MelvinBot mentioned this pull request Apr 28, 2023

[HOLD for payment 2023-05-05] [$1000] Long pressing on emoji suggestions highlights the text/attachments behind the emoji list on mweb #16485

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

prevent focus event when long press in emoji suggestion component #17788

prevent focus event when long press in emoji suggestion component #17788

ntdiary commented Apr 21, 2023 •

edited

Loading

MelvinBot commented Apr 24, 2023

ntdiary commented Apr 24, 2023

ntdiary commented Apr 24, 2023

rushatgabhane commented Apr 24, 2023

rushatgabhane commented Apr 25, 2023 •

edited

Loading

rushatgabhane commented Apr 25, 2023 •

edited

Loading

ntdiary commented Apr 25, 2023

rushatgabhane commented Apr 26, 2023 •

edited

Loading

rushatgabhane Apr 26, 2023 •

edited

Loading

ntdiary Apr 26, 2023

rushatgabhane commented Apr 26, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

tgolen left a comment

OSBotify commented Apr 26, 2023

OSBotify commented Apr 27, 2023

OSBotify commented Apr 28, 2023

prevent focus event when long press in emoji suggestion component #17788

prevent focus event when long press in emoji suggestion component #17788

Conversation

ntdiary commented Apr 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 24, 2023

ntdiary commented Apr 24, 2023

ntdiary commented Apr 24, 2023

rushatgabhane commented Apr 24, 2023

rushatgabhane commented Apr 25, 2023 • edited Loading

rushatgabhane commented Apr 25, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

ntdiary commented Apr 25, 2023

rushatgabhane commented Apr 26, 2023 • edited Loading

rushatgabhane Apr 26, 2023 • edited Loading

Choose a reason for hiding this comment

ntdiary Apr 26, 2023

Choose a reason for hiding this comment

rushatgabhane commented Apr 26, 2023 • edited Loading

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

tgolen left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 26, 2023

OSBotify commented Apr 27, 2023

OSBotify commented Apr 28, 2023

ntdiary commented Apr 21, 2023 •

edited

Loading

rushatgabhane commented Apr 25, 2023 •

edited

Loading

rushatgabhane commented Apr 25, 2023 •

edited

Loading

rushatgabhane commented Apr 26, 2023 •

edited

Loading

rushatgabhane Apr 26, 2023 •

edited

Loading

rushatgabhane commented Apr 26, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading