feat: Add vertical padding to context popover and call popover menu #17909

jayeshmangwani · 2023-04-24T19:46:51Z

Details

Fixed Issues

$ #17791
PROPOSAL: #17791 (comment)

Tests

Open App
Go to any chat
Right Click / Long Press on any message to open the context menu
Keep pressing the TAB key to navigate through the options
Verify a blue frame appears on each option
Verify the corners of the frame are not cut
Close the context menu
Press the call button from the chat header
Keep pressing the TAB key to navigate through the options
Verify a blue frame appears on each option
Verify the corners of the frame are not cut

Verify that no errors appear in the JS console

Offline tests

Same as above Tests

QA Steps

Same as above Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Android-Chrome.mp4

Mobile Web - Safari

iOS-safari.mov

Desktop

desktop.mov

iOS

iOS.mov

Android

Android.mov

MelvinBot · 2023-04-24T19:46:56Z

@stitesExpensify @s77rt One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/styles/getReportActionContextMenuStyles.js

s77rt · 2023-04-24T21:36:58Z

src/styles/getReportActionContextMenuStyles.js

-function getReportActionContextMenuStyles(isMini) {
-    return isMini ? miniWrapperStyle : bigWrapperStyle;
+function getReportActionContextMenuStyles(isMini, isSmallScreenWidth) {
+    return isMini ? miniWrapperStyle : [...bigWrapperStyle, !isSmallScreenWidth && styles.pv3];


Can you please add a comment explaining why the padding is not added for small screens

@s77rt Added comments, please check if these comments will work

src/styles/getReportActionContextMenuStyles.js

s77rt · 2023-04-25T07:31:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

jayeshmangwani · 2023-04-25T07:37:21Z

@s77rt this checkbox isn't selected I verified testing steps are clear and they cover the changes made in this PR, anything missing from my side ?

s77rt · 2023-04-25T07:37:29Z

src/styles/getReportActionContextMenuStyles.js

+    // Small screens use a bottom-docked modal that already has vertical padding.
+    return [...bigWrapperStyle, isSmallScreenWidth ? {} : styles.pv3];


Suggested change

// Small screens use a bottom-docked modal that already has vertical padding.

return [...bigWrapperStyle, isSmallScreenWidth ? {} : styles.pv3];

return [

...bigWrapperStyle,

// Small screens use a bottom-docked modal that already has vertical padding.

isSmallScreenWidth ? {} : styles.pv3,

];

Sorry 😅 I have another quick change. I think this is slightly better

@s77rt Updated

s77rt · 2023-04-25T07:49:26Z

@jayeshmangwani I have some suggestions on the tests. It's better not to specify if tests should be on staging or not, just use sentences like Open App. Login to NewDot, etc.

Can you please update the tests to:

Open App
Go to any chat
Right Click / Long Press on any message to open the context menu
Keep pressing the TAB key to navigate through the options
Verify a blue frame appears on each option
Verify the corners of the frame are not cut
Close the context menu
Press the call button from the chat header
Keep pressing the TAB key to navigate through the options
Verify a blue frame appears on each option
Verify the corners of the frame are not cut

jayeshmangwani · 2023-04-25T09:14:43Z

@s77rt Updated Tests Section

s77rt

LGTM! 🚀

cc @stitesExpensify

stitesExpensify

lgtm

OSBotify · 2023-04-25T15:03:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-26T06:34:46Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-27T04:49:49Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jayeshmangwani added 2 commits April 25, 2023 01:13

feat: added vertical space to video chat button

e86b22b

feat: added vertical space to Action Context Menu

0705b0c

jayeshmangwani requested a review from a team as a code owner April 24, 2023 19:46

melvin-bot bot requested review from s77rt and stitesExpensify and removed request for a team April 24, 2023 19:46

jayeshmangwani mentioned this pull request Apr 24, 2023

[HOLD for payment 2023-05-04] [$1000] Web - Chat - The frame is cut off if you use "Tab" key with message options #17791

Closed

6 tasks

jayeshmangwani changed the title ~~Context popover vertical padding~~ feat: Add vertical padding to context popover and call popover menu Apr 24, 2023

s77rt suggested changes Apr 24, 2023

View reviewed changes

jayeshmangwani added 2 commits April 25, 2023 10:21

Merge branch 'main' into context_popover_vertical_padding

33dd87e

fix: added comments to menu style, removed boolean styles

a20dc3d

s77rt suggested changes Apr 25, 2023

View reviewed changes

src/styles/getReportActionContextMenuStyles.js Outdated Show resolved Hide resolved

jayeshmangwani added 2 commits April 25, 2023 12:53

Merge branch 'main' into context_popover_vertical_padding

59aa23a

fix: replaced ternary with if condition

839673a

s77rt suggested changes Apr 25, 2023

View reviewed changes

fix: fomatted conditional styling

9631688

s77rt approved these changes Apr 25, 2023

View reviewed changes

stitesExpensify approved these changes Apr 25, 2023

View reviewed changes

stitesExpensify merged commit f18e6e9 into Expensify:main Apr 25, 2023

OSBotify mentioned this pull request Apr 26, 2023

Deploy Checklist: New Expensify 2023-04-26 #18017

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add vertical padding to context popover and call popover menu #17909

feat: Add vertical padding to context popover and call popover menu #17909

jayeshmangwani commented Apr 24, 2023 •

edited

Loading

MelvinBot commented Apr 24, 2023

s77rt Apr 24, 2023

jayeshmangwani Apr 25, 2023

s77rt commented Apr 25, 2023 •

edited

Loading

jayeshmangwani commented Apr 25, 2023

s77rt Apr 25, 2023

jayeshmangwani Apr 25, 2023

s77rt commented Apr 25, 2023

jayeshmangwani commented Apr 25, 2023

s77rt left a comment

stitesExpensify left a comment

OSBotify commented Apr 25, 2023

OSBotify commented Apr 26, 2023

OSBotify commented Apr 27, 2023

		// Small screens use a bottom-docked modal that already has vertical padding.
		return [...bigWrapperStyle, isSmallScreenWidth ? {} : styles.pv3];

feat: Add vertical padding to context popover and call popover menu #17909

feat: Add vertical padding to context popover and call popover menu #17909

Conversation

jayeshmangwani commented Apr 24, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 24, 2023

s77rt Apr 24, 2023

Choose a reason for hiding this comment

jayeshmangwani Apr 25, 2023

Choose a reason for hiding this comment

s77rt commented Apr 25, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jayeshmangwani commented Apr 25, 2023

s77rt Apr 25, 2023

Choose a reason for hiding this comment

jayeshmangwani Apr 25, 2023

Choose a reason for hiding this comment

s77rt commented Apr 25, 2023

jayeshmangwani commented Apr 25, 2023

s77rt left a comment

Choose a reason for hiding this comment

stitesExpensify left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 25, 2023

OSBotify commented Apr 26, 2023

OSBotify commented Apr 27, 2023

jayeshmangwani commented Apr 24, 2023 •

edited

Loading

s77rt commented Apr 25, 2023 •

edited

Loading