-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run CLA workflow twice #1808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done or remove the |
Just testing GH Actions, no need to wait for iOS E2E tests to finish. |
Details
This PR fixes a side effect of #1802 (comment) where the CLA workflow runs on master twice. Since we already have this workflow running on
pull_request_target
, we should be able to exclude it from running on master forpull_request
actionsTests
Created this PR, confirmed the CLA workflow only ran once on
pull_request_target