Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run CLA workflow twice #1808

Merged
merged 5 commits into from
Mar 17, 2021
Merged

Don't run CLA workflow twice #1808

merged 5 commits into from
Mar 17, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Mar 16, 2021

Details

This PR fixes a side effect of #1802 (comment) where the CLA workflow runs on master twice. Since we already have this workflow running on pull_request_target, we should be able to exclude it from running on master for pull_request actions

Tests

Created this PR, confirmed the CLA workflow only ran once on pull_request_target
image

@Jag96 Jag96 requested a review from roryabraham March 16, 2021 23:12
@Jag96 Jag96 self-assigned this Mar 16, 2021
@Jag96 Jag96 requested a review from a team as a code owner March 16, 2021 23:12
@botify botify requested review from pecanoro and removed request for a team March 16, 2021 23:13
roryabraham
roryabraham previously approved these changes Mar 16, 2021
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roryabraham roryabraham merged commit ec90183 into master Mar 17, 2021
@roryabraham roryabraham deleted the joe-prevent-duplicate-cla branch March 17, 2021 01:16
@botify
Copy link

botify commented Mar 17, 2021

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
@roryabraham
Copy link
Contributor

Just testing GH Actions, no need to wait for iOS E2E tests to finish.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants