Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Create Money Request Header component #18148
[No QA] Create Money Request Header component #18148
Changes from 17 commits
9a02fcc
6832775
2d52d92
48e99fd
8873246
b31c2d1
f6d9b4b
e7ff900
1867b7e
c59467c
9caca42
04e5b45
854de26
a4a9226
240871a
e58f154
b6f5732
938d002
413a867
036d9e9
89c919a
ead5b8c
acf1257
7d53670
eadd538
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB but if these are only used when
shouldShowAvatarWithDisplay
istrue
then maybe that's a case for having a completely separate componentHeaderWithCloseButtonAndAvavtar
or something like that 🤷.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use MenuItem instead of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have bigger plans for this component so I think we wanted the flexibility. cc @mountiny and @luacmartins who had a bigger hand in the high level design of this.