Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy PR to retest deploys #1817

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Dummy PR to retest deploys #1817

merged 2 commits into from
Mar 17, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Mar 17, 2021

We forgot to push tags before last test, which caused this workflow to fail.

@roryabraham roryabraham requested a review from Jag96 March 17, 2021 01:57
@roryabraham roryabraham self-assigned this Mar 17, 2021
@roryabraham roryabraham requested a review from a team as a code owner March 17, 2021 01:57
@botify botify requested review from madmax330 and removed request for a team March 17, 2021 01:57
@Jag96
Copy link
Contributor

Jag96 commented Mar 17, 2021

More deploy workflow testing so skipping e2e tests

@Jag96 Jag96 merged commit 23ef4c3 into master Mar 17, 2021
@Jag96 Jag96 deleted the Rory-RetestDeploy branch March 17, 2021 01:59
@botify
Copy link

botify commented Mar 17, 2021

@Jag96 looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@Jag96 Jag96 removed the Emergency label Mar 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
@roryabraham
Copy link
Contributor Author

@roryabraham
Copy link
Contributor Author

staging PR was not automerged because CLA was not skipped

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants