Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix: Copying the messages and marking a message in between as unread generates 'new' in the text" #18380

Merged
merged 1 commit into from
May 3, 2023
Merged

Revert "Fix: Copying the messages and marking a message in between as unread generates 'new' in the text" #18380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/components/UnreadActionIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@ import Text from './Text';
import withLocalize, {withLocalizePropTypes} from './withLocalize';

const UnreadActionIndicator = props => (
<View
accessibilityLabel={props.translate('accessibilityHints.newMessageLineIndicator')}
data-action-id={props.reportActionID}
style={[styles.unreadIndicatorContainer, styles.userSelectNone]}
>
<View accessibilityLabel={props.translate('accessibilityHints.newMessageLineIndicator')} data-action-id={props.reportActionID} style={styles.unreadIndicatorContainer}>
<View style={styles.unreadIndicatorLine} />
<Text style={styles.unreadIndicatorText}>
{props.translate('common.new')}
Expand Down
4 changes: 0 additions & 4 deletions src/libs/SelectionScraper/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import render from 'dom-serializer';
import {parseDocument} from 'htmlparser2';
import _ from 'underscore';
import Str from 'expensify-common/lib/str';
import styles from '../../styles/styles';

const elementsWillBeSkipped = ['html', 'body'];
const tagAttribute = 'data-testid';
Expand Down Expand Up @@ -81,9 +80,6 @@ const getHTMLOfSelection = () => {
}
}

// Remove any element that isn't selectable to prevent copying unnecessary text/items
div.querySelectorAll(`div[style*="user-select: ${styles.userSelectNone.WebkitUserSelect}"]`).forEach(item => item.remove());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. This does not look like React Native to me 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcaaron There are a couple of of other places where DOM-related methods are used inside SelectionScraper such as div.appendChild() and closest(), and this is what inspired my solution.

App/src/libs/SelectionScraper/index.js

Line 79 in c7a8a88

div.appendChild(child);

App/src/libs/SelectionScraper/index.js

Line 24 in c7a8a88

const div = document.createElement('div');

I'm the original PR's author, and I'm currently investigating this unintended behavior.


return div.innerHTML;
};

Expand Down