-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change LHN header to Expensify #18449
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b548a3e
change LHN header to Expensify
bondydaa 3b461e2
update the header component so it can accept react components (or any…
bondydaa 735725c
import the wordmark logo and render it in the header
bondydaa 5a5b4d7
fix style
bondydaa 1fa9eed
create new component for imageheader to properly use children to rend…
bondydaa fc93302
remove unused props
bondydaa 0bc7607
removing unneeded string
bondydaa 398546c
remove unnecessary new component since we have a wordmark that we can…
bondydaa 6be4be4
remove in-svg styles so we can modify them via props
bondydaa 9968ab7
update the wordmark component to accept more customization so it can …
bondydaa 8a14e2e
fix typo
bondydaa 4843a61
update usage of wordmark component based on new api
bondydaa c7acacd
Merge branch 'main' of github.com:Expensify/App into bondy-rename-lhn
bondydaa 8920c49
linter fixes
bondydaa 64de69b
fixing proptypes b/c linter complains
bondydaa 2d1eb9b
remove the unneeded badge component from header component
bondydaa 8d25d70
include const lib
bondydaa b4aee41
remove unneeded import
bondydaa 24c3259
linter be damned this is what works
bondydaa d1596bc
Merge branch 'main' of github.com:Expensify/App into bondy-rename-lhn
bondydaa a29631b
import style props to appease linter
bondydaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,8 @@ import OfflineIndicator from '../../../components/OfflineIndicator'; | |
import SignInHeroImage from '../SignInHeroImage'; | ||
import * as StyleUtils from '../../../styles/StyleUtils'; | ||
import variables from '../../../styles/variables'; | ||
import withEnvironment, {environmentPropTypes} from '../../../components/withEnvironment'; | ||
import CONST from '../../../CONST'; | ||
|
||
const propTypes = { | ||
/** The children to show inside the layout */ | ||
|
@@ -34,6 +36,7 @@ const propTypes = { | |
|
||
...withLocalizePropTypes, | ||
...windowDimensionsPropTypes, | ||
...environmentPropTypes, | ||
}; | ||
|
||
const SignInPageContent = props => ( | ||
|
@@ -49,7 +52,9 @@ const SignInPageContent = props => ( | |
<View style={[styles.flexGrow2, styles.mb8]}> | ||
<SignInPageForm style={[styles.alignSelfStretch]}> | ||
<View style={[props.isSmallScreenWidth ? styles.mb8 : styles.mb15, props.isSmallScreenWidth ? styles.alignItemsCenter : styles.alignSelfStart]}> | ||
<ExpensifyWordmark /> | ||
<ExpensifyWordmark | ||
containerStyles={[(props.isSmallScreenWidth && (props.environment === CONST.ENVIRONMENT.DEV || props.environment === CONST.ENVIRONMENT.STAGING)) ? styles.ml3 : {}]} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Has a lint issue. Please wrap this in next lines. |
||
/> | ||
</View> | ||
<View style={[styles.signInPageWelcomeTextContainer]}> | ||
{(props.shouldShowWelcomeHeader && props.welcomeHeader) ? ( | ||
|
@@ -92,4 +97,5 @@ export default compose( | |
withWindowDimensions, | ||
withLocalize, | ||
withSafeAreaInsets, | ||
withEnvironment, | ||
)(SignInPageContent); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
flexRow
andflex1
to fix the search icon.