-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show loader in Connect Account page #18574
Conversation
when props.reimbursementAccount loading is yet to start, or when user data is being loaded
@aldo-expensify @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-05-09.at.19.53.28.movMobile Web - ChromeScreen_Recording_20230509-201922_Chrome.mp4Mobile Web - SafariIMG_0046.MP4DesktopScreen.Recording.2023-05-09.at.19.57.54.moviOSScreen.Recording.2023-05-09.at.20.01.05.movAndroidScreen_Recording_20230509-201434_New.Expensify.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me! Thanks for a very clean and well commented PR!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.13-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.13-5 🚀
|
@eVoloshchak @aldo-expensify this PR is ready for review.
Note that the issue reported is not affecting native apps, but I have included videos showing identical user journey flow for the native apps for completeness and also to verify there is no issue in Native apps.
Details
Display loading indicator in Connect bank account page when data loading is yet to start, or when user data is being loaded
Fixed Issues
$ #18156
PROPOSAL: #18156 (comment)
Tests
Applicable for desktop, web and mobile web only.
Note: Android and IOS Native app has a different behaviour where if app cache is cleared when user is on "Connect bank account page" by using React Native debugger menu, re-login will open the app in Chat list instead of "Connect bank account page", however that should be fine as real users should not be able to clear cache this way.
Offline tests
N/A
QA Steps
Applicable for desktop, web and mobile web only.
Note: Android and IOS Native app has a different behaviour where if app cache is cleared when user is on "Connect bank account page" by using React Native debugger menu, re-login will open the app in Chat list instead of "Connect bank account page", however that should be fine as real users should not be able to clear cache this way.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-05-07.at.5.10.38.PM.mov
Mobile Web - Chrome
Screen.Recording.2023-05-08.at.4.16.31.PM.mov
Mobile Web - Safari
Screen.Recording.2023-05-08.at.3.53.37.PM.mov
Desktop
Screen.Recording.2023-05-08.at.3.07.55.PM.mov
iOS
18156-ios.mov
Android
Screen.Recording.2023-05-08.at.4.36.00.PM.mov