Fix: Auto focus on mWeb when open report with enough chat history #18699

dukenv0307 · 2023-05-10T04:00:44Z

Details

The cursor absent in the chat input field

Fixed Issues

$ #17187
PROPOSAL: #17187 (comment)

Tests

Login with any account
Open a empty chat
Verify that input field is focused on all platforms and the keyboard is shown on mweb and native.
Open a chat that has history chat
Verify that the input field is not focused on mweb and native and is focused on the others

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Login with any account
Open a empty chat
Verify that input field is focused on all platforms and the keyboard is shown on mweb and native.
Open a chat that has history chat
Verify that the input field is not focused on mweb and native and is focused on the others
Run all tests of Fix mWeb Compose Focus bug #14230

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.10-05-2023.11.06.07.webm

Mobile Web - Chrome

Record_2023-05-10-11-07-51.mp4

Mobile Web - Safari

original-5DFFE1FB-23BE-4212-9720-E22D8EB736EE.1.mp4

Desktop

Screen.Recording.2023-05-10.at.17.05.27.mov

iOS

Screen.Recording.2023-05-10.at.17.22.45.mov

Android

17187.mp4

melvin-bot · 2023-05-10T04:30:55Z

@flodnv @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-05-11T03:56:16Z

@0xmiroslav Bump, could you help to check this PR

0xmiros · 2023-05-11T04:08:37Z

reviewing now

@dukenv0307 please pull from main

…t-field

dukenv0307 · 2023-05-11T04:16:05Z

@0xmiroslav Updated.

0xmiros · 2023-05-11T04:30:30Z

@dukenv0307 I understand it's known issue that focus not working well on mSafari but still you should add screenshot.

0xmiros · 2023-05-11T04:33:11Z

Fix: The cursor absent in the chat input field

And the title is wrong.
The purpose of this PR is to prevent auto focus on mWeb when open report with enough chat history

dukenv0307 · 2023-05-11T04:37:15Z

@dukenv0307 I understand it's known issue that focus not working well on mSafari but still you should add screenshot.

I created a screenshot but I forgot to update it in comment. I just updated, please check again

0xmiros · 2023-05-11T04:40:00Z

Desktop, iOS, Android screenshots are part of mSafari. please fix

dukenv0307 · 2023-05-11T04:42:46Z

@0xmiroslav I fixed it.

0xmiros · 2023-05-11T04:46:36Z

src/pages/home/report/ReportActionCompose.js

@@ -197,9 +198,10 @@ class ReportActionCompose extends React.Component {
        // React Native will retain focus on an input for native devices but web/mWeb behave differently so we have some focus management
        // code that will refocus the compose input after a user closes a modal or some other actions, see usage of ReportActionComposeFocusManager
        this.willBlurTextInputOnTapOutside = willBlurTextInputOnTapOutside();
+        this.shouldFocusInputOnScreenFocus = canFocusInputOnScreenFocus();


Let's add comment what's this for, similar to willBlurTextInputOnTapOutside comment

@0xmiroslav I just updated.

We want consistent auto focus behavior on input between native and mWeb so we have some auto focus management code that will prevent auto focus on existing chat for mobile devices

@0xmiroslav Thanks for suggestion, I updated.

src/pages/home/report/ReportActionCompose.js

0xmiros · 2023-05-11T06:33:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

There are still inconsistency issues on autofocus behavior:

when re-open same chat previously opened, auto focus never works
when open empty chat, auto focus sometimes doesn't work

This is will be improved after navigation refactor which swaps drawer for stack navigator, so out of scope.
The main purpose of this PR is just to prevent auto focus on existing chat on mobile devices

Co-authored-by: Miroslav Stevanovic <97473779+0xmiroslav@users.noreply.github.com>

0xmiros

LGTM!
All yours @flodnv

flodnv

Thanks! Can you also please do all the same tests as what we did in #14230? 🙇

0xmiros · 2023-05-11T15:00:40Z

I did full test in #14230 and work as expected. Especially:

Click to send money, on the modal that appears click the x to dismiss it.

(Existing Behavior) On Web/mWeb/Desktop focus should be given back to the compose input. On Android / iOS focus should not be given back to the compose input. One could argue that these behaviors should be the same and they would be right but this functionality was previously coded this way. We are going to fix it in a future issue.

flodnv · 2023-05-11T17:28:04Z

Excellent, thanks!

OSBotify · 2023-05-11T17:34:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-15T09:20:26Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-17T00:20:16Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix the cursor absent in the chat input field

7edb444

dukenv0307 marked this pull request as ready for review May 10, 2023 04:30

dukenv0307 requested a review from a team as a code owner May 10, 2023 04:30

melvin-bot bot requested review from 0xmiros and flodnv and removed request for a team May 10, 2023 04:30

Merge branch 'main' into fix/17187-the-cursor-absent-in-the-chat-inpu…

01055eb

…t-field

dukenv0307 changed the title ~~Fix: The cursor absent in the chat input field~~ Fix: Auto focus on mWeb when open report with enough chat history May 11, 2023

0xmiros reviewed May 11, 2023

View reviewed changes

dukenv0307 and others added 3 commits May 11, 2023 12:08

add description for shouldFocusInputOnScreenFocus

8768a82

Update ReportActionCompose.js

e746460

update description

0c99672

0xmiros reviewed May 11, 2023

View reviewed changes

src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved

Update src/pages/home/report/ReportActionCompose.js

0a26b43

Co-authored-by: Miroslav Stevanovic <97473779+0xmiroslav@users.noreply.github.com>

0xmiros approved these changes May 11, 2023

View reviewed changes

flodnv reviewed May 11, 2023

View reviewed changes

flodnv approved these changes May 11, 2023

View reviewed changes

flodnv merged commit 057417c into Expensify:main May 11, 2023

OSBotify mentioned this pull request May 15, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

melvin-bot bot mentioned this pull request May 16, 2023

[HOLD for payment 2023-05-23] [$1000] Chat - The cursor absent in the chat input field #17187

Closed

6 tasks

situchan mentioned this pull request Jul 4, 2023

[HOLD for payment 2023-07-24] [$1000] The new emoji search field focus inconsistent between mweb chrome and web chrome #20979

Closed

6 tasks

DylanDylann mentioned this pull request Sep 12, 2024

fix: 10731 Focus composer without showing keyboard when users go to chats #32711

Merged

56 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Auto focus on mWeb when open report with enough chat history #18699

Fix: Auto focus on mWeb when open report with enough chat history #18699

dukenv0307 commented May 10, 2023 •

edited by flodnv

Loading

melvin-bot bot commented May 10, 2023

dukenv0307 commented May 11, 2023

0xmiros commented May 11, 2023

dukenv0307 commented May 11, 2023

0xmiros commented May 11, 2023

0xmiros commented May 11, 2023

dukenv0307 commented May 11, 2023

0xmiros commented May 11, 2023

dukenv0307 commented May 11, 2023

0xmiros May 11, 2023

dukenv0307 May 11, 2023

0xmiros May 11, 2023

dukenv0307 May 11, 2023

0xmiros commented May 11, 2023

0xmiros left a comment

flodnv left a comment

0xmiros commented May 11, 2023

flodnv commented May 11, 2023

OSBotify commented May 11, 2023

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

Fix: Auto focus on mWeb when open report with enough chat history #18699

Fix: Auto focus on mWeb when open report with enough chat history #18699

Conversation

dukenv0307 commented May 10, 2023 • edited by flodnv Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 10, 2023

dukenv0307 commented May 11, 2023

0xmiros commented May 11, 2023

dukenv0307 commented May 11, 2023

0xmiros commented May 11, 2023

0xmiros commented May 11, 2023

dukenv0307 commented May 11, 2023

0xmiros commented May 11, 2023

dukenv0307 commented May 11, 2023

0xmiros May 11, 2023

Choose a reason for hiding this comment

dukenv0307 May 11, 2023

Choose a reason for hiding this comment

0xmiros May 11, 2023

Choose a reason for hiding this comment

dukenv0307 May 11, 2023

Choose a reason for hiding this comment

0xmiros commented May 11, 2023

Reviewer Checklist

Screenshots/Videos

0xmiros left a comment

Choose a reason for hiding this comment

flodnv left a comment

Choose a reason for hiding this comment

0xmiros commented May 11, 2023

flodnv commented May 11, 2023

OSBotify commented May 11, 2023

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

dukenv0307 commented May 10, 2023 •

edited by flodnv

Loading