[Manual Requests] Create thread for Manual Request when opening IOUPreview #18760

bondydaa · 2023-05-11T00:48:44Z

Details

This will create a thread for a Manual Request if one does not exist yet when a user click to open a Manual Request.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/278887
$ https://github.com/Expensify/Expensify/issues/270591

Tests

Verify that no errors appear in the JS console

As userA create a chat with userB
Request money from userB - $10 for lunch
Click on the IOUPreview
Make sure you have been navigated to a new chat report
Verify you got a new report in LHN with title: $10 request for lunch
Send a message in this report
As userB verify you got this report in your LHN
Got to the DM with UserA as userB
Verify the IOUPreview has replies UI underneath like so

Click on the IOUPreview for the $10 request
Verify you are navigated to the same thread created after UserA sent a message in step 6

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

Cant sign in on mWeb android locally for some reason, dont want to hold on this though tried to figure out but its happening on main too

Mobile Web - Safari

iosweb.mov

Desktop

web.mp4

iOS

ios.mp4

Android

android.mp4

src/libs/ReportUtils.js

src/components/ReportActionItem/IOUAction.js

…e a thread

bondydaa · 2023-05-12T05:13:16Z

Okay getting closer. I've got the optimistic report stuff done, via the logs I (accidentally) committed you can see the object has the proper data

But I need to look closer at what's happening when that gets to the API and Auth b/c right now when I look up the report in the db for this it's not right:

sqlite> select * from reports where reportid=5450562980361980;
   created = 2023-05-12 05:07:27
 submitted =
  approved =
  reportID = 5450562980361980
 accountID = 0
 managerID =
reportName = Chat Report
     state = 0
     total = 0
  currency = USD
cachedData =
    status = 0

that good news 🎉 is that the rNVP is being created properly :success:

sqlite> select * from reportNameValuePairs where value=3983353111135864060;
reportID = 5450562980361980
    name = parentReportActionID
   value = 3983353111135864060

luacmartins

Looking good. Just a few minor comments.

src/components/ReportActionItem/MoneyRequestAction.js

luacmartins · 2023-05-12T08:46:55Z

src/components/ReportActionItem/MoneyRequestAction.js

+            console.log({optimisticThreadReport});
+            Report.openReport(
+                optimisticThreadReport.reportID,
+                [_.reject(optimisticThreadReport.participants, (login) => login === lodashGet(props.session, 'email', ''))],


Should this be the same as props.chatReport.participants?

I wasn't 100% sure since the API param for participants says it shouldn't include the user making the request: https://github.com/Expensify/Web-Expensify/blob/335001f0f64bf449fc884456ef1911cd1e6f17d5/lib/ReportAPI.php#L4404-L4405

okay asked about this here https://expensify.slack.com/archives/C02HWMSMZEC/p1683912289696679?thread_ts=1683911072.385549&cid=C02HWMSMZEC

And looks like it doesn't really matter if we include the user making the request here because in Auth here we make sure to include them and since set doesn't allow duplicates we are fine https://github.com/Expensify/Auth/blob/dbd779f7c423a82d4871d6dc076ecb37406fb43c/auth/command/OpenReport.cpp#L77

src/languages/en.js

src/libs/ReportUtils.js

…ual-requests

…will do this for us

src/languages/en.js

bondydaa · 2023-05-12T19:04:44Z

Okay I addressed all the comments but for some reason I'm still unsure why the optimistic report object that is being passed to OpenReport isn't leading to the data in the DB being set properly.

sqlite> select * from reports where reportid=2326627911912510;
   created = 2023-05-12 18:52:46
 submitted =
  approved =
  reportID = 2326627911912510
 accountID = 0
 managerID =
reportName = Chat Report
     state = 0
     total = 0
  currency = USD
cachedData =
    status = 0

The thread does get created though which is our main goal here

sqlite> select * from reportNameValuePairs where value=3983353111135864060;
reportID = 2326627911912510
    name = parentReportActionID
   value = 3983353111135864060

when testing this I've had to manually delete the data from the DB and also out of the localDB by searching report_[reportID] and clicking delete otherwise the front end still thinks a thread already exists.

I have to sign off for now so if someone can take this over that would be great. I don't expect to be online Monday but if I am able to then I'll let people know.

bondydaa · 2023-05-12T19:33:15Z

src/components/ReportActionItem/MoneyRequestAction.js

+            );
+            console.log({optimisticThreadReport});
+            Report.openReport(optimisticThreadReport.reportID, optimisticThreadReport.participants, optimisticThreadReport);
+        }
        if (hasMultipleParticipants) {
            Navigation.navigate(ROUTES.getReportParticipantsRoute(props.chatReportID));


Note that I think in order to get the newly created thread to show up we'll need to have something like GetChats triggered OR navigate to the report here in this section.

@Julesssss and @luacmartins had mentioned that this might be in the works else where as well but I'm not sure of a GH or anything for it.

If nothing changes here with these routes then the modal will continue to open instead of going to the thread.

…equests

…le reports

luacmartins

Looking good! We'll also need to update the thread report to display the MoneyRequestHeader component

luacmartins · 2023-05-15T16:30:50Z

src/components/ReportActionItem/MoneyRequestAction.js

+            const participants = _.uniq([props.session.email, props.action.actorEmail]);
+            const formattedUserLogins = _.map(participants, (login) => OptionsListUtils.addSMSDomainIfPhoneNumber(login).toLowerCase());
+            const thread = ReportUtils.buildOptimisticChatReport(
+                formattedUserLogins,
+                props.translate('iou.threadReportName', {
+                    formattedAmount: CurrencyUtils.convertToDisplayString(lodashGet(props.action, 'originalMessage.amount', 0), lodashGet(props.action, 'originalMessage.currency', '')),
+                    comment: props.action.originalMessage.comment,
+                }),
+                '',
+                CONST.POLICY.OWNER_EMAIL_FAKE,
+                CONST.POLICY.OWNER_EMAIL_FAKE,
+                false,
+                '',
+                undefined,
+                CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
+                props.action.reportActionID,
+                props.chatReportID, // Needs to be changed to iouReportID
+            );


Yea, we should create an utils method. Seems ok to leave it for now given that this is blocking other issues

luacmartins · 2023-05-15T16:32:25Z

src/components/ReportActionItem/MoneyRequestAction.js

+        // If the childReportID is not present, we need to create a new thread
+        const childReportID = lodashGet(props.action, 'childReportID', '0');
+        if (childReportID === '0') {
+            const participants = _.uniq([props.session.email, props.action.actorEmail]);


Can we just filter those out?

mountiny · 2023-05-15T16:59:21Z

@fedirjh can you try on a fresh account? with all these fast changes there might be something stale :/

fedirjh · 2023-05-15T17:13:40Z

@mountiny hmm on staging this is working well. Seems like using the staging server locally fix it. Updating the PR checklist shorlty

mountiny · 2023-05-15T17:30:17Z

Lovely, thanks!

trjExpensify · 2023-05-15T17:35:16Z

Wahoo, thanks a lot @fedirjh! ❤️ We're hoping to get this one merged today to unblock a couple of other PRs for EC3. 🙏

fedirjh · 2023-05-15T18:01:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Desktop.mov

Mobile Web - Chrome

Screen.Recording.2023-05-15.at.6.25.12.PM.mov

Offline

Screen.Recording.2023-05-15.at.6.58.45.PM.mov

Mobile Web - Safari

Desktop

Screen.Recording.2023-05-15.at.6.18.46.PM.mov

iOS

IOS.mov

Android

Screen.Recording.2023-05-15.at.6.49.55.PM.mov

fedirjh

LGTM and tests well.

melvin-bot · 2023-05-15T18:02:57Z

🎯 @fedirjh, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #18964.

mountiny · 2023-05-15T18:19:53Z

@fedirjh thank you!

@luacmartins lets merge this and handle the rest in follow up PRs.

luacmartins

LGTM! As discussed, we need a followup to use the right report header for transaction threads

[Manual Requests] Create thread for Manual Request when opening IOUPreview (cherry picked from commit b744bd3)

…-18760 🍒 Cherry pick PR #18760 to staging 🍒

OSBotify · 2023-05-15T19:55:27Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-17T00:18:16Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:30:09Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:47:57Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

situchan · 2023-08-30T10:02:56Z

src/components/ReportActionItem/MoneyRequestAction.js

+                    comment: props.action.originalMessage.comment,
+                }),
+                '',
+                CONST.POLICY.OWNER_EMAIL_FAKE,


Coming from IOU - Workspace avatar shows 'U' avatar before reverting to actual avatar in IOU view:
We could use real policyID from iouReport to avoid flickering in offline mode.

lodashGet(props.iouReport, 'policyID', CONST.POLICY.OWNER_EMAIL_FAKE)

bondydaa added 2 commits May 10, 2023 18:46

create method to find if a thread exists or not

202122a

add rough sketch of what needs to happen to create a thread on demand

fa1b3dc

bondydaa requested a review from luacmartins May 11, 2023 00:48

bondydaa self-assigned this May 11, 2023

Julesssss reviewed May 11, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

Julesssss reviewed May 11, 2023

View reviewed changes

src/components/ReportActionItem/IOUAction.js Outdated Show resolved Hide resolved

bondydaa added 4 commits May 11, 2023 20:41

fixing merge conflict

e30b603

rename method and update to return the report object for a thread

a5e043e

allow the passing of a parentReportActionID so we can create threads

94c9125

generate report optimistically and pass parentReportActionID to creat…

94c19d6

…e a thread

luacmartins reviewed May 12, 2023

View reviewed changes

bondydaa added 6 commits May 12, 2023 11:13

Merge branch 'main' of github.com:Expensify/App into bondy-thread-man…

b2c926f

…ual-requests

appease linter

6e3bf2c

appease linter and import full lib

b4a991b

we dont need to prefilter the user making the request out since auth …

c0e2430

…will do this for us

use amount not payee in report name

4cfefbb

fixing jsdocs and comment

9d518ba

bondydaa commented May 12, 2023

View reviewed changes

src/languages/en.js Show resolved Hide resolved

use proper prop

f83e240

bondydaa commented May 12, 2023

View reviewed changes

mountiny self-assigned this May 13, 2023

mountiny added 7 commits May 13, 2023 23:39

Merge main and resolve conflicts

03f8c6f

Fix linter

dfc4e79

Merge branch 'main' into bondy-thread-manual-requests

33afd33

Merge branch 'vit-ensureDeleteShowsAsText' into bondy-thread-manual-r…

6e6eb06

…equests

Ensure threads are created optimistically

35c3c79

Add the childReportID to the report action so we do not create multip…

22f9a4a

…le reports

Merge branch 'main' into bondy-thread-manual-requests

bcb6855

This comment was marked as resolved.

Sign in to view

luacmartins reviewed May 15, 2023

View reviewed changes

Merge branch 'main' into bondy-thread-manual-requests

e800564

fedirjh approved these changes May 15, 2023

View reviewed changes

melvin-bot bot mentioned this pull request May 15, 2023

Payment issue for E/App PR#18760 #18964

Closed

mountiny requested a review from luacmartins May 15, 2023 18:19

luacmartins approved these changes May 15, 2023

View reviewed changes

luacmartins merged commit b744bd3 into main May 15, 2023

luacmartins deleted the bondy-thread-manual-requests branch May 15, 2023 18:27

OSBotify pushed a commit that referenced this pull request May 15, 2023

Merge pull request #18760 from Expensify/bondy-thread-manual-requests

0f2dcb8

[Manual Requests] Create thread for Manual Request when opening IOUPreview (cherry picked from commit b744bd3)

OSBotify mentioned this pull request May 15, 2023

🍒 Cherry pick PR #18760 to staging 🍒 #18966

Merged

OSBotify added a commit that referenced this pull request May 15, 2023

Merge pull request #18966 from Expensify/OSBotify-cherry-pick-staging…

aafcd84

…-18760 🍒 Cherry pick PR #18760 to staging 🍒

OSBotify mentioned this pull request May 15, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

kbecciv mentioned this pull request May 16, 2023

LHN - Each tap on IOU preview creates a new chat in LHN #19082

Closed

6 tasks

OSBotify mentioned this pull request May 17, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

situchan reviewed Aug 30, 2023

View reviewed changes

situchan mentioned this pull request Aug 30, 2023

[HOLD for payment 2023-08-28] [$1000] IOU - Workspace avatar shows 'U' avatar before reverting to actual avatar in IOU view #24325

Closed

6 tasks

situchan mentioned this pull request Mar 3, 2024

fix: Set childReportID of the optimistic IOU report action #37232

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Manual Requests] Create thread for Manual Request when opening IOUPreview #18760

[Manual Requests] Create thread for Manual Request when opening IOUPreview #18760

bondydaa commented May 11, 2023 •

edited by mountiny

Loading

bondydaa commented May 12, 2023

luacmartins left a comment

luacmartins May 12, 2023

bondydaa May 12, 2023

bondydaa May 12, 2023

bondydaa commented May 12, 2023

bondydaa May 12, 2023

This comment was marked as resolved.

luacmartins left a comment

luacmartins May 15, 2023

luacmartins May 15, 2023

mountiny commented May 15, 2023

fedirjh commented May 15, 2023

mountiny commented May 15, 2023

trjExpensify commented May 15, 2023

fedirjh commented May 15, 2023

Offline

fedirjh left a comment

melvin-bot bot commented May 15, 2023

mountiny commented May 15, 2023

luacmartins left a comment

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

situchan Aug 30, 2023

[Manual Requests] Create thread for Manual Request when opening IOUPreview #18760

[Manual Requests] Create thread for Manual Request when opening IOUPreview #18760

Conversation

bondydaa commented May 11, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

bondydaa commented May 12, 2023

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins May 12, 2023

Choose a reason for hiding this comment

bondydaa May 12, 2023

Choose a reason for hiding this comment

bondydaa May 12, 2023

Choose a reason for hiding this comment

bondydaa commented May 12, 2023

bondydaa May 12, 2023

Choose a reason for hiding this comment

This comment was marked as resolved.

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins May 15, 2023

Choose a reason for hiding this comment

luacmartins May 15, 2023

Choose a reason for hiding this comment

mountiny commented May 15, 2023

fedirjh commented May 15, 2023

mountiny commented May 15, 2023

trjExpensify commented May 15, 2023

fedirjh commented May 15, 2023

Reviewer Checklist

Screenshots/Videos

Offline

fedirjh left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 15, 2023

mountiny commented May 15, 2023

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

situchan Aug 30, 2023

Choose a reason for hiding this comment

bondydaa commented May 11, 2023 •

edited by mountiny

Loading