Send `mostRecentReportActionLastModified` with `ReconnectApp` #18807

marcaaron · 2023-05-12T00:29:45Z

Related to: https://github.com/Expensify/Auth/pull/7902

Details

This is the final PR that will implement fast ReconnectApp by sending the mostRecentReportActionLastModified.

It is holding on:

All must be deployed to production before we merge this...

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/282035

Tests

Sign into the app
Verify the chats load correctly and OpenApp API call is functioning normally and loads the LHN correctly
In Chrome Dev Tools Network tab - Note how long the OpenApp API call takes and check the response to see how many reports are returned in onyxData update with a key of report_.
Go offline
On another account add a comment to a report the offline user would see
As the offline user go online
Check the API response of ReconnectApp and verify that there are many less reports (really should be just one unless there are pinned reports) returned and that the request is faster than OpenApp
Verify the report that they missed an update for is updated in the LHN
Go offline again
As the other user edit the last message from the chat
As the offline user go online again and verify that the chat updates with the edited content in the LHN
Repeat these tests, but instead of going offline and returning online do:
- Desktop - Quit the app and reopen it
- mWeb - Refresh the page
- Android/iOS - Kill the app and reopen it
- Android/iOS - Background the app and reopen it

Verify that no errors appear in the JS console

Offline tests

This is covered above as there are

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

This reverts commit ec5a796.

melvin-bot · 2023-06-16T17:26:57Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcaaron · 2023-06-16T17:27:28Z

Still holding on Web-E deploy, but ready for review and I will run through the testing on all platforms now.

marcaaron · 2023-06-16T17:28:14Z

Oh hmm @mananjadhav this won't be ready to test until the API is updated, but we can use some help after it is.

src/libs/ReportActionsUtils.js

mananjadhav · 2023-06-27T21:17:18Z

Yes I will. I can see some lint issues now?

marcaaron · 2023-06-27T23:33:12Z

Updated

mananjadhav

Filling up the checklist now.

melvin-bot · 2023-06-28T14:08:27Z

🎯 @mananjadhav, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #21797.

mananjadhav · 2023-06-28T14:09:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-reconnect-app_onsikUWX.mp4

Mobile Web - Chrome

mweb-chrome-reconnect-app_HojGqr0I.mp4

Mobile Web - Safari

mweb-safari-reconnect-app_2zHZbT9p.mp4

Desktop

desktop-reconnect-app.mov

iOS

ios-reconnect-app_G8vxZPkF.mp4

Android

android-reconnect-app_YnFg50do.mp4

@flodnv All yours. Took sometime to compress the video. But tests well.

🎀 👀 🎀 C+ reviewed

flodnv

Thanks!

flodnv · 2023-06-28T18:59:29Z

src/libs/HttpUtils.js

@@ -150,11 +136,9 @@ function cancelPendingRequests() {
    // We create a new instance because once `abort()` is called any future requests using the same controller would
    // automatically get rejected: https://dom.spec.whatwg.org/#abortcontroller-api-integration
    cancellationController = new AbortController();
-    cancelPendingReconnectAppRequest();


Can you clarify why you removed this?

More context here: #18807 (comment)

Lmk if you want to discuss further? I am going to cause a regression with this - but the original solution is a hack.

src/libs/actions/App.js

src/libs/actions/Timing.js

marcaaron · 2023-06-30T19:43:10Z

Updated.

flodnv · 2023-07-03T12:42:10Z

Conflicts 😞

flodnv · 2023-07-03T12:45:08Z

src/libs/SessionUtils.js

+/**
+ * @returns {boolean}
+ */
+function didUserLogInDuringSession() {


Looking at this again, would it make more sense / be better to have some other system, like "isOnyxDataEmpty"? Maybe not?

It's a good question since all sorts of data could be "empty" and any could be used to signify that we have not yet called OpenApp yet. On the one hand, it's a bit arbitrary, but on the other hand it is easy to reason about the "when" and "why" we would call OpenApp (post sign in) over ReconnectApp (all other times).

Looking whether Onyx data is entirely empty or not would present a new challenge. This gets pretty complicated, but the gist of it is that Onyx can initialize with various default states and when cleared we will reapply those default states. So, there really is no way for Onyx data to ever truly be "empty" as far as the App code is concerned.

Thanks for the explanation, makes sense 👍

marcaaron · 2023-07-04T00:17:30Z

Conflicts fixed and retested!

OSBotify · 2023-07-04T13:09:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-05T17:31:38Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-07-05T17:53:26Z

@marcaaron We will only be able to run Web and Desktop for console verification in Staging. Can you pls check mWeb/Native Apps internally?

marcaaron · 2023-07-05T18:29:44Z

@mvtglobally Of course, thanks for letting me know. I will look into it right now.

marcaaron · 2023-07-05T19:11:38Z

Just going to post requestID for the testing logs as I go through the various platforms (if anyone is curious). And grabbed a before/after timing for my marc@expensifail.com account to confirm the speed improvement.

iOS Safari: 7e21b64e4e15f4cc-HNL
iOS native: 7e21bc910faabc7b-HNL
Android Chrome: 7e21e3776ab6bc69-HNL
Android: 7e21e9107badf4d0-HNL

Profile ~~ {"total":2448,"cmd":"OpenApp"...

Profile ~~ {"total":1212,"cmd":"ReconnectApp"...

OSBotify · 2023-07-07T10:37:04Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

marcaaron added 7 commits May 10, 2023 13:32

method to get most recent blahblah

8ac9d8c

add getMostRecentReportActionLastModified()

72dcafc

Fix conflicts

8299384

Actually send the timestamp

3b680b0

Subscribe to correct key

e176806

fix conflict

ce9e668

Merge branch 'main' into marcaaron-addLastModified

b0c0aae

marcaaron self-assigned this May 19, 2023

marcaaron changed the title ~~Send mostRecentReportActionLastModified with ReconnectApp~~ [HOLD Auth/Web-E] Send mostRecentReportActionLastModified with ReconnectApp May 19, 2023

marcaaron added 11 commits May 19, 2023 12:09

Run prettier

32e19d0

Merge branch 'main' into marcaaron-addLastModified

c3bf45b

Merge branch 'main' into marcaaron-addLastModified

d875a91

check reports and policies

bb88c62

Merge branch 'main' into marcaaron-addLastModified

0619651

no app changes

ec5a796

Revert "no app changes"

79feeef

This reverts commit ec5a796.

revert stuff

e1ddfc2

revert more stuff

2ac3528

More

6adf6de

account for possible undefined report value

4df4678

marcaaron marked this pull request as ready for review June 16, 2023 17:26

marcaaron requested a review from a team as a code owner June 16, 2023 17:26

melvin-bot bot removed the request for review from a team June 16, 2023 17:26

melvin-bot bot requested a review from mananjadhav June 16, 2023 17:26

marcaaron requested a review from a team June 16, 2023 17:28

melvin-bot bot requested review from rushatgabhane and removed request for a team June 16, 2023 17:28

mananjadhav reviewed Jun 27, 2023

View reviewed changes

src/libs/ReportActionsUtils.js Outdated Show resolved Hide resolved

marcaaron added 2 commits June 27, 2023 13:21

Fix

c256bb4

Fix dependency cycle

0a83f50

mananjadhav approved these changes Jun 28, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Jun 28, 2023

[Pay 7/14] Payment issue for E/App PR#18807 #21797

Closed

flodnv reviewed Jun 28, 2023

View reviewed changes

marcaaron added 2 commits June 28, 2023 10:18

Merge branch 'main' into marcaaron-addLastModified

eaca434

Make requested changes

76f76ad

flodnv reviewed Jul 3, 2023

View reviewed changes

marcaaron added 2 commits July 3, 2023 12:02

Fix conflicts

41487c2

prettier

2341952

flodnv approved these changes Jul 4, 2023

View reviewed changes

flodnv merged commit c38a336 into main Jul 4, 2023

flodnv deleted the marcaaron-addLastModified branch July 4, 2023 13:05

OSBotify mentioned this pull request Jul 5, 2023

Deploy Checklist: New Expensify 2023-07-05 #22282

Closed

58 tasks

tienifr mentioned this pull request Jul 8, 2023

[$1000] Web - 'Notify me' option doesn't update on Unavailable workspace #21859

Closed

6 tasks

kbecciv mentioned this pull request Jul 17, 2023

[$500] Web - Remove member from workspace does not hide workspace's rooms on that member account when he's offline #23000

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send `mostRecentReportActionLastModified` with `ReconnectApp` #18807

Send `mostRecentReportActionLastModified` with `ReconnectApp` #18807

marcaaron commented May 12, 2023 •

edited

Loading

melvin-bot bot commented Jun 16, 2023

marcaaron commented Jun 16, 2023

marcaaron commented Jun 16, 2023

mananjadhav commented Jun 27, 2023

marcaaron commented Jun 27, 2023

mananjadhav left a comment

melvin-bot bot commented Jun 28, 2023

mananjadhav commented Jun 28, 2023 •

edited

Loading

flodnv left a comment

flodnv Jun 28, 2023

marcaaron Jun 28, 2023

marcaaron commented Jun 30, 2023

flodnv commented Jul 3, 2023

flodnv Jul 3, 2023

marcaaron Jul 3, 2023

flodnv Jul 4, 2023

marcaaron commented Jul 4, 2023

OSBotify commented Jul 4, 2023

OSBotify commented Jul 5, 2023

mvtglobally commented Jul 5, 2023

marcaaron commented Jul 5, 2023

marcaaron commented Jul 5, 2023

OSBotify commented Jul 7, 2023

Send mostRecentReportActionLastModified with ReconnectApp #18807

Send mostRecentReportActionLastModified with ReconnectApp #18807

Conversation

marcaaron commented May 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 16, 2023

marcaaron commented Jun 16, 2023

marcaaron commented Jun 16, 2023

mananjadhav commented Jun 27, 2023

marcaaron commented Jun 27, 2023

mananjadhav left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jun 28, 2023

mananjadhav commented Jun 28, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

flodnv left a comment

Choose a reason for hiding this comment

flodnv Jun 28, 2023

Choose a reason for hiding this comment

marcaaron Jun 28, 2023

Choose a reason for hiding this comment

marcaaron commented Jun 30, 2023

flodnv commented Jul 3, 2023

flodnv Jul 3, 2023

Choose a reason for hiding this comment

marcaaron Jul 3, 2023

Choose a reason for hiding this comment

flodnv Jul 4, 2023

Choose a reason for hiding this comment

marcaaron commented Jul 4, 2023

OSBotify commented Jul 4, 2023

OSBotify commented Jul 5, 2023

mvtglobally commented Jul 5, 2023

marcaaron commented Jul 5, 2023

marcaaron commented Jul 5, 2023

OSBotify commented Jul 7, 2023

Send `mostRecentReportActionLastModified` with `ReconnectApp` #18807

Send `mostRecentReportActionLastModified` with `ReconnectApp` #18807

marcaaron commented May 12, 2023 •

edited

Loading

mananjadhav commented Jun 28, 2023 •

edited

Loading