Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove button remains enabled when removing a user in other device #18934

Merged
merged 4 commits into from
May 15, 2023
Merged

Fix remove button remains enabled when removing a user in other device #18934

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
deaec05
Fix remove button remains enabled when removing a user in other device
dukenv0307 May 15, 2023
3cfd644
format code
dukenv0307 May 15, 2023
fbdc927
update check change
dukenv0307 May 15, 2023
20ae498
change method update selectedEmplyees
dukenv0307 May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/pages/workspace/WorkspaceMembersPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,12 @@ class WorkspaceMembersPage extends React.Component {
this.validate();
}

if (prevProps.policyMemberList !== this.props.policyMemberList) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure policyMemberList is an array, and !== can't be used to compare array length / values - they're just pointers in JS. So this is only checking that the pointers are the same, not that the values in the arrays are the same - is that what y'all are trying to do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's exactly what we are trying to do. I have requested this change here #18934 (comment).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, i haven't seen that idea on purpose before (checking if pointers stay the same) - seems fishy but you're sure this works? 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 Yeah I'm sure. The idea is to do some logic only if the pointer change. If the pointer change then it's likely the values are changed too (if the pointer change but we have same values than this is a bad design somewhere else, yet it won't cause any bug if this ever happened). Also there is no case where the values change but keep using the same pointer (onyx do not mutate objects). This is just an optimisation (comparing addresses should be the fastest).

Just curious though, how did you end up here 😁?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Innnnnnnnnteresting, that all sounds legit! 👍 Thanks for explaining :D

Hahaha I ended up here just because i saw some arrays being compared and had to ask why 😅

this.setState((prevState) => ({
selectedEmployees: _.intersection(prevState.selectedEmployees, _.keys(this.props.policyMemberList)),
}));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✋ Coming from #28551

This is an excellent start to aligning the policyMembers. The attached issue is another case in which we want to keep the selected optimistic members' accountID aligned with the new accountID from the API response, so the selection remains.

}

const isReconnecting = prevProps.network.isOffline && !this.props.network.isOffline;
if (!isReconnecting) {
return;
Expand Down