Fix 0 Replies Bug FE #19106

grgia · 2023-05-17T09:45:49Z

Details

Add a check to prevent rendering thread replies if there are no replies.

**Note, the update speed of the parent report in this video is a known bug unrelated to this PR **

Screen.Recording.2023-05-17.at.10.48.10.AM.mov

Fixed Issues

$ #19042

Tests

Verify that no errors appear in the JS console
Create a thread, and add 2 comments.
Go back to parent thread and ensure it reads "2 replies"
Delete both comments
Go back to parent thread and ensure there is no longer replies UI display.

Offline tests

QA Steps

Verify that no errors appear in the JS console
Create a thread, and add 2 comments.
Go back to parent thread and ensure it reads "2 replies"
Delete both comments
Go back to parent thread and ensure there is no longer replies UI display.

PR Author Checklist

Screenshots/Videos

Web

See description

Mobile Web - Chrome

Screen.Recording.2023-05-17.at.5.50.29.PM.mov

Mobile Web - Safari

Screen.Recording.2023-05-17.at.5.46.52.PM.mov

Desktop

Screen.Recording.2023-05-17.at.5.55.50.PM.mov

iOS

Screen.Recording.2023-05-17.at.5.45.02.PM.mov

Android

Screen.Recording.2023-05-17.at.5.54.38.PM.mov

melvin-bot · 2023-05-17T09:45:56Z

@chiragsalian @abdulrahuman5196 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-05-17T09:59:34Z

I assume the PR is ready for review. Will start on it.

src/components/Pressable/PressableWithFeedback.js

abdulrahuman5196 · 2023-05-17T12:06:49Z

@grgia Do we only test this against Staging API only? Because in production the number of replies itself is not decreasing when I delete a message in the reply.

Do we already have a separate bug for production where the count is not decreasing?

abdulrahuman5196 · 2023-05-17T12:37:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Untitled.5.copy.mp4

Mobile Web - Chrome

az_recorder_20230517_205850.mp4

Mobile Web - Safari

ScreenRecording.mov

Desktop

Untitled.5.mp4

iOS

Screen.Recording.2023-05-17.at.8.43.31.PM.mov

Android

az_recorder_20230517_205508.mp4

abdulrahuman5196 · 2023-05-17T13:00:49Z

And Kindly add testing steps in author checklist and platform videos as well?

grgia · 2023-05-17T13:25:34Z

@abdulrahuman5196 yes staging only, also there is a delay and this is known bug - #19118

abdulrahuman5196 · 2023-05-17T14:56:05Z

@grgia Could you kindly check on this? #19106 (comment)

abdulrahuman5196 · 2023-05-17T15:46:52Z

@grgia The changes look good. I have completed my checklist along with platform videos. Only pending item is tests and platform videos on author checklist. Once you are done we should be good to go.

grgia · 2023-05-17T16:56:37Z

@abdulrahuman5196 done!

neil-marcellini · 2023-05-17T17:40:42Z

I'm going to jump in and review this since I have some time and it's interesting.

neil-marcellini

Again please add test and QA steps. We shouldn't consider the author checklist complete without those.

Testing with the bug reproduction steps:

Create a thread
Post one message in the thread
Delete the message you created in 2
See an unexpected result (0 replies) on the original room

It tests very well. A couple NAB comments.

src/pages/home/report/ReportActionItem.js

neil-marcellini

I'm actually going to request changes regarding including tests and QA in the description.

src/pages/home/report/ReportActionItem.js

github-actions · 2023-05-17T19:36:18Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

grgia · 2023-05-17T19:40:40Z

@neil-marcellini I added the QA / test steps

abdulrahuman5196

Changes LGTM and reviewers checklist is also complete.
@grgia Just couple things on authors checklist

Kindly mention this would be tested in staging only in QA steps
Kindly mark the offline tests as Not applicable since threads are updated in the parent only online case, could be related to the known issue you had mentioned

chiragsalian · 2023-05-17T20:30:39Z

Kindly mention this would be tested in staging only in QA steps

Btw, QA is only tested on staging unless mentioned otherwise.

Kindly mark the offline tests as Not applicable since threads are updated...

Yup, this is a good point.

neil-marcellini

Thanks for adding the tests

Fix 0 Replies Bug FE (cherry picked from commit 088fbfe)

…-19106 🍒 Cherry pick PR #19106 to staging 🍒

OSBotify · 2023-05-17T22:22:57Z

🚀 Cherry-picked to staging by https://github.com/neil-marcellini in version: 1.3.15-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-18T06:50:08Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.15-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:28:51Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:46:40Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

If zero visable actions, then hide display.

21375b7

grgia requested a review from a team as a code owner May 17, 2023 09:45

grgia self-assigned this May 17, 2023

melvin-bot bot requested review from abdulrahuman5196 and chiragsalian and removed request for a team May 17, 2023 09:45

prettier

446cfd2

abdulrahuman5196 reviewed May 17, 2023

View reviewed changes

src/components/Pressable/PressableWithFeedback.js Outdated Show resolved Hide resolved

Merge branch 'main' into georgia-zeroThreadReplies

74b867d

grgia requested a review from abdulrahuman5196 May 17, 2023 11:29

neil-marcellini self-requested a review May 17, 2023 17:40

neil-marcellini approved these changes May 17, 2023

View reviewed changes

src/pages/home/report/ReportActionItem.js Show resolved Hide resolved

src/pages/home/report/ReportActionItem.js Show resolved Hide resolved

neil-marcellini requested changes May 17, 2023

View reviewed changes

src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved

grgia added the CP Staging label May 17, 2023

remove newline :0

8acd7fa

grgia requested a review from neil-marcellini May 17, 2023 19:39

stitesExpensify approved these changes May 17, 2023

View reviewed changes

abdulrahuman5196 approved these changes May 17, 2023

View reviewed changes

chiragsalian approved these changes May 17, 2023

View reviewed changes

neil-marcellini approved these changes May 17, 2023

View reviewed changes

neil-marcellini merged commit 088fbfe into main May 17, 2023

neil-marcellini deleted the georgia-zeroThreadReplies branch May 17, 2023 20:42

OSBotify pushed a commit that referenced this pull request May 17, 2023

Merge pull request #19106 from Expensify/georgia-zeroThreadReplies

f961bfd

Fix 0 Replies Bug FE (cherry picked from commit 088fbfe)

OSBotify mentioned this pull request May 17, 2023

🍒 Cherry pick PR #19106 to staging 🍒 #19141

Merged

OSBotify added a commit that referenced this pull request May 17, 2023

Merge pull request #19141 from Expensify/OSBotify-cherry-pick-staging…

dae5598

…-19106 🍒 Cherry pick PR #19106 to staging 🍒

OSBotify mentioned this pull request May 17, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

melvin-bot bot mentioned this pull request May 18, 2023

[HOLD for payment 2023-05-29] [HOLD for payment 2023-05-25] Deleting thread replies results in "0 Replies" #19042

Closed

OSBotify mentioned this pull request May 18, 2023

Deploy Checklist: New Expensify 2023-05-18 #19175

Closed

39 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 0 Replies Bug FE #19106

Fix 0 Replies Bug FE #19106

grgia commented May 17, 2023 •

edited

Loading

melvin-bot bot commented May 17, 2023

abdulrahuman5196 commented May 17, 2023

abdulrahuman5196 commented May 17, 2023 •

edited

Loading

abdulrahuman5196 commented May 17, 2023 •

edited

Loading

abdulrahuman5196 commented May 17, 2023

grgia commented May 17, 2023

abdulrahuman5196 commented May 17, 2023

abdulrahuman5196 commented May 17, 2023

grgia commented May 17, 2023

neil-marcellini commented May 17, 2023

neil-marcellini left a comment

neil-marcellini left a comment

github-actions bot commented May 17, 2023

grgia commented May 17, 2023

abdulrahuman5196 left a comment

chiragsalian commented May 17, 2023

neil-marcellini left a comment

OSBotify commented May 17, 2023

OSBotify commented May 18, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Fix 0 Replies Bug FE #19106

Fix 0 Replies Bug FE #19106

Conversation

grgia commented May 17, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 17, 2023

abdulrahuman5196 commented May 17, 2023

abdulrahuman5196 commented May 17, 2023 • edited Loading

abdulrahuman5196 commented May 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 commented May 17, 2023

grgia commented May 17, 2023

abdulrahuman5196 commented May 17, 2023

abdulrahuman5196 commented May 17, 2023

grgia commented May 17, 2023

neil-marcellini commented May 17, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

github-actions bot commented May 17, 2023

grgia commented May 17, 2023

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

chiragsalian commented May 17, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

OSBotify commented May 17, 2023

OSBotify commented May 18, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

grgia commented May 17, 2023 •

edited

Loading

abdulrahuman5196 commented May 17, 2023 •

edited

Loading

abdulrahuman5196 commented May 17, 2023 •

edited

Loading