feat: redirect to workspace after creation #19224

allroundexperts · 2023-05-18T22:13:23Z

Details

This PR redirects the user to the workspace page in the background once a new workspace is created.

Fixed Issues

$ #18894
PROPOSAL: #18894 (comment)

Tests

Open ND on Web or Desktop and login with any account
Go to Settings -> WorkSpaces
Click on Create new workspace button
Verify that the chat report page in background changes to the workspace page

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open ND on Web or Desktop and login with any account
Go to Settings -> WorkSpaces
Click on Create new workspace button
Verify that the chat report page in background changes to the workspace page

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-19.at.1.30.25.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-19.at.1.37.41.AM.mov

Mobile Web - Safari

Screen.Recording.2023-05-19.at.1.34.25.AM.mov

Desktop

Screen.Recording.2023-05-19.at.1.30.57.AM.mov

iOS

Screen.Recording.2023-05-19.at.1.40.34.AM.mov

Android

Screen.Recording.2023-05-19.at.1.39.05.AM.mov

melvin-bot · 2023-05-18T22:13:30Z

@NikkiWines @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-05-19T20:28:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-20.at.1.45.42.AM.mov

Desktop

Screen.Recording.2023-05-20.at.1.45.15.AM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-05-20.at.1.51.31.AM.mov

Android

Screen.Recording.2023-05-20.at.1.56.17.AM.mov

iOS

Screen.Recording.2023-05-20.at.1.53.12.AM.mov

src/libs/actions/Policy.js

Santhosh-Sellavel · 2023-05-19T20:37:23Z

src/libs/actions/Policy.js

+        // This is needed to redirect the user to workspace admin screen on the main router stack 
+        // https://github.com/Expensify/App/pull/19224


Suggested change

// This is needed to redirect the user to workspace admin screen on the main router stack

// https://github.com/Expensify/App/pull/19224

// To navigate the user to admin room

// https://github.com/Expensify/App/issues

Wait for @NikkiWines before updating

I would make the comment more generic to the behavior and less about the issue it's fixing. e.g.

Get the reportID associated with the newly created #admins room and route the user to that chat

@allroundexperts bump

@Santhosh-Sellavel Is this fine?

Get the reportID associated with the newly created #admins room and route the user to that chat

Yes it's fine

Should remove the issue/pr links @allroundexperts

@Santhosh-Sellavel updated

NikkiWines

minor comment adjustment

NikkiWines · 2023-05-19T21:36:13Z

src/libs/actions/Policy.js

+        // This is needed to redirect the user to workspace admin screen on the main router stack 
+        // https://github.com/Expensify/App/pull/19224


I would make the comment more generic to the behavior and less about the issue it's fixing. e.g.

Get the reportID associated with the newly created #admins room and route the user to that chat

src/libs/actions/Policy.js

Santhosh-Sellavel · 2023-05-21T16:11:07Z

@allroundexperts can you fix lint please?

allroundexperts · 2023-05-21T16:13:58Z

Mobile commits aren’t a good idea 😅. I’ll push once I’m on my laptop

…

On Sun, 21 May 2023 at 9:11 PM, Santhosh Sellavel ***@***.***> wrote: @allroundexperts <https://github.com/allroundexperts> can you fix lint please? — Reply to this email directly, view it on GitHub <#19224 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHFJUUB5YYHKJ3YCRTTTFEDXHI5CPANCNFSM6AAAAAAYHAQROI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

allroundexperts · 2023-05-21T18:36:08Z

@Santhosh-Sellavel All done!

Santhosh-Sellavel

All yours @NikkiWines

NikkiWines

👍 looks great!

OSBotify · 2023-05-22T19:32:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-22T23:49:42Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.3.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T00:21:34Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts added 2 commits May 19, 2023 01:20

feat: redirect to workspace after creation

06cc9a8

feat: update prettier styles

c41bc43

allroundexperts requested a review from a team as a code owner May 18, 2023 22:13

melvin-bot bot requested review from NikkiWines and Santhosh-Sellavel and removed request for a team May 18, 2023 22:13

allroundexperts mentioned this pull request May 18, 2023

[HOLD for payment 2023-06-01] [$1000] User is not navigated to #admin room of the workspace when creating a new workspace #18894

Closed

6 tasks

Santhosh-Sellavel suggested changes May 19, 2023

View reviewed changes

src/libs/actions/Policy.js Show resolved Hide resolved

Update Policy.js

9ded20f

allroundexperts requested a review from Santhosh-Sellavel May 19, 2023 20:33

Santhosh-Sellavel reviewed May 19, 2023

View reviewed changes

NikkiWines requested changes May 19, 2023

View reviewed changes

Update Policy.js

1f031f6

fix: prettier errors

c90eb1c

allroundexperts requested review from NikkiWines and Santhosh-Sellavel May 21, 2023 18:36

Santhosh-Sellavel approved these changes May 22, 2023

View reviewed changes

NikkiWines approved these changes May 22, 2023

View reviewed changes

NikkiWines merged commit 58dd3c8 into Expensify:main May 22, 2023

OSBotify mentioned this pull request May 22, 2023

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed

62 tasks

mollfpr mentioned this pull request May 23, 2023

[HOLD for payment 2023-07-20] [$1000] Web - Workspace - Workspace settings and chat on the background instead of #admins room #18351

Closed

6 tasks

danieldoglas mentioned this pull request May 23, 2023

[$1000] Composer is focused when creating a workspace #19440

Closed

6 tasks

NikkiWines mentioned this pull request May 26, 2023

fix: use Navigation.navigate function to redirect user to admin workspace #19492

Closed

56 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: redirect to workspace after creation #19224

feat: redirect to workspace after creation #19224

allroundexperts commented May 18, 2023

melvin-bot bot commented May 18, 2023

Santhosh-Sellavel commented May 19, 2023 •

edited

Loading

Santhosh-Sellavel May 19, 2023

NikkiWines May 19, 2023

Santhosh-Sellavel May 21, 2023

allroundexperts May 21, 2023

Santhosh-Sellavel May 21, 2023

Santhosh-Sellavel May 21, 2023 •

edited

Loading

allroundexperts May 21, 2023

NikkiWines left a comment

NikkiWines May 19, 2023

Santhosh-Sellavel commented May 21, 2023

allroundexperts commented May 21, 2023 via email

allroundexperts commented May 21, 2023

Santhosh-Sellavel left a comment

NikkiWines left a comment

OSBotify commented May 22, 2023

OSBotify commented May 22, 2023

OSBotify commented May 25, 2023

		// This is needed to redirect the user to workspace admin screen on the main router stack
		// https://github.com/Expensify/App/pull/19224

feat: redirect to workspace after creation #19224

feat: redirect to workspace after creation #19224

Conversation

allroundexperts commented May 18, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 18, 2023

Santhosh-Sellavel commented May 19, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel May 19, 2023

Choose a reason for hiding this comment

NikkiWines May 19, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel May 21, 2023

Choose a reason for hiding this comment

allroundexperts May 21, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel May 21, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel May 21, 2023 • edited Loading

Choose a reason for hiding this comment

allroundexperts May 21, 2023

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

NikkiWines May 19, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel commented May 21, 2023

allroundexperts commented May 21, 2023 via email

allroundexperts commented May 21, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented May 22, 2023

OSBotify commented May 22, 2023

OSBotify commented May 25, 2023

Santhosh-Sellavel commented May 19, 2023 •

edited

Loading

Santhosh-Sellavel May 21, 2023 •

edited

Loading