-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for unvalidated accounts and change in password flow #1929
Conversation
Accidently added pullerbear a second time so i removed robert as reviewer since i think just two would suffice. Manually added stites since i think you may have worked on this flow for e.cash |
|
The related auth code is live and the web-e code is on staging. It should be on production tomorrow and then this PR will be off HOLD. |
Off HOLD since the related PRs are live. Ready for reviews / merge. |
@stitesExpensify I approved already so it's up to you! |
resendValidationLink(); | ||
if (!this.props.account.validated) { | ||
resendValidationLink(); | ||
console.debug('Account is unvalidated: Sending validation link.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we're printing this to the console? Seems unnecessary IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because when you click "resend link" its hard to tell which flow is being called. You can check the network tab for this but its easier with two console.debug as can be seen in test steps 7 and 11. Just makes life easier when you want to debug.
HOLD until the web-e and auth PRs go live i.e,
Details
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/156783
Tests
php /vagrant/Web-Expensify/script/notifyall.php
from within vssh.<baseUrl>/setpassword/<code>
. Don't click it just yet.php /vagrant/Web-Expensify/script/notifyall.php
from within vssh. You might have to runupdate notifications set json = json_set(json(notifications.json), '$.to', '<yourExpensifyEmail>');
if the unvalidated email does not belong to expensify since we only send emails out to expensify.<baseURL>/setpassword/<code>
. Click it and confirm you can set your password and you are logged in once done.Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android