Rename profile page to details page #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperhuangg
requested changes
Mar 22, 2021
There was a problem hiding this comment.
@NikkiWines Looks good! Merge conflicts just need to be solved and then it should be good to go!
src/pages/home/HeaderView.js
Outdated
| @@ -63,7 +63,7 @@ const HeaderView = props => ( | |||
| onPress={() => { | |||
| const {participants} = props.report; | |||
| if (participants.length === 1) { | |||
| Navigation.navigate(ROUTES.getProfileRoute(participants[0])); | |||
There was a problem hiding this comment.
I know this is kinda unrelated to your changes, but it looks like participants is a duplicate name from the upper scope (line 53). Is there any reason we're re-accessing/redefining a variable for props.reports.participants here?
There was a problem hiding this comment.
You're right that there's no need to redefine this here and actually it convenient got changed/resolved after merging master.
|
Updated and resolved conflicts |
jasperhuangg
approved these changes
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Currently in E.cash there are two profile pages: The page you get when you click on the chat header avatar of a chat you have with someone, and the page you get when navigating to Settings > Profile.
The non-settings profile page displays a header of
Detailswhile the settings profile page displaysProfile.There's no reason for these pages to be named the same thing, and from the description above you can see how much more difficult to describe which page is which.
Fixed Issues
Fixes N/A, was brought up in conversation and is an easy fix.
Tests
Detailspage for that user.Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android