Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #19339 to staging 🍒 #19354

Merged
merged 2 commits into from
May 20, 2023
Merged

🍒 Cherry pick PR #19339 to staging 🍒 #19354

merged 2 commits into from
May 20, 2023

Conversation

OSBotify
Copy link
Contributor

🍒 Cherry pick #19339 to staging 🍒

OSBotify and others added 2 commits May 20, 2023 19:46
@OSBotify
Merge pull request #19353 from Expensify/version-BUILD-673948A1-BC4F-…
e7eb51a 
…41B3-956A-4F3B897E10D6

Update version to 1.3.16-6 on main

(cherry picked from commit 8180113)
@puneetlath @OSBotify
Merge pull request #19339 from tienifr/fix/19310-buttons-add-attachme…
1751961 
…nt-not-responsive-ios

Fix: `Add attachments` and `Delete workspace` buttons are not responsive
(cherry picked from commit f4883cd)
@OSBotify OSBotify requested a review from a team as a code owner May 20, 2023 19:46
@melvin-bot melvin-bot bot removed the request for review from a team May 20, 2023 19:46
@OSBotify OSBotify merged commit a4834ad into staging May 20, 2023
@OSBotify OSBotify deleted the OSBotify-cherry-pick-staging-19339 branch May 20, 2023 19:46
@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.3.16-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

2 similar comments
@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OSBotify @puneetlath