Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17015 - migrate SidebarLinks to PressableWithoutFeedback #19597

Merged
merged 2 commits into from
Jun 5, 2023
Merged

17015 - migrate SidebarLinks to PressableWithoutFeedback #19597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf0c04d
migrate SidebarLinks to PressableWithoutFeedback
Skalakid May 25, 2023
32985d5
Merge branch 'main' into 17015-migrate-SidebarLinks
Skalakid Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/pages/home/sidebar/SidebarLinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable rulesdir/onyx-props-must-have-default */
import lodashGet from 'lodash/get';
import React from 'react';
import {View, TouchableOpacity} from 'react-native';
import {View} from 'react-native';
import _ from 'underscore';
import PropTypes from 'prop-types';
import {withOnyx} from 'react-native-onyx';
Expand Down Expand Up @@ -33,6 +33,7 @@ import defaultTheme from '../../../styles/themes/default';
import OptionsListSkeletonView from '../../../components/OptionsListSkeletonView';
import variables from '../../../styles/variables';
import LogoComponent from '../../../../assets/images/expensify-wordmark.svg';
import PressableWithoutFeedback from '../../../components/Pressable/PressableWithoutFeedback';
import * as Session from '../../../libs/actions/Session';
import Button from '../../../components/Button';
import * as UserUtils from '../../../libs/UserUtils';
Expand Down Expand Up @@ -166,16 +167,16 @@ class SidebarLinks extends React.Component {
shouldShowEnvironmentBadge
/>
<Tooltip text={this.props.translate('common.search')}>
<TouchableOpacity
<PressableWithoutFeedback
accessibilityLabel={this.props.translate('sidebarScreen.buttonSearch')}
accessibilityRole="button"
style={[styles.flexRow, styles.ph5]}
onPress={Session.checkIfActionIsAllowed(this.showSearchPage)}
>
<Icon src={Expensicons.MagnifyingGlass} />
</TouchableOpacity>
</PressableWithoutFeedback>
</Tooltip>
<TouchableOpacity
<PressableWithoutFeedback
accessibilityLabel={this.props.translate('sidebarScreen.buttonMySettings')}
accessibilityRole="button"
onPress={Session.checkIfActionIsAllowed(this.showSettingsPage)}
Expand All @@ -197,7 +198,7 @@ class SidebarLinks extends React.Component {
/>
</OfflineWithFeedback>
)}
</TouchableOpacity>
</PressableWithoutFeedback>
</View>
<Freeze
freeze={shouldFreeze}
Expand Down