Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal closing animation on web/desktop #1960

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Fix modal closing animation on web/desktop #1960

merged 3 commits into from
Mar 24, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Mar 19, 2021 •
edited
Loading

Details

Switching to react-navigation broke modal animations.

react-navigation does not offer a complete solution for dismissing modals by clicking on overlays see this feature request, but with this PR we can get rid of the use of Modal for large screens / web.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/157247

Tests

  1. Test opening and closing various right docks modals on all platforms

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

2021-03-23_14-56-10.mp4

Mobile Web

2021-03-23_14-55-42.mp4

Desktop

tested w/out screen grab

iOS

2021-03-23_15-20-25.mp4

Android

tested w/out screen grab

@marcaaron marcaaron self-assigned this Mar 19, 2021
@marcaaron marcaaron changed the title [WIP] Fix modal closing animation on web/desktop Fix modal closing animation on web/desktop Mar 24, 2021
@marcaaron marcaaron marked this pull request as ready for review March 24, 2021 01:57
@marcaaron marcaaron requested a review from a team as a code owner March 24, 2021 01:57
@botify botify requested review from jasperhuangg and removed request for a team March 24, 2021 01:57
@marcaaron marcaaron marked this pull request as draft March 24, 2021 01:59
@marcaaron marcaaron removed the request for review from jasperhuangg March 24, 2021 01:59
@marcaaron
Copy link
Contributor Author

Sorry not ready yet.

@marcaaron
Fix modal closing animation
6706d16 
Fix custom root stack navigator

always render a view at least

scrap custom navigator

add cardstyleinterpolator.js

add back the custom stack nav

tone down the output

fix conflicts and add ClickAwayHandler

modified

fix names
@marcaaron marcaaron force-pushed the marcaaron-fixModalClosing branch from 7725a8c to 6706d16 Compare March 24, 2021 02:07
@marcaaron marcaaron marked this pull request as ready for review March 24, 2021 02:10
@marcaaron marcaaron requested a review from a team March 24, 2021 02:11
@botify botify requested review from jasperhuangg and removed request for a team March 24, 2021 02:11
@jasperhuangg jasperhuangg merged commit f96ebbd into master Mar 24, 2021
@jasperhuangg jasperhuangg deleted the marcaaron-fixModalClosing branch March 24, 2021 10:10
@OSBotify OSBotify mentioned this pull request Mar 24, 2021
Closed
85 tasks
@s77rt
Copy link
Contributor

s77rt commented Mar 13, 2023

This PR caused a regression. The implemented ClickAwayHandler is selectable. On double clicking a button, instead of having a modal open then close, it will open but won't close as the second click was captured by the browser to perform Select All action.

@s77rt s77rt mentioned this pull request Mar 13, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperhuangg jasperhuangg jasperhuangg approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @s77rt @jasperhuangg