Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate AttachmentPicker/index.js to functional component #19734

Merged
merged 2 commits into from
May 29, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 37 additions & 35 deletions src/components/AttachmentPicker/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, {useRef} from 'react';
import CONST from '../../CONST';
import {propTypes, defaultProps} from './attachmentPickerPropTypes';
import * as FileUtils from '../../libs/fileDownload/FileUtils';
Expand All @@ -22,44 +22,46 @@ function getAcceptableFileTypes(type) {
* a callback. This is the web/mWeb/desktop version since
* on a Browser we must append a hidden input to the DOM
* and listen to onChange event.
* @param {propTypes} props
* @returns {JSX.Element}
*/
class AttachmentPicker extends React.Component {
render() {
return (
<>
<input
hidden
type="file"
ref={(el) => (this.fileInput = el)}
onChange={(e) => {
let file = e.target.files[0];
function AttachmentPicker(props) {
const fileInput = useRef();
const onPicked = useRef();
return (
<>
<input
hidden
type="file"
ref={fileInput}
onChange={(e) => {
let file = e.target.files[0];

if (file) {
const cleanName = FileUtils.cleanFileName(file.name);
if (file.name !== cleanName) {
file = new File([file], cleanName);
}
file.uri = URL.createObjectURL(file);
this.onPicked(file);
if (file) {
const cleanName = FileUtils.cleanFileName(file.name);
if (file.name !== cleanName) {
file = new File([file], cleanName);
}
file.uri = URL.createObjectURL(file);
onPicked.current(file);
}

// Cleanup after selecting a file to start from a fresh state
this.fileInput.value = null;
}}
// We are stopping the event propagation because triggering the `click()` on the hidden input
// causes the event to unexpectedly bubble up to anything wrapping this component e.g. Pressable
onClick={(e) => e.stopPropagation()}
accept={getAcceptableFileTypes(this.props.type)}
/>
{this.props.children({
openPicker: ({onPicked}) => {
this.onPicked = onPicked;
this.fileInput.click();
},
})}
</>
);
}
// Cleanup after selecting a file to start from a fresh state
fileInput.current.value = null;
}}
// We are stopping the event propagation because triggering the `click()` on the hidden input
// causes the event to unexpectedly bubble up to anything wrapping this component e.g. Pressable
onClick={(e) => e.stopPropagation()}
accept={getAcceptableFileTypes(props.type)}
/>
{props.children({
openPicker: ({onPicked: newOnPicked}) => {
onPicked.current = newOnPicked;
fileInput.current.click();
},
})}
</>
);
}

AttachmentPicker.propTypes = propTypes;
Expand Down