Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily hide incomplete IOU modal #1981

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Mar 22, 2021

Details

The IOU Modal is being completed in stages -- see parent tracking issue. We have just merged an issue which implements the updated create menu, but are not quite ready to expose the Modal to everyone.

Once we complete the modal we will implement a beta flag, but for now we simply want to disable the menu option from being shown. This also avoids confusion, as the new options currently route to the same old modal.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/154620

Tests

Note that Expensify.cash currently shows new menu options for IOU, you should NOT see these while testing

Verify IOU menu options are not displayed

  • Tap the global FAB button
  • The only visible items should be: 'New Chat' and 'New Group'
  • Open a chat
  • Tap the + button next to chat input
  • The only visible item should be: 'Add Attachment'

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web
Screenshot 2021-03-22 at 16 36 11
Screenshot 2021-03-22 at 16 36 02

Android
device-2021-03-22-163933
device-2021-03-22-163837

iOS
Simulator Screen Shot - iPhone 11 - 2021-03-22 at 16 46 14
Simulator Screen Shot - iPhone 11 - 2021-03-22 at 16 45 57

Desktop
Screenshot 2021-03-22 at 16 45 29
Screenshot 2021-03-22 at 16 45 23

Mobile Web
Simulator Screen Shot - iPhone 11 - 2021-03-22 at 16 47 10

@Julesssss Julesssss requested a review from a team as a code owner March 22, 2021 16:40
@Julesssss Julesssss self-assigned this Mar 22, 2021
@botify botify requested review from alex-mechler and removed request for a team March 22, 2021 16:41
@alex-mechler alex-mechler merged commit 23d72bc into master Mar 22, 2021
@alex-mechler alex-mechler deleted the jules-temporarilyHideIOUModal branch March 22, 2021 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants