-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix popover menu anchor alignment prop #19849
Merged
iwiznia
merged 19 commits into
Expensify:main
from
huzaifa-99:19453-fix-popover-menu-anchor-alignment-prop
Jun 9, 2023
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
bbd951a
Fix avatar dropdown in profile and workspace setting
huzaifa-99 ad455dc
Fix dropdown position for workspace list 3-dots menu
huzaifa-99 3008412
Fix lint issues
huzaifa-99 4a3db13
Fix lint issues
huzaifa-99 51f8691
Fix lint issues
huzaifa-99 0554e58
Fix lint issues
huzaifa-99 a397e99
Merge branch 'main' into 19453-fix-popover-menu-anchor-alignment-prop
huzaifa-99 44e316e
Merge branch 'main' into 19453-fix-popover-menu-anchor-alignment-prop
huzaifa-99 c5b6dec
Added getVerticalOffset no-op to add vertical gap on desktop
huzaifa-99 0158ed7
Fix newline diff
huzaifa-99 a6e3d4c
Move desktop header gap to const
huzaifa-99 b7f0c1c
Renamed desktop header gap const
huzaifa-99 b65dd2a
Added js doc for getVerticalOffset
huzaifa-99 068c0b3
Merge branch 'main' into 19453-fix-popover-menu-anchor-alignment-prop
huzaifa-99 c0e29a3
Merge branch 'main' into 19453-fix-popover-menu-anchor-alignment-prop
huzaifa-99 22037c8
Merge branch 'main' into 19453-fix-popover-menu-anchor-alignment-prop
huzaifa-99 47b14b5
Merge branch 'main' into 19453-fix-popover-menu-anchor-alignment-prop
huzaifa-99 3476a4e
Fix merge issue
huzaifa-99 c2ce3bf
Renamed getVerticalOffset style to getPopOverVerticalOffset
huzaifa-99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
export default (vertical) => ({ | ||
// On desktop app we are adding a header gap of 12px | ||
// which we need to add to vertical offset when setting | ||
// offset on desktop | ||
vertical: vertical + 12, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 12 should be made as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done @Santhosh-Sellavel |
||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export default (vertical) => ({vertical}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add JS Doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done