Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Emoji Picker #1991
Add Emoji Picker #1991
Changes from 87 commits
89c1fe9
b8f3230
3aef3db
e63876e
5841cb5
7c757d6
96b2e43
18e4c1e
cd72afd
35dd8ae
abf77ce
b75744e
c17f51a
4297646
0d4862d
885f570
0f8454f
d16fb6f
f33c9a3
fb9fc8d
857274f
08daae6
cde5d7a
9905e4f
1c7d547
205c9b3
b078bff
33b210f
570fb7d
9f4856e
7b1b7ff
b213d60
719e495
e11297d
61a16f2
f56e00a
09c9a65
e58e847
20f971f
7eab869
5906af7
b199f89
9ed44c8
803db87
48399a8
074af23
47826b9
39b69c1
35cacd0
fb2c270
550fc21
8aa1555
17a74b3
0d51fbc
6810b75
382a878
8b9c0b1
9f64d4c
184785e
0055378
b1b6f53
26e8503
7907a97
26fa00d
5e6b602
c88377f
4e25b8f
388d424
9557dd7
23a5f08
7a0fc9a
e127abf
012a486
f2c0bc1
e752bc9
4a9a842
f3c0c40
ee8e493
29546d1
d508a07
2c7e196
9b75d6d
ca841e4
cbe39fc
a5f795d
f05b5fb
ad7ac23
22be396
6e3c787
95c783b
fc9d37f
0b5f628
4899e43
3a3856c
7d97899
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could also DRY up this
renderItem
by putting it in a separate file too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted with Rory about DRYing these up and I don't think it's necessary given that these files are going to be re-merged soon and then the code won't be duplicated anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does re-merged mean?