Fix page not found appears for a second when user opens a thread #20076

dukenv0307 · 2023-06-02T16:54:05Z

Details

Page not found appears for a second when user opens a thread

Fixed Issues

$ #19364
PROPOSAL: #19364 (comment)

Tests

Verify that no errors appear in the JS console

Login with user A on any device
On an other device, login with user B
User A sends any message to user B
User A create a new thread for this message above
User B clicks on reply in thread of this message
Verify that page not found doesn't appear

Offline tests

Same above

QA Steps

Verify that no errors appear in the JS console

Login with user A on any device
On an other device, login with user B
User A sends any message to user B
User A create a new thread for this message above
User B clicks on reply in thread of this message
Verify that page not found doesn't appear

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screencast.from.02-06-2023.23.44.32.webm

Mobile Web - Chrome

Record_2023-06-02-23-45-23.mp4

Mobile Web - Safari

Screen.Recording.2023-06-03.at.00.44.15.1.mp4

Desktop

Screen.Recording.2023-06-03.at.01.16.17.mp4

iOS

Screen.Recording.2023-06-03.at.01.11.58.mp4

Android

19364.mp4

melvin-bot · 2023-06-02T18:19:49Z

@marcochavezf @fedirjh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2023-06-02T18:26:27Z

src/libs/actions/Report.js

+
+    // If we open an exist report, but it is not present in Onyx yet, we should change the method to set for this report
+    // and we need data to be available when we navigate to the chat page
+    if (_.isEmpty(report)) {


Suggested change

if (_.isEmpty(report)) {

if (_.isEmpty(allReports[reportID])) {

We can check directly , report is not reused in this block

fedirjh · 2023-06-02T18:26:58Z

src/libs/actions/Report.js

+    const report = allReports[reportID];
+


Suggested change

const report = allReports[reportID];

We can get rid of this line and use an inline check

dukenv0307 · 2023-06-02T18:31:27Z

@fedirjh I updated.

fedirjh · 2023-06-03T00:38:01Z

@dukenv0307 We have an issue with money requests threads , the OpenReport is executed infinitely and the report is stuck on loading state

Rel.mov

fedirjh · 2023-06-03T00:43:08Z

@dukenv0307 I think the issue comes from this line , the IOU reports are not included in all reports

App/src/libs/actions/Report.js

Line 763 in 0813e2c

if (!report || ReportUtils.isIOUReport(report)) {

dukenv0307 · 2023-06-03T01:28:37Z

@fedirjh I think we could create a getReport function in ReportUtils that passed a reportID and return the report with reportID parameter because in ReportUtils, allReports includes all report.

App/src/libs/ReportUtils.js

Lines 68 to 72 in 0813e2c

    
           Onyx.connect({ 
        
               key: ONYXKEYS.COLLECTION.REPORT, 
        
               waitForCollectionCallback: true, 
        
               callback: (val) => (allReports = val), 
        
           });

fedirjh · 2023-06-03T01:52:24Z

@dukenv0307 looks good to me , let's implement it.

dukenv0307 · 2023-06-03T02:07:52Z

@fedirjh I updated, please help to check again.

fedirjh · 2023-06-03T02:42:56Z

@dukenv0307 looks good, let's add reportID to the optimisticReportData

dukenv0307 · 2023-06-03T02:52:25Z

@fedirjh updated reportID to the optimisticReportData

fedirjh · 2023-06-03T06:43:13Z

@dukenv0307 could you please update the testing steps to make them more clear , you can check the main issue steps.

dukenv0307 · 2023-06-03T06:51:12Z

@fedirjh The main issue test steps need to create a sub thread in a thread, but we can reproduce when user A opens a thread in main DM and user B opens it

fedirjh · 2023-06-03T07:09:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-03.at.6.19.41.AM.mov

Mobile Web - Chrome

Chrome.loading.mov

Mobile Web - Safari

Safari.mp4

Desktop

Screen.Recording.2023-06-03.at.6.50.24.AM.mov

iOS

IOS.mp4

Android

android.loading.mov

fedirjh

LGTM and tests well

cc @marcochavezf

🎀 👀 🎀 C+ reviewed

marcochavezf

LGTM, thanks guys! 🚀

OSBotify · 2023-06-05T19:03:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-06T19:50:46Z

🚀 Cherry-picked to staging by https://github.com/marcochavezf in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-07T03:28:07Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-07T13:19:46Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

aldo-expensify · 2023-06-07T19:00:50Z

src/libs/actions/Report.js

+    if (_.isEmpty(ReportUtils.getReport(reportID))) {
+        optimisticReportData.onyxMethod = Onyx.METHOD.SET;
+        optimisticReportData.value = {
+            ...optimisticReportData.value,
+            reportID: reportID.toString(),
+        };
+    }


This seems to be causing this regression: #20394

If I remove these lines, #20394 is solved.

Investigating now

@aldo-expensify It looks like setting the reportID optimistically is the root cause of the other issue.

alitoshmatov · 2023-06-07T19:09:37Z

src/libs/ReportUtils.js

+function getReport(reportID) {
+    return allReports[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
+}


This also causing crash if user is not authenticated yet, and does not have any value in onyx. Part of #20394

Nice catch @alitoshmatov

FYI this can still return null if the report key is present, but the report was deleted (set to null)

Fix page not found appears for a second when user opens a thread

ff8e3b9

dukenv0307 marked this pull request as ready for review June 2, 2023 18:19

dukenv0307 requested a review from a team as a code owner June 2, 2023 18:19

melvin-bot bot requested review from fedirjh and marcochavezf and removed request for a team June 2, 2023 18:19

fedirjh suggested changes Jun 2, 2023

View reviewed changes

refactor condition

e4ef1de

create get report function

cbe74ba

add reportID to optimistic report data

ba1e2dc

dukenv0307 added 2 commits June 3, 2023 10:03

convert reportID to string

da20600

format code

5a85f7d

fedirjh approved these changes Jun 3, 2023

View reviewed changes

marcochavezf approved these changes Jun 5, 2023

View reviewed changes

marcochavezf merged commit f104baa into Expensify:main Jun 5, 2023

melvin-bot bot mentioned this pull request Jun 6, 2023

[HOLD on #20394] [HOLD for payment 2023-06-21] [$1000] hmm it’s not there page appears for second when user opens a thread #19364

Closed

6 tasks

aldo-expensify reviewed Jun 7, 2023

View reviewed changes

aldo-expensify mentioned this pull request Jun 7, 2023

[HOLD for payment 2023-06-21] [$1000] Chat - Page loads infinitely instead of error page when accessing invalid link #20394

Closed

6 tasks

alitoshmatov reviewed Jun 7, 2023

View reviewed changes

fedirjh mentioned this pull request Jun 7, 2023

Fix page loads infinitely #20407

Merged

57 tasks

aimane-chnaif mentioned this pull request Jun 9, 2023

3Eyed todd appears when opening a thread for the first time #19045

Closed

luacmartins mentioned this pull request Aug 30, 2023

[HOLD for payment 2023-09-07] [$500] [HOLD for payment 2023-09-06] Web - App crashes for user B when user A deletes IOU request while both users opens the same request #26251

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix page not found appears for a second when user opens a thread #20076

Fix page not found appears for a second when user opens a thread #20076

dukenv0307 commented Jun 2, 2023 •

edited

Loading

melvin-bot bot commented Jun 2, 2023

fedirjh Jun 2, 2023

fedirjh Jun 2, 2023

dukenv0307 commented Jun 2, 2023

fedirjh commented Jun 3, 2023

fedirjh commented Jun 3, 2023

dukenv0307 commented Jun 3, 2023

fedirjh commented Jun 3, 2023

dukenv0307 commented Jun 3, 2023

fedirjh commented Jun 3, 2023

dukenv0307 commented Jun 3, 2023

fedirjh commented Jun 3, 2023

dukenv0307 commented Jun 3, 2023

fedirjh commented Jun 3, 2023

fedirjh left a comment

marcochavezf left a comment

OSBotify commented Jun 5, 2023

OSBotify commented Jun 6, 2023

OSBotify commented Jun 7, 2023

OSBotify commented Jun 7, 2023

aldo-expensify Jun 7, 2023 •

edited

Loading

fedirjh Jun 7, 2023

fedirjh Jun 7, 2023

alitoshmatov Jun 7, 2023 •

edited

Loading

fedirjh Jun 7, 2023

luacmartins Aug 30, 2023

	if (_.isEmpty(report)) {
	if (_.isEmpty(allReports[reportID])) {

Fix page not found appears for a second when user opens a thread #20076

Fix page not found appears for a second when user opens a thread #20076

Conversation

dukenv0307 commented Jun 2, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 2, 2023

fedirjh Jun 2, 2023

Choose a reason for hiding this comment

fedirjh Jun 2, 2023

Choose a reason for hiding this comment

dukenv0307 commented Jun 2, 2023

fedirjh commented Jun 3, 2023

fedirjh commented Jun 3, 2023

dukenv0307 commented Jun 3, 2023

fedirjh commented Jun 3, 2023

dukenv0307 commented Jun 3, 2023

fedirjh commented Jun 3, 2023

dukenv0307 commented Jun 3, 2023

fedirjh commented Jun 3, 2023

dukenv0307 commented Jun 3, 2023

fedirjh commented Jun 3, 2023

Reviewer Checklist

Screenshots/Videos

fedirjh left a comment

Choose a reason for hiding this comment

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 5, 2023

OSBotify commented Jun 6, 2023

OSBotify commented Jun 7, 2023

OSBotify commented Jun 7, 2023

aldo-expensify Jun 7, 2023 • edited Loading

Choose a reason for hiding this comment

fedirjh Jun 7, 2023

Choose a reason for hiding this comment

fedirjh Jun 7, 2023

Choose a reason for hiding this comment

alitoshmatov Jun 7, 2023 • edited Loading

Choose a reason for hiding this comment

fedirjh Jun 7, 2023

Choose a reason for hiding this comment

luacmartins Aug 30, 2023

Choose a reason for hiding this comment

dukenv0307 commented Jun 2, 2023 •

edited

Loading

aldo-expensify Jun 7, 2023 •

edited

Loading

alitoshmatov Jun 7, 2023 •

edited

Loading