-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new key for reactions #20087
Add new key for reactions #20087
Conversation
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@stitesExpensify Can you please add a little detail about what this PR is about? By just following the test steps, I can't reproduce this on staging. Like do I need to do something special in order to move the chat in LHN? |
As the external reviewer, there is nothing for you to test really. We just need to make sure nothing breaks basically. There was a deploy blocker created by a web PR that this will fix, but we reverted, and this will prevent it from blocking again |
Ah. Gotcha. I thought I needed to test the fix actually. |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-06-07.at.1.47.43.AM.movMobile Web - ChromeScreen.Recording.2023-06-07.at.1.57.42.AM.movMobile Web - SafariScreen.Recording.2023-06-07.at.2.00.01.AM.movDesktopScreen.Recording.2023-06-07.at.1.49.43.AM.moviOSScreen.Recording.2023-06-07.at.1.58.11.AM.movAndroidScreen.Recording.2023-06-07.at.1.56.47.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing for @jasperhuangg since they are OOO
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/alex-mechler in version: 1.3.26-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀
|
Details
Fixed Issues
$ #20001
PROPOSAL: n/a
Tests
Internal testing only
External testing:
Offline tests
Same as online
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
2023-06-02_15-35-58.mp4
Mobile Web - Chrome
2023-06-02_16-39-02.mp4
Mobile Web - Safari
2023-06-02_16-26-56.mp4
Desktop
2023-06-02_15-41-10.mp4
iOS
2023-06-02_16-26-16.mp4
Android
2023-06-02_16-38-18.mp4