Migrate NewChatPage to functional component #20170
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import _ from 'underscore'; | ||
| import React, {useState, useEffect, useMemo} from 'react'; | ||
| import {View} from 'react-native'; | ||
| import PropTypes from 'prop-types'; | ||
| import {withOnyx} from 'react-native-onyx'; | ||
|
|
@@ -44,226 +44,187 @@ const defaultProps = { | |
| reports: {}, | ||
| }; | ||
|
|
||
| const NewChatPage = (props) => { | ||
| const [searchTerm, setSearchTerm] = useState(''); | ||
| const [filteredRecentReports, setFilteredRecentReports] = useState([]); | ||
| const [filteredPersonalDetails, setFilteredPersonalDetails] = useState([]); | ||
| const [filteredUserToInvite, setFilteredUserToInvite] = useState(); | ||
| const [selectedOptions, setSelectedOptions] = useState([]); | ||
|
|
||
| const excludedGroupEmails = _.without(CONST.EXPENSIFY_EMAILS, CONST.EMAIL.CONCIERGE); | ||
| const maxParticipantsReached = selectedOptions.length === CONST.REPORT.MAXIMUM_PARTICIPANTS; | ||
| const headerMessage = OptionsListUtils.getHeaderMessage( | ||
| filteredPersonalDetails.length + filteredRecentReports.length !== 0, | ||
| Boolean(filteredUserToInvite), | ||
| searchTerm, | ||
| maxParticipantsReached, | ||
| ); | ||
| const isOptionsDataReady = ReportUtils.isReportDataReady() && OptionsListUtils.isPersonalDetailsReady(props.personalDetails); | ||
|
|
||
| const sections = useMemo(() => { | ||
| const sectionsList = []; | ||
| let indexOffset = 0; | ||
|
|
||
| if (props.isGroupChat) { | ||
| sectionsList.push({ | ||
| title: undefined, | ||
| data: selectedOptions, | ||
| shouldShow: !_.isEmpty(selectedOptions), | ||
| indexOffset, | ||
| }); | ||
| indexOffset += selectedOptions.length; | ||
|
|
||
| if (maxParticipantsReached) { | ||
| return sectionsList; | ||
| } | ||
| } | ||
|
|
||
| // Filtering out selected users from the search results | ||
| const filterText = _.reduce(selectedOptions, (str, {login}) => `${str} ${login}`, ''); | ||
| const recentReportsWithoutSelected = _.filter(filteredRecentReports, ({login}) => !filterText.includes(login)); | ||
| const personalDetailsWithoutSelected = _.filter(filteredPersonalDetails, ({login}) => !filterText.includes(login)); | ||
| const hasUnselectedUserToInvite = filteredUserToInvite && !filterText.includes(filteredUserToInvite.login); | ||
|
|
||
| sectionsList.push({ | ||
| title: props.translate('common.recents'), | ||
| data: recentReportsWithoutSelected, | ||
| shouldShow: !_.isEmpty(recentReportsWithoutSelected), | ||
| indexOffset, | ||
| }); | ||
| indexOffset += recentReportsWithoutSelected.length; | ||
|
|
||
| sectionsList.push({ | ||
| title: props.translate('common.contacts'), | ||
| data: personalDetailsWithoutSelected, | ||
| shouldShow: !_.isEmpty(personalDetailsWithoutSelected), | ||
| indexOffset, | ||
| }); | ||
| indexOffset += personalDetailsWithoutSelected.length; | ||
|
|
||
| if (hasUnselectedUserToInvite) { | ||
| sectionsList.push({ | ||
| title: undefined, | ||
| data: [filteredUserToInvite], | ||
| shouldShow: true, | ||
| indexOffset, | ||
| }); | ||
| } | ||
|
|
||
| return sectionsList; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps -- to avoid destructuring props and adding all 'props' as a dependency | ||
| }, [props.isGroupChat, props.translate, selectedOptions, filteredRecentReports, filteredPersonalDetails, filteredUserToInvite, maxParticipantsReached]); | ||
|
|
||
| const updateOptionsWithSearchTerm = (newSearchTerm = '') => { | ||
|
There was a problem hiding this comment. I didn't wrap it in
The first point is NA as Another reason is if we wrap it in There was a problem hiding this comment. @aimane-chnaif if I use function, eslint throws error - There was a problem hiding this comment. saw your comment on slack I will update the PR and only use There was a problem hiding this comment. didn't use function here as it was passed down as prop |
||
| const {recentReports, personalDetails, userToInvite} = OptionsListUtils.getNewChatOptions( | ||
| props.reports, | ||
| props.personalDetails, | ||
| props.betas, | ||
| newSearchTerm, | ||
| [], | ||
| props.isGroupChat ? excludedGroupEmails : [], | ||
| ); | ||
| setSearchTerm(newSearchTerm); | ||
| setFilteredRecentReports(recentReports); | ||
| setFilteredPersonalDetails(personalDetails); | ||
| setFilteredUserToInvite(userToInvite); | ||
| }; | ||
|
|
||
| /** | ||
| * Removes a selected option from list if already selected. If not already selected add this option to the list. | ||
| * @param {Object} option | ||
| */ | ||
| const toggleOption = (option) => { | ||
|
|
||
| const isOptionInList = _.some(selectedOptions, (selectedOption) => selectedOption.login === option.login); | ||
|
|
||
| let newSelectedOptions; | ||
|
|
||
| if (isOptionInList) { | ||
| newSelectedOptions = _.reject(selectedOptions, (selectedOption) => selectedOption.login === option.login); | ||
| } else { | ||
| newSelectedOptions = [...selectedOptions, option]; | ||
| } | ||
|
|
||
| const {recentReports, personalDetails, userToInvite} = OptionsListUtils.getNewChatOptions(props.reports, props.personalDetails, props.betas, searchTerm, [], excludedGroupEmails); | ||
|
|
||
| setSelectedOptions(newSelectedOptions); | ||
| setFilteredRecentReports(recentReports); | ||
| setFilteredPersonalDetails(personalDetails); | ||
| setFilteredUserToInvite(userToInvite); | ||
| }; | ||
|
|
||
| /** | ||
| * Creates a new 1:1 chat with the option and the current user, | ||
| * or navigates to the existing chat if one with those participants already exists. | ||
| * | ||
| * @param {Object} option | ||
| */ | ||
| const createChat = (option) => { | ||
|
|
||
| Report.navigateToAndOpenReport([option.login]); | ||
| }; | ||
|
|
||
| /** | ||
| * Creates a new group chat with all the selected options and the current user, | ||
| * or navigates to the existing chat if one with those participants already exists. | ||
| */ | ||
| const createGroup = () => { | ||
|
There was a problem hiding this comment. didn't use function here as it was passed down as prop |
||
| if (!props.isGroupChat) { | ||
| return; | ||
| } | ||
|
|
||
| const userLogins = _.pluck(selectedOptions, 'login'); | ||
| if (userLogins.length < 1) { | ||
| return; | ||
| } | ||
| Report.navigateToAndOpenReport(userLogins); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| updateOptionsWithSearchTerm(searchTerm); | ||
| // all dependencies are not added below - | ||
| // 1. searchTerm - when searchTerm changes updateOptionsWithSearchTerm is called by OptionsSelector's onChangeText prop | ||
| // 2. updateOptionsWithSearchTerm - it will change its reference upon each rerender unnecessarily | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [props.reports, props.personalDetails]); | ||
|
There was a problem hiding this comment. Only added these two dependencies based on the code in |
||
|
|
||
| return ( | ||
| <ScreenWrapper | ||
| includeSafeAreaPaddingBottom={false} | ||
| shouldEnableMaxHeight | ||
| > | ||
| {({didScreenTransitionEnd, safeAreaPaddingBottomStyle}) => ( | ||
| <> | ||
| <HeaderWithCloseButton | ||
| title={props.isGroupChat ? props.translate('sidebarScreen.newGroup') : props.translate('sidebarScreen.newChat')} | ||
| onCloseButtonPress={() => Navigation.dismissModal(true)} | ||
| /> | ||
| <View style={[styles.flex1, styles.w100, styles.pRelative, selectedOptions.length > 0 ? safeAreaPaddingBottomStyle : {}]}> | ||
| <OptionsSelector | ||
| canSelectMultipleOptions={props.isGroupChat} | ||
| sections={sections} | ||
| selectedOptions={selectedOptions} | ||
| value={searchTerm} | ||
| onSelectRow={(option) => (props.isGroupChat ? toggleOption(option) : createChat(option))} | ||
| onChangeText={updateOptionsWithSearchTerm} | ||
| headerMessage={headerMessage} | ||
| boldStyle | ||
| shouldFocusOnSelectRow={props.isGroupChat} | ||
| shouldShowConfirmButton={props.isGroupChat} | ||
| shouldShowOptions={didScreenTransitionEnd && isOptionsDataReady} | ||
| confirmButtonText={props.translate('newChatPage.createGroup')} | ||
| onConfirmSelection={createGroup} | ||
| textInputLabel={props.translate('optionsSelector.nameEmailOrPhoneNumber')} | ||
| safeAreaPaddingBottomStyle={safeAreaPaddingBottomStyle} | ||
| /> | ||
| </View> | ||
| </> | ||
| )} | ||
| </ScreenWrapper> | ||
| ); | ||
| }; | ||
|
|
||
| NewChatPage.propTypes = propTypes; | ||
| NewChatPage.defaultProps = defaultProps; | ||
| NewChatPage.displayName = 'NewChatPage'; | ||
|
|
||
| export default compose( | ||
| withLocalize, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
useMemohere as it was also used here -App/src/pages/tasks/TaskAssigneeSelectorModal.js
Line 124 in 156d099
But I propose to remove it following the guidelines in React docs -
2 and 3 are not applicable here. For the first point, the dependencies change often in our case which would anyway recalculate the value.
If you agree then we can remove it from
TaskAssigneeSelectorModaltoo because another issue there is that it usespropsas a dependency when it only uses props.translate during calculation -App/src/pages/tasks/TaskAssigneeSelectorModal.js
Line 163 in 156d099
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussion on useCallback, useMemo in slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aimane-chnaif I will remove useMemo here if you agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. I don't see much benefit of performance improvement using
useMemohere.