Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17046 — migrate PressableWithotFocus to GenericPressable #20202

Merged
merged 18 commits into from
Jun 16, 2023
Merged

17046 — migrate PressableWithotFocus to GenericPressable #20202

merged 18 commits into from
Jun 16, 2023

Commits on Jun 5, 2023

  1. migrate PressableWithotFocus to GenericPressable

    @robertKozik
    robertKozik committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    f42e37e View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. hoist GenericPressable proptypes to PressableWithoutFocus

    @robertKozik
    robertKozik committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    924e96a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. move PressableWithoutFoucs to Pressable folder

    @robertKozik
    robertKozik committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    c1d7329 View commit details
    Browse the repository at this point in the history

  2. fix propTypes of PressableWithFeedback - add missing propTypes

    @robertKozik
    robertKozik committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    bcea8ea View commit details
    Browse the repository at this point in the history

  3. hoist propTypes of ImageRenderer to the top of the file as stated in … 

    …guidelines
    @robertKozik
    robertKozik committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    0f9bc39 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Remove wrapperStyle proptype from PressableWithFeedback.js 

    Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
    @robertKozik @parasharrajat
    robertKozik and parasharrajat authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    af0e8c4 View commit details
    Browse the repository at this point in the history

  2. rename styling prop of PressableWithoutFocus to 'style'

    @robertKozik
    robertKozik committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    1f4d4b9 View commit details
    Browse the repository at this point in the history

  3. fix lint

    @robertKozik
    robertKozik committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    a6333e5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 17046-migrate-PressableWithoutFocus

    @robertKozik
    robertKozik authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    fa9ca8b View commit details
    Browse the repository at this point in the history

  5. change import of PressableWithoutFocus in ProfilePage.js

    @robertKozik
    robertKozik committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    6e47178 View commit details
    Browse the repository at this point in the history

  6. add accessibilityLabel for ProfilePage, pass styles as arrays

    @robertKozik
    robertKozik committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    6bfc85a View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Merge branch 'main' into 17046-migrate-PressableWithoutFocus

    @robertKozik
    robertKozik authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    65afa46 View commit details
    Browse the repository at this point in the history

  2. Change accessibility role of ImageRenderer pressable to imagebutton 

    Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
    @robertKozik @parasharrajat
    robertKozik and parasharrajat authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    ebce2d6 View commit details
    Browse the repository at this point in the history

  3. fix omitted prop name in PressableWithoutFocus 

    Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
    @robertKozik @parasharrajat
    robertKozik and parasharrajat authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9b167ac View commit details
    Browse the repository at this point in the history

  4. change accessibilityRole from button to imagebutton

    @robertKozik
    robertKozik committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    10e3774 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. change accessibility label for ImageRenderer component

    @robertKozik
    robertKozik committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8734e0b View commit details
    Browse the repository at this point in the history

  2. fix typo in translations 

    Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
    @robertKozik @parasharrajat
    robertKozik and parasharrajat authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    afb9b28 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Merge branch 'main' into 17046-migrate-PressableWithoutFocus

    @robertKozik
    robertKozik authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    30e0a94 View commit details
    Browse the repository at this point in the history